Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3rdparty] Bump to doctrine/dbal-2.7.2 #13633

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Jan 16, 2019

@rullzer
Copy link
Member Author

rullzer commented Jan 17, 2019

Seems this fails on

public function testAlterBigint() {

@nickvergessen @icewind1991 can one of you with postgres knowledge have a look?

@nickvergessen nickvergessen self-assigned this Jan 17, 2019
@nickvergessen
Copy link
Member

It's using BIGSERIAL instead of BIGINT, our hack was removed.

@nickvergessen
Copy link
Member

Basically the test was added to prevent exactly this from happening.
The column is a Bigserial now instead of Bigint and the column is default value is being dropped instead of being kept.

But since we update doctrine, if we go straight to 2.7.1 we can drop it aparently: owncloud/core#31059

@rullzer
Copy link
Member Author

rullzer commented Jan 17, 2019

I did the tiny steps because diretion to 2.9 failed hard.
once this is in we can bump to 2.7

@rullzer
Copy link
Member Author

rullzer commented Jan 17, 2019

but lets see about 2.7 tomorrow

@rullzer rullzer force-pushed the 3rdparty/doctrine/dbal-2.6.3 branch from 7da1bc3 to 8b11280 Compare January 24, 2019 10:29
@rullzer
Copy link
Member Author

rullzer commented Jan 24, 2019

Bumped it to 2.7.2 Lets see

@rullzer rullzer changed the title [3rdparty] Bump to doctrine/dbal-2.6.3 [3rdparty] Bump to doctrine/dbal-2.7.2 Jan 24, 2019
@rullzer
Copy link
Member Author

rullzer commented Jan 24, 2019

@nickvergessen this is 2.7.2 now. Could you have another look?

@nickvergessen
Copy link
Member

Well I guess now we need to delete the test, just like OC did?

@rullzer
Copy link
Member Author

rullzer commented Jan 24, 2019

@nickvergessen actually CI seems to be happy

@rullzer
Copy link
Member Author

rullzer commented Jan 30, 2019

Added patch

@rullzer rullzer force-pushed the 3rdparty/doctrine/dbal-2.6.3 branch from 4756b8f to 053fd6c Compare January 30, 2019 20:29
Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer force-pushed the 3rdparty/doctrine/dbal-2.6.3 branch from 053fd6c to f0fce59 Compare January 31, 2019 10:50
@rullzer rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 31, 2019
@rullzer
Copy link
Member Author

rullzer commented Jan 31, 2019

Ready for review :D

@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 31, 2019
@rullzer rullzer merged commit 61ee72a into master Jan 31, 2019
@rullzer rullzer deleted the 3rdparty/doctrine/dbal-2.6.3 branch January 31, 2019 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants