Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres 10 support #33187

Closed
3 tasks
PVince81 opened this issue Oct 15, 2018 · 9 comments
Closed
3 tasks

Postgres 10 support #33187

PVince81 opened this issue Oct 15, 2018 · 9 comments
Milestone

Comments

@PVince81
Copy link
Contributor

From #29997.

  • update to dbal v2.8 on master
  • setup Drone target for Postgres 10
  • fix all found issues, if any
@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #29625 (Drop sqlite support), #9889 (Setup for Postgres), #31352 (Update to 10.0.8 failed; Possible Postgres 10 Doctrine regression), #15124 (MPO support), and #8269 (Gravatar support?).

@PVince81
Copy link
Contributor Author

we already have the drone target https://github.com/owncloud/core/blob/master/.drone.yml#L622, closing

@gramakri
Copy link

@PVince81 Will Postgres 10 be supported in oc 10.1.0 or just oc 11? When can we expect oc 11 (I don't see a beta even).

@phil-davis
Copy link
Contributor

Note: https://github.com/doctrine/dbal/releases/tag/v2.6.0
"PHP 7.1.0 is the minimum supported PHP version"

core stable10 is dropping PHP 5.6 support, but for now keeps support for PHP 7.0. So composer in stable10 finds doctrine/dbal v2.5.13 - it can't yet use doctrine/dbal v2.6.0 or above.

In particular, we can't get to doctrine/dbal v2.8.0 in stable10 just yet :(

@phil-davis
Copy link
Contributor

phil-davis commented Jul 11, 2019

Note:

@phil-davis
Copy link
Contributor

Now that core master is the old core stable10 we no longer have the PostgreSQL 10 support code sitting in core master. It is now waiting in PR #35962

PostgreSQL 10 needs minimum PHP 7.1. So getting this into a release is blocked until we can drop PHP 7.0.

Reopening the issue so it gains visibility again.

@phil-davis phil-davis reopened this Aug 27, 2019
@phil-davis
Copy link
Contributor

phil-davis commented Nov 19, 2019

Code for this is in the commits waiting in #36289 and #36290

@phil-davis
Copy link
Contributor

PR #36498 runs the full test suite with postgres:10.3 as the database and passes.

@phil-davis
Copy link
Contributor

PR #36290 was merged. This is now in master for release in 10.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants