Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unreadable Header, when files are selected #3085

Closed
allo- opened this issue Apr 23, 2013 · 15 comments
Closed

unreadable Header, when files are selected #3085

allo- opened this issue Apr 23, 2013 · 15 comments
Assignees

Comments

@allo-
Copy link

allo- commented Apr 23, 2013

before selecting:
before
after selecting:
after

@DeepDiver1975
Copy link
Member

Please respect our contribution guideline and use the issue template as described:
https://github.com/owncloud/core/blob/master/CONTRIBUTING.md

@allo-
Copy link
Author

allo- commented Apr 24, 2013

too late, but the screenshots are quite obvious. Firefox 20, owncloud 5.0.5 (both latest versions anyway). server stuff is not relevant for design issues, and js-logs and such stuff should not be needed either.
steps to reproduce should be clear from the screenshots.

I think its just a html-layout issue, when the header element is inserted. As you see in before.png, the margin of the list-header is very low anyway.

@DeepDiver1975
Copy link
Member

I will not discuss the necessity of the information we ask in the issue template.

Please add your client operating system and version as well please - thx

@DeepDiver1975
Copy link
Member

@jancborchardt @raghunayyar can you please have a look? THX

@allo-
Copy link
Author

allo- commented Apr 24, 2013

Ubuntu 12.10 (Linux).

Not happening at a Ubuntu 12.04 with another firefox profile. I will have a look into my extensions / test with a clean profile as well.

@raghunayyar
Copy link
Member

Can't reproduce on Chrome 26.0.1410.65 and Firefox 15.0.1 on Mac OSX.

@allo-
Copy link
Author

allo- commented Apr 24, 2013

Oh, got it. It depends on font-size.

With ubuntu 12.10 chromium its shifting only by 2-3px, and with a fresh firefox profile by 1px.
The thing about my normal profile: i set a minimum font-size.

Steps to reproduce:

  • go to firefox preferences, content, fonts, advanced
  • set a minimum font-size (here 15). Note that your minimum font-size needs to be smaller/equal than your default font-size, else firefox resets it.
  • select one or more files in owncloud

with bigger font-sizes like 24, the effect even happens when no files are selected.

@Niduroki
Copy link
Member

Can't reproduce this as well on Chromium 28.0.1468.0 .
In Firefox 20.0 and Konqueror 4.10.2 the header moves up a little bit … But not that much, just about 2px …

@Niduroki
Copy link
Member

Ah … Can reproduce this with your steps …

I think this is related to css and em … (#2143)

@allo-
Copy link
Author

allo- commented Apr 24, 2013

What font-size did you try to reproduce it?

@Niduroki
Copy link
Member

@allo-: 15, just as you mentioned it.

@allo-
Copy link
Author

allo- commented Apr 24, 2013

With font-size 24 as default-font-size (leaving minimum font-size as it is)
font-size-24

And with chromium and font-size (in advanced settings) set to "very large" (whatever this really means)
chromium-font-size-verylarge

hope this helps

@MorrisJobke
Copy link
Contributor

I can confirm this with font sizes greater than 16. Then the files header moves downwards and other elements don't fit in.

@raghunayyar
Copy link
Member

Ok. This confirms that this issue is related to the all time problematic em to px conversion. Will do the conversion in the coming days. Self assigning.

@ghost ghost assigned raghunayyar Apr 24, 2013
@jancborchardt
Copy link
Member

Yeah, this is a duplicate of #801 (error with small font sizes). We need to use px only, and I would also say to move the base font size to 16px (as smallest size), in regard to touch interfaces and general readability.

@raghunayyar big thanks for taking that up! Make sure to do it in small steps please (maybe start with personal page only, then files app, etc etc.), and only do the move to 16px after there’s no em in the code anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants