Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4495, part of #3088, #4467, #4505, #4266, #4446: Miscellaneous alpha MR5 fixes #4506

Merged
merged 11 commits into from
Aug 19, 2022

Conversation

BenHenning
Copy link
Member

@BenHenning BenHenning commented Aug 17, 2022

Explanation

Fixes #4495
Fixes part of #3088
Fixes #4467
Fixes #4505
Fixes #4266
Fixes #4446

This PR fixes a number of key blockers for the upcoming Alpha MR5 release of the app. In particular:

Note that there are no new tests being added in this PR since the fixes are mostly trivial and have been manually verified during development. #4510 is tracking adding automated tests for long-term app health.

Furthermore, AudioViewModel was allow-listed to reference Locale directly so that it can it include a localized language name in the fail-to-play audio notice. #3791 will fix this in the long-term.

This PR also includes version code & minor version bumps to prepare for the upcoming release. It also fixes the Kenya-specific alpha build flavor (which was unfortunately checked in as broken in #4507), and adds it to CI since the assumption in #4507 that it doesn't need to be covered is incorrect. The Gradle workaround for the new flavor was removed since it was a legitimate failure that wasn't being picked up by Bazel builds in CI.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Creating profile names with normally forbidden characters (in this case, numbers):

create_profile_with_number.mp4

Demonstrating when English audio is sometimes unavailable & the new notice to make this clearer:

english_audio_unavailable.mp4

Audio not being available can occur in all languages, not just English:

audio_unavailable

Text input hints can now be multi-line to ensure that they're not cut off:

oppia_multiline_text_input_hint

@BenHenning BenHenning changed the title Fix #4495, part of #3088, #4467, #4505, #4266: Miscellaneous alpha MR5 fixes Fix #4495, part of #3088, #4467, #4505, #4266, #4446: Miscellaneous alpha MR5 fixes Aug 17, 2022
@BenHenning
Copy link
Member Author

Similar to other PRs, force-merging this with the intent of post-merge review (to help expedite the alpha release dependent on these changes).

@BenHenning BenHenning merged commit 091b45a into develop Aug 19, 2022
@BenHenning BenHenning deleted the assorted-alpha-mr5-fixes branch August 19, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant