Fast-follow work items from MR5 (mainly reviews and open comments) #4510
Assignees
Labels
bug
End user-perceivable behaviors which are not desirable.
Impact: Low
Low perceived user impact (e.g. edge cases).
Work: Medium
The means to find the solution is clear, but it isn't at good-first-issue level yet.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Milestone
Comments
This was referenced Aug 19, 2022
BenHenning
added a commit
that referenced
this issue
Aug 19, 2022
## Explanation Fixes #4492 by introducing a complete revamp of the hint & solution management flow in the app (see designs below). Fixes #3537 by merging the hint summary layouts. Note that one part of #4492 isn't implemented: pausing the hint timer while hints are being viewed. Ensuring this is properly implemented is being tracked as part of #4510. Two new test exemptions were added: one for a new view model file (which seems sensible since most of the changes in this PR are aesthetic and not functional), and a second for a new hints configuration module that's specific to the alpha user study build of the app (which is temporary and we generally don't test thoroughly, anyway). **Designs** https://xd.adobe.com/view/3dca36c2-5115-419c-b25e-0f10526b077c-6899/screen/619724cc-0ecf-4c32-a452-432fded803f5/specs/ https://xd.adobe.com/view/3dca36c2-5115-419c-b25e-0f10526b077c-6899/screen/5311124a-b143-4916-aa46-6e318aca5650/specs/ https://xd.adobe.com/view/3dca36c2-5115-419c-b25e-0f10526b077c-6899/screen/545c6f32-2fec-4a8b-bb53-cecfb8e52f31/specs/ ## Essential Checklist - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide)) - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing ## Mobile Portrait <img src="https://user-images.githubusercontent.com/9396084/184692122-20fe436f-9665-4870-865a-08df78c41200.png" width="250" /> <img src="https://user-images.githubusercontent.com/9396084/184692133-f9415819-06eb-4ab2-b4b1-729c7d7bb0ae.png" width="250" /> <img src="https://user-images.githubusercontent.com/9396084/184692140-19016b5b-9911-4b69-a990-032ba417f33b.png" width="250" /> <img src="https://user-images.githubusercontent.com/9396084/184692143-62899a72-7b89-4e0f-b32f-0bc98f62785a.png" width="250" /> <img src="https://user-images.githubusercontent.com/9396084/184692144-cba61f52-e37f-40b9-ac0c-b58287974699.png" width="250" /> <img src="https://user-images.githubusercontent.com/9396084/184692145-71a50dc6-e91c-464e-967a-778d62a6c81d.png" width="250" /> ## Mobile Landscape <img src="https://user-images.githubusercontent.com/9396084/184692403-51e1929e-b99f-4af5-b2cf-c3d61cb0e242.png" width="350" /> <img src="https://user-images.githubusercontent.com/9396084/184692422-7d8c37d2-683b-4ac9-ad2b-f1d96344f1be.png" width="350" /> <img src="https://user-images.githubusercontent.com/9396084/184692426-94573514-6caf-4237-b9b4-f413675aa19c.png" width="350" /> <img src="https://user-images.githubusercontent.com/9396084/184692432-22435a68-c266-46d0-baf3-5f2662ab33d4.png" width="350" /> ## Tablet <img src="https://user-images.githubusercontent.com/9396084/184694579-b4fbaf8e-44b3-4321-8464-def773cd5e6d.png" width="250" /> <img src="https://user-images.githubusercontent.com/9396084/184694593-19870c10-81be-4b9e-a737-86954358f5aa.png" width="250" /> ## Return to Lesson button **NOTE**: This button was created later on that's why not all screenshots contain this button but the below screenshot should suffice. It is fully functional too. <img src="https://user-images.githubusercontent.com/9396084/184706834-1cfa14c7-24a5-42f7-be46-252ab48ec536.png" width="250" /> <img src="https://user-images.githubusercontent.com/9396084/184706842-07fcdfcb-4413-48bf-9aaf-5d1da4dde12e.png" width="250" /> <img src="https://user-images.githubusercontent.com/9396084/184706856-cc76720b-7ccb-41c8-83b7-742e9820a70c.png" width="250" /> <img src="https://user-images.githubusercontent.com/9396084/184706853-510c4b6c-c964-439c-8013-426feceb5116.png" width="450" /> ## Dark Mode (Not Implemented) Do not have designs for dark mode ## RTL Support <img src="https://user-images.githubusercontent.com/9396084/184695143-6852926b-d380-424f-9105-a10a05de8836.png" width="250" /> ## Accessibility Output There are few issues but not solving them right now. ## Video Output https://user-images.githubusercontent.com/9396084/184695958-d23f1d77-a2f0-43bd-848a-43483f11fb04.mp4 Commits: * UI for xml files * Removed divider * Removed const value * Multie expand issue fixed * Tablet UI changes * Added return to topic button * Removed index multiplier from tests * Updated tests * nit fixes * nit fixes * Fixed implementation * Updated tests * Fixed test case * Bazel fix * Minor suggested changes * Nit fixes * Revert back string change for hint button. * Fix broken hints. Update hint delay times for the Kenya-specific alpha build of the app. Co-authored-by: Ben Henning <[email protected]>
BenHenning
added a commit
that referenced
this issue
Aug 19, 2022
…lpha MR5 fixes (#4506) ## Explanation Fixes #4495 Fixes part of #3088 Fixes #4467 Fixes #4505 Fixes #4266 Fixes #4446 This PR fixes a number of key blockers for the upcoming Alpha MR5 release of the app. In particular: - It fixes #4266 by reformatting one XML file that Rajat left a comment for during his post-merge reviews of Alpha MR4 PRs. - It mitigates #4495 by introducing a banner for when correct audio can't be played (I did run into an actual bug where the wrong audio played once, but I couldn't repro it--most of the time the app will stop autoplaying if it can't find the correct language). This also fixes part of #3088 since the mitigation will help make that situation better. - It addresses #4467 by logging stringified versions of all supported answer types upon answer submission (rather than just whether the answer is correct). - It addresses #4446 by (1) introducing a new default hint text for text input, and (2) by ensuring hint text is fully readable by wrapping it when it extends to more than one line. However, another issue was discovered which would be really nice to fix (but is not feasible given the amount of time available for this PR). #4509 is tracking this future work. - It addresses #4505 by disabling profile name verification when the learner study is enabled (as a stop-gap). Note that there are no new tests being added in this PR since the fixes are mostly trivial and have been manually verified during development. #4510 is tracking adding automated tests for long-term app health. Furthermore, AudioViewModel was allow-listed to reference Locale directly so that it can it include a localized language name in the fail-to-play audio notice. #3791 will fix this in the long-term. This PR also includes version code & minor version bumps to prepare for the upcoming release. It also fixes the Kenya-specific alpha build flavor (which was unfortunately checked in as broken in #4507), and adds it to CI since the assumption in #4507 that it doesn't need to be covered is incorrect. The Gradle workaround for the new flavor was removed since it was a legitimate failure that wasn't being picked up by Bazel builds in CI. ## Essential Checklist - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only Creating profile names with normally forbidden characters (in this case, numbers): https://user-images.githubusercontent.com/12983742/185594638-3bd653a4-916a-4471-963a-d00ab987f378.mp4 Demonstrating when English audio is sometimes unavailable & the new notice to make this clearer: https://user-images.githubusercontent.com/12983742/185594719-896e428c-96b8-42f3-b53f-721352a90f14.mp4 Audio not being available can occur in all languages, not just English:  Text input hints can now be multi-line to ensure that they're not cut off:  Commits: * Address #4274 (comment). This is part of addressing #4266. * Add audio notice for when language is missing. * Disable invalid profile name rules for studies. * Add analytics logging for submitted answers. * Code health fixes. * Add hint wrapping, and default text input hint. * Fix broken tests. * Test fixes. * Fix broken Kenya-specific alpha build. Also, bump version codes & minor versions in preparation for the release.
BenHenning
added
issue_type_infrastructure
Impact: Low
BenHenning
moved this to Needs Triage
in [Team] Developer Workflow & Infrastructure - Android
seanlip
added
bug
MohitGupta121
added
the
Work: Medium
seanlip
changed the title
seanlip
changed the title
seanlip
changed the title
This was referenced Jun 9, 2023
seanlip
changed the title
MohitGupta121
moved this from Todo
to In Progress
in [Team] Developer Workflow & Infrastructure - Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PRs that need to be post-merge reviewed:
PRs that have open comments to resolve:
Note:
The text was updated successfully, but these errors were encountered: