Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Missing tests from Alpha MR5 #5036

Open
8 tasks
seanlip opened this issue Jun 9, 2023 · 0 comments
Open
8 tasks

[BUG]: Missing tests from Alpha MR5 #5036

seanlip opened this issue Jun 9, 2023 · 0 comments
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@seanlip
Copy link
Member

seanlip commented Jun 9, 2023

Some PRs that were merged for the MR5 release (in Aug 2022) have additional tests that need to be written. These are described below:

  • Fix #4495, part of #3088, #4467, #4505, #4266, #4446: Miscellaneous alpha MR5 fixes #4506
    • Tests for single-line/multi-line hint text for interactions: text input, math expression input, ratio input, fraction input, numeric input
    • Test for new default hint text for text input interaction
    • Tests for new audio notice that shows when the current playing language can't continue for voiceovers (presence show/hide + specific languages)
    • Tests for ExplorationProgressController passing the correct answer object for event logging
    • Tests for LearnerAnalyticsLogger correctly converting all supported answer types to stringified versions
    • Tests for EventBundleCreator correctly including stringified answers even for non-sensitive situations, and that they're capped to 100 characters
    • Test for ProfileManagementController that profile name validation is disabled when the learner study feature is enabled
  • Fix #4494: Hint bulb animation added #4501
    • Tests for the new LifecycleSafeTimerFactory changes (and maybe refactor away createTimer in favor of the new methods)

The aim of this issue is to write these tests.

(This issue was originally part of #4510 but has been split out to isolate the "missing tests" action items.)

@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. triage needed labels Jun 9, 2023
@seanlip seanlip changed the title [BUG]: Missing tests from MR5 [BUG]: Missing tests from Alpha MR5 Jun 9, 2023
@MohitGupta121 MohitGupta121 added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: High It's not clear what the solution is. Z-ibt Temporary label for Ben to keep track of issues he's triaged. labels Jun 16, 2023
@adhiamboperes adhiamboperes added Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. and removed Work: High It's not clear what the solution is. labels Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

3 participants