-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Fix hint timers continuing to count while hints are being viewed #5037
Comments
NB: This is actually a bit tricky to fix since we intentionally moved hints & solution tracking state into the domain layer to fix a bunch of problems that can be caused by transient UI state. I think we need some sort of signal passed from the UI to the domain layer on whether the hints are being actively viewed, and whether the app is in the foreground (the latter we already have some solutions for, see #4916). |
I want to work on this but I can't get the clarity of this bug. @adhiamboperes @seanlip @kkmurerwa @BenHenning may someone please explain this to me? |
@seanlip should we only be running the hint timer when the user is actively seeing the state card? It makes sense to pause when the hint dialog is open, but what about other cases such as concept cards linked from the state content where the user might not be actively viewing the state? |
@BenHenning Thanks for checking -- I think there are arguments for going either way on that, so whatever is technically easiest is fine. If you want a clearer direction, though, then I think I would lean towards leaving the hint timer counting if the user is viewing a concept card, since they might be doing so in order to review the skill before trying the question again (so this feels like "productive time" to me). |
This issue is opened to track a part of #4492 that was not fixed in #4500, namely, pausing the hint timer while hints are being viewed. From the original issue:
We encountered some challenges when trying to fix this originally. Per @BenHenning (see #4500 (comment)):
The aim of this issue is to fix this bug. (This is part of the fast-follow items from #4510.)
The text was updated successfully, but these errors were encountered: