Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom math keyboard for math expression input interactions. #4502

Open
seanlip opened this issue Aug 16, 2022 · 8 comments
Open
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@seanlip
Copy link
Member

seanlip commented Aug 16, 2022

Is your feature request related to a problem? Please describe.

In math expression contexts, when a student types * in the Android app, the character * is displayed, and similarly for -. However, this causes confusion because students are used to using × and − instead (and in fact this is what they see when entering similar things in the corresponding interaction fields on Oppia Web).

Describe the solution you'd like

The aim of this issue is to show × and − signs instead when a student types the * and - characters. These should be shown in the input box while they are typing their answer (i.e. these are how the characters should appear within the input box itself).

@seanlip seanlip added Type: Improvement Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Aug 16, 2022
@seanlip seanlip added this to the Alpha MR5 milestone Aug 16, 2022
@BenHenning
Copy link
Member

I actually took a look at this and it seems that Android does use the correct characters in the represented answer (since the app renders the expression to LaTeX and, as part of that, replaces the characters). I don't think any additional work is needed here.

@BenHenning BenHenning closed this as not planned Won't fix, can't repro, duplicate, stale Aug 17, 2022
@seanlip
Copy link
Member Author

seanlip commented Aug 17, 2022

@BenHenning To be clear, I'm talking about in the input field just after the student has typed the character (but not yet submitted), rather than in the represented answer after the student has submitted. Could you please confirm that the former is the case?

@seanlip seanlip reopened this Aug 17, 2022
@BenHenning
Copy link
Member

Ah, I didn't realize that's what you mean. Switching out characters from underneath the student is not a trivial task @seanlip and not something I'd want to risk here. FWIW, the Android keyboard already lets you input × and − directly, so I'm also not sure that the same use case is as necessary here.

@seanlip
Copy link
Member Author

seanlip commented Aug 17, 2022

OK, yup -- that was what I was referring to in our call. I was surprised that it seemed easy; thanks for looking into this.

I want to check what you mean by "the Android keyboard already lets you input × and − directly", though? The keyboard looks like the standard one. Here is a screenshot that I got from @rt4914 for numeric expression input -- note that there's only a * and no ×. (Which is fine, I just wanted to double-check this because I have put notes in the lessons instructing students to type *.)

2255fb37-5dda-4361-8bd7-033781f91029

@BenHenning
Copy link
Member

You need to open up the number keyboard (via ?123) and then another button appears where the caps button shows now with symbols. Opening the symbols will show various math operators include multiplication and division.

@seanlip
Copy link
Member Author

seanlip commented Aug 17, 2022

OK, thanks.

As discussed I think the correct long-term solution here is to have a custom math keyboard for numeric expression input that has the multiplication symbol. In the short term we can leave the current behaviour as-is.

@BenHenning
Copy link
Member

Given that we don't yet have a tracking issue for the custom math keyboard, let's keep this one open.

I'm moving it out of the MR5 blocker list since the main mitigation (supporting multi-line placeholder hints for text-based interactions) is being implemented as part of #4506).

@BenHenning BenHenning removed this from the Alpha MR5 milestone Aug 19, 2022
@seanlip seanlip changed the title Show * and - characters in math expression inputs as × and − signs, respectively. Implement custom math keyboard for math expression input interactions. Aug 22, 2022
@seanlip
Copy link
Member Author

seanlip commented Aug 22, 2022

Thanks, sounds good. I renamed the issue accordingly.

@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
@BenHenning BenHenning removed their assignment Sep 20, 2022
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_type_enhancement labels Mar 29, 2023
@adhiamboperes adhiamboperes added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

3 participants