Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard should be visible by default in Admin PIN #572

Closed
rt4914 opened this issue Dec 25, 2019 · 2 comments · Fixed by #573
Closed

Keyboard should be visible by default in Admin PIN #572

rt4914 opened this issue Dec 25, 2019 · 2 comments · Fixed by #573
Assignees
@Luffy18346
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Dec 25, 2019

Screenshot_1577256328

In the above screen, the user will need to click the first edittext box to make the keyboard visible and then start typing the PIN.

To improve the UX, the keyboard should be directly visible to reduce that one extra click.
Also, write test case for this functionality in the respective file too.
@Luffy18346 Luffy18346 mentioned this issue Dec 25, 2019
Merged
8 tasks
@rt4914 rt4914 self-assigned this Jan 2, 2020
@rt4914 rt4914 assigned Luffy18346 and unassigned rt4914 Jan 23, 2020
@PrarabdhGarg
Copy link
Contributor

@Luffy18346 can I solve this issue?

@rt4914
Copy link
Contributor Author

rt4914 commented Jan 31, 2020

@PrarabdhGarg this has already been solved by @Luffy18346 the PR is already out there. Also those issues which are not assigned to someone you can take that.Also for now I have assigned you a new issue you can work on that for now.

@Luffy18346 Luffy18346 assigned rt4914 and Luffy18346 and unassigned Luffy18346 and rt4914 Jan 31, 2020
rt4914 pushed a commit that referenced this issue Feb 3, 2020
@Luffy18346
Fix #572: Keyboard visible by default in Admin Pin (#573)
1b24301 
* By default keyboard visibility issue in Admin Pin is resolved

* Created a test case to check about Keyboard visibility by default in Admin Pin.

* Test is modified with the suggested changes
PrarabdhGarg pushed a commit to PrarabdhGarg/oppia-android that referenced this issue Feb 12, 2020
@Luffy18346 @PrarabdhGarg
Fix oppia#572: Keyboard visible by default in Admin Pin (oppia#573)
52e1eb4 
* By default keyboard visibility issue in Admin Pin is resolved

* Created a test case to check about Keyboard visibility by default in Admin Pin.

* Test is modified with the suggested changes
rt4914 pushed a commit that referenced this issue Feb 13, 2020
@PrarabdhGarg @Luffy18346 @veena14cs
Fix #590: Full UI Switch Profile Option (#651)
018f06f 
* Fix #572: Keyboard visible by default in Admin Pin (#573)

* By default keyboard visibility issue in Admin Pin is resolved

* Created a test case to check about Keyboard visibility by default in Admin Pin.

* Test is modified with the suggested changes

* Fix #577:  Display profile name on navigation drawer. (#578)

* display profile name in navigation drawer

* Updated code implementation

* adding tests

* added testcases

* Update NavigationDrawerFragmentPresenter.kt

* updated nit changes.

* Fix part #44: Full UI profile pin/password screen. (#597)

* done ui corrections

* fixed issues.

* Update pin_password_activity.xml

* updated color

* updated icon

* updated pinview shadow

* updated icon color

* changed shadow

* updated mock color

* fix

* Update pin_password_activity.xml

* updated nit change.

* Update pin_password_activity.xml

* removed fixed width

* fixed dimen file changes

* Update dimens.xml

* Fix part #632: Replace current recyclerview implementation with BindableAdapter usage. (#641)

* working on topic practice.

* reverted

* updated implementation

* Update ContinuePlayingFragmentPresenter.kt

* Update ContinuePlayingFragmentPresenter.kt

* Update ContinuePlayingItemViewModel.kt

* Delete OngoingListAdapter.kt

* nit change

* Update ContinuePlayViewModel.kt

* fixed nit

* Add UI and finctionality for Switch Profile

* Add UI Tests for switch profile option in navigation drawer

* Add UI Tests for switch profile option in navigation drawer

* Minor styling changes

Co-authored-by: Akash Koradia <[email protected]>
Co-authored-by: Veena <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Luffy18346 Luffy18346

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #572: Keyboard visible by default in Admin Pin Luffy18346/oppia-android
4 participants
@rt4914 @BenHenning @Luffy18346 @PrarabdhGarg