Fix part #44: Full UI profile pin/password screen. #597

veena14cs · 2020-01-09T06:25:40Z

Explanation

This PR fixes UI for profile pin/ password screen.

Mock

https://xd.adobe.com/view/0687f00c-695b-437a-79a6-688e7f4f7552-70b6/screen/d59621be-cceb-4686-9442-68dd6b3e2ee2/PC-AP-Filled-

https://xd.adobe.com/view/0687f00c-695b-437a-79a6-688e7f4f7552-70b6/screen/dc5dd024-cff4-4419-80a5-24147371bb72/PC-NP-Empty-Error-

Accessibility Scanner

Passes Accessibility scanner test

Screenshot

Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
The PR follows the style guide.
The PR does not contain any unnecessary auto-generated code from Android Studio.
The PR is made from a branch that's not called "develop".
The PR is made from a branch that is up-to-date with "develop".
The PR's branch is based on "develop" and not on any other branch.
The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

rt4914

PTAL

app/src/main/res/layout/pin_password_activity.xml

rt4914

PTAL

app/src/main/res/layout/pin_password_activity.xml

rt4914

LGTM, marked some conversations as unresolved.

nikitamarysolomanpvt

Please confirm regarding the border with @mschanteltc because in mock there are not borders to the pinview. Also please use proper eye icons as per mock.

veena14cs · 2020-01-09T09:55:44Z

Please confirm regarding the border with @mschanteltc because in mock there are not borders to the pinview. Also please use proper eye icons as per mock.

@mschanteltc can you please provide me icons to show and hide password.

mschanteltc · 2020-01-09T21:00:17Z

Please confirm regarding the border with @mschanteltc because in mock there are not borders to the pinview. Also please use proper eye icons as per mock.

@mschanteltc can you please provide me icons to show and hide password.

Yes, it's available in the Android Image drive under the folder "Profile Chooser."

mschanteltc · 2020-01-09T21:03:50Z

Also there is no border, but there is a #000000 shadow at 30% opacity with a blur of 3.

veena14cs · 2020-01-10T05:47:43Z

Please confirm regarding the border with @mschanteltc because in mock there are not borders to the pinview. Also please use proper eye icons as per mock.

@mschanteltc can you please provide me icons to show and hide password.

Yes, it's available in the Android Image drive under the folder "Profile Chooser."

There is slight confusion in the show/hide icon along with the text. As per the mock hide_eye_icon is been used with show text. But in our implementation it is other way. Which one is correct in this.

mschanteltc · 2020-01-10T21:49:43Z

Please confirm regarding the border with @mschanteltc because in mock there are not borders to the pinview. Also please use proper eye icons as per mock.

@mschanteltc can you please provide me icons to show and hide password.

Yes, it's available in the Android Image drive under the folder "Profile Chooser."

There is slight confusion in the show/hide icon along with the text. As per the mock hide_eye_icon is been used with show text. But in our implementation it is other way. Which one is correct in this.

I agree with your implementation. I updated the mocks to reflect this.

veena14cs · 2020-01-13T05:28:32Z

Please confirm regarding the border with @mschanteltc because in mock there are not borders to the pinview. Also please use proper eye icons as per mock.

@mschanteltc can you please provide me icons to show and hide password.

Yes, it's available in the Android Image drive under the folder "Profile Chooser."

There is slight confusion in the show/hide icon along with the text. As per the mock hide_eye_icon is been used with show text. But in our implementation it is other way. Which one is correct in this.

I agree with your implementation. I updated the mocks to reflect this.

Thanks for clarification.

nikitamarysolomanpvt

LGTM

rt4914

One change in dimens file, else looks great.

app/src/main/res/layout/pin_password_activity.xml

app/src/main/res/values-xhdpi/dimens.xml

rt4914

LGTM.

rt4914 · 2020-02-04T17:52:18Z

@veena14cs Lets not block this PR anymore just because of two different dimens.xml file. I will keep track of this and discuss this with @BenHenning and meanwhile you can merge this PR.

veena14cs · 2020-02-05T04:26:24Z

@veena14cs Lets not block this PR anymore just because of two different dimens.xml file. I will keep track of this and discuss this with @BenHenning and meanwhile you can merge this PR.

Okay will merge this PR thanks.

BenHenning · 2020-02-05T16:55:19Z

Having multiple dimension files seems sensible.

veena14cs · 2020-02-06T05:50:19Z

Having multiple dimension files seems sensible.

Got it thanks.

* done ui corrections * fixed issues. * Update pin_password_activity.xml * updated color * updated icon * updated pinview shadow * updated icon color * changed shadow * updated mock color * fix * Update pin_password_activity.xml * updated nit change. * Update pin_password_activity.xml * removed fixed width * fixed dimen file changes * Update dimens.xml

* Fix #572: Keyboard visible by default in Admin Pin (#573) * By default keyboard visibility issue in Admin Pin is resolved * Created a test case to check about Keyboard visibility by default in Admin Pin. * Test is modified with the suggested changes * Fix #577: Display profile name on navigation drawer. (#578) * display profile name in navigation drawer * Updated code implementation * adding tests * added testcases * Update NavigationDrawerFragmentPresenter.kt * updated nit changes. * Fix part #44: Full UI profile pin/password screen. (#597) * done ui corrections * fixed issues. * Update pin_password_activity.xml * updated color * updated icon * updated pinview shadow * updated icon color * changed shadow * updated mock color * fix * Update pin_password_activity.xml * updated nit change. * Update pin_password_activity.xml * removed fixed width * fixed dimen file changes * Update dimens.xml * Fix part #632: Replace current recyclerview implementation with BindableAdapter usage. (#641) * working on topic practice. * reverted * updated implementation * Update ContinuePlayingFragmentPresenter.kt * Update ContinuePlayingFragmentPresenter.kt * Update ContinuePlayingItemViewModel.kt * Delete OngoingListAdapter.kt * nit change * Update ContinuePlayViewModel.kt * fixed nit * Add UI and finctionality for Switch Profile * Add UI Tests for switch profile option in navigation drawer * Add UI Tests for switch profile option in navigation drawer * Minor styling changes Co-authored-by: Akash Koradia <[email protected]> Co-authored-by: Veena <[email protected]>

done ui corrections

ed9835a

veena14cs requested review from rt4914 and nikitamarysolomanpvt January 9, 2020 06:26

veena14cs assigned rt4914 and nikitamarysolomanpvt Jan 9, 2020

rt4914 suggested changes Jan 9, 2020

View reviewed changes

rt4914 assigned veena14cs and unassigned rt4914 Jan 9, 2020

rt4914 suggested changes Jan 9, 2020

View reviewed changes

app/src/main/res/layout/pin_password_activity.xml Outdated Show resolved Hide resolved

veena14cs requested a review from mschanteltc January 9, 2020 08:18

veena14cs assigned mschanteltc Jan 9, 2020

veena14cs added 2 commits January 9, 2020 13:59

fixed issues.

2210928

Update pin_password_activity.xml

4430c7f

veena14cs assigned rt4914 Jan 9, 2020

veena14cs requested a review from rt4914 January 9, 2020 08:54

updated color

7b31f3a

nikitamarysolomanpvt reviewed Jan 9, 2020

View reviewed changes

app/src/main/res/layout/pin_password_activity.xml Outdated Show resolved Hide resolved

rt4914 approved these changes Jan 9, 2020

View reviewed changes

rt4914 removed their assignment Jan 9, 2020

nikitamarysolomanpvt suggested changes Jan 9, 2020

View reviewed changes

nikitamarysolomanpvt removed their assignment Jan 9, 2020

updated icon

8f3b521

updated pinview shadow

beb122a

veena14cs requested a review from nikitamarysolomanpvt January 13, 2020 06:17

nikitamarysolomanpvt approved these changes Jan 17, 2020

View reviewed changes

nikitamarysolomanpvt assigned veena14cs and unassigned nikitamarysolomanpvt Jan 17, 2020

veena14cs requested a review from rt4914 January 20, 2020 06:26

veena14cs assigned rt4914 and unassigned veena14cs and mschanteltc Jan 20, 2020

veena14cs added 2 commits January 20, 2020 11:58

Update pin_password_activity.xml

f77cde4

removed fixed width

a9548b2

rt4914 reviewed Jan 20, 2020

View reviewed changes

app/src/main/res/layout/pin_password_activity.xml Outdated Show resolved Hide resolved

app/src/main/res/values-xhdpi/dimens.xml Outdated Show resolved Hide resolved

veena14cs added 2 commits January 20, 2020 14:27

fixed dimen file changes

78a2b62

Update dimens.xml

0af5cfc

rt4914 approved these changes Jan 20, 2020

View reviewed changes

rt4914 assigned veena14cs and unassigned rt4914 Jan 20, 2020

veena14cs requested a review from BenHenning January 24, 2020 09:41

veena14cs assigned BenHenning and unassigned veena14cs Jan 24, 2020

rt4914 assigned veena14cs and unassigned BenHenning Feb 4, 2020

veena14cs merged commit 38a6a90 into develop Feb 5, 2020

veena14cs deleted the hifi-pin-password branch February 5, 2020 04:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix part #44: Full UI profile pin/password screen. #597

Fix part #44: Full UI profile pin/password screen. #597

veena14cs commented Jan 9, 2020 •

edited

Loading

rt4914 left a comment

rt4914 left a comment

rt4914 left a comment

nikitamarysolomanpvt left a comment •

edited

Loading

veena14cs commented Jan 9, 2020

mschanteltc commented Jan 9, 2020

mschanteltc commented Jan 9, 2020

veena14cs commented Jan 10, 2020

mschanteltc commented Jan 10, 2020

veena14cs commented Jan 13, 2020

nikitamarysolomanpvt left a comment

rt4914 left a comment

rt4914 left a comment

rt4914 commented Feb 4, 2020

veena14cs commented Feb 5, 2020

BenHenning commented Feb 5, 2020

veena14cs commented Feb 6, 2020

Fix part #44: Full UI profile pin/password screen. #597

Fix part #44: Full UI profile pin/password screen. #597

Conversation

veena14cs commented Jan 9, 2020 • edited Loading

Explanation

Mock

Accessibility Scanner

Screenshot

Checklist

rt4914 left a comment

Choose a reason for hiding this comment

rt4914 left a comment

Choose a reason for hiding this comment

rt4914 left a comment

Choose a reason for hiding this comment

nikitamarysolomanpvt left a comment • edited Loading

Choose a reason for hiding this comment

veena14cs commented Jan 9, 2020

mschanteltc commented Jan 9, 2020

mschanteltc commented Jan 9, 2020

veena14cs commented Jan 10, 2020

mschanteltc commented Jan 10, 2020

veena14cs commented Jan 13, 2020

nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

rt4914 left a comment

Choose a reason for hiding this comment

rt4914 left a comment

Choose a reason for hiding this comment

rt4914 commented Feb 4, 2020

veena14cs commented Feb 5, 2020

BenHenning commented Feb 5, 2020

veena14cs commented Feb 6, 2020

veena14cs commented Jan 9, 2020 •

edited

Loading

nikitamarysolomanpvt left a comment •

edited

Loading