Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full UI: Switch Profile Option in Navigation Drawer #590

Closed
3 tasks
rt4914 opened this issue Jan 6, 2020 · 7 comments · Fixed by #651
Closed
3 tasks

Full UI: Switch Profile Option in Navigation Drawer #590

rt4914 opened this issue Jan 6, 2020 · 7 comments · Fixed by #651
Assignees
@PrarabdhGarg
Labels
good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jan 6, 2020 •
edited
Loading

The Navigation Drawer needs Switch Profile option. (The svg file for the icon will be shared on email.)
Screenshot 2020-01-06 at 2 58 29 PM

When learner clicks on this option, it should open the alert dialog which is shown when learner presses back button on home screen.
Screenshot 2020-01-06 at 2 58 39 PM

Also, add test cases to test this functionality.

Checklist

  • Change the text of home_activity_back_dialog_message in strings.xml file as per mocks.
  • Add Switch Profile option along with its functionality.
  • Add test cases for the Switch Profile options. (Check NavigationDrawerTestActivity and NavigationDrawerTestActivityTest files for writing test cases)
@rt4914 rt4914 self-assigned this Jan 6, 2020
@rt4914
Copy link
Contributor Author

rt4914 commented Jan 16, 2020

This PR is assigned to new contributor @maheshpaliwal

@rt4914 rt4914 added the good first issue This item is good for new contributors to make their pull request. label Jan 23, 2020
@rt4914
Copy link
Contributor Author

rt4914 commented Feb 12, 2020

Unassigning @maheshpaliwal from this PR as it has been too long. Also, he has one more assigned PR to him so will wait for that to finish.

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 12, 2020

Assigning this to @PrarabdhGarg now.

@rt4914 rt4914 assigned PrarabdhGarg and unassigned rt4914 Feb 12, 2020
@PrarabdhGarg
Copy link
Contributor

@rt4914 From where can I get the icon?

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 12, 2020

@rt4914 From where can I get the icon?

I have emailed you an SVG file just now.

@PrarabdhGarg
Copy link
Contributor

Also, I feel that the flow would be much better if we showed the dialog after closing the side navigation drawer instead of the current flow

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 12, 2020

Also, I feel that the flow would be much better if we showed the dialog after closing the side navigation drawer instead of the current flow

Thanks a lot for the suggestion. For now, you can finish this task as mentioned in the mocks and I will discuss that with the designer about this.

@PrarabdhGarg PrarabdhGarg mentioned this issue Feb 12, 2020
Merged
@rt4914 rt4914 removed their assignment Feb 13, 2020
rt4914 pushed a commit that referenced this issue Feb 13, 2020
@PrarabdhGarg @Luffy18346 @veena14cs
Fix #590: Full UI Switch Profile Option (#651)
018f06f 
* Fix #572: Keyboard visible by default in Admin Pin (#573)

* By default keyboard visibility issue in Admin Pin is resolved

* Created a test case to check about Keyboard visibility by default in Admin Pin.

* Test is modified with the suggested changes

* Fix #577:  Display profile name on navigation drawer. (#578)

* display profile name in navigation drawer

* Updated code implementation

* adding tests

* added testcases

* Update NavigationDrawerFragmentPresenter.kt

* updated nit changes.

* Fix part #44: Full UI profile pin/password screen. (#597)

* done ui corrections

* fixed issues.

* Update pin_password_activity.xml

* updated color

* updated icon

* updated pinview shadow

* updated icon color

* changed shadow

* updated mock color

* fix

* Update pin_password_activity.xml

* updated nit change.

* Update pin_password_activity.xml

* removed fixed width

* fixed dimen file changes

* Update dimens.xml

* Fix part #632: Replace current recyclerview implementation with BindableAdapter usage. (#641)

* working on topic practice.

* reverted

* updated implementation

* Update ContinuePlayingFragmentPresenter.kt

* Update ContinuePlayingFragmentPresenter.kt

* Update ContinuePlayingItemViewModel.kt

* Delete OngoingListAdapter.kt

* nit change

* Update ContinuePlayViewModel.kt

* fixed nit

* Add UI and finctionality for Switch Profile

* Add UI Tests for switch profile option in navigation drawer

* Add UI Tests for switch profile option in navigation drawer

* Minor styling changes

Co-authored-by: Akash Koradia <[email protected]>
Co-authored-by: Veena <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PrarabdhGarg PrarabdhGarg

Labels
good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #590: Full UI Switch Profile Option PrarabdhGarg/oppia-android
3 participants
@rt4914 @BenHenning @PrarabdhGarg