Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #577: Display profile name on navigation drawer. #578

Merged
merged 7 commits into from
Feb 3, 2020
Merged

Fix #577: Display profile name on navigation drawer. #578

merged 7 commits into from
Feb 3, 2020

Conversation

veena14cs
Copy link
Contributor

Explanation

This PR displays profile name on navigation drawer as per selected profile.

Mock

https://xd.adobe.com/view/bee1fced-33bd-4f69-6a89-2c30fe1c4f65-c8d0/screen/42d3b9aa-8cb7-4ff0-b375-42117c3aed7e/PM-EN-Play-Tab-Side-Menu-

Screenshot

Screenshot_20191231-103041

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@veena14cs veena14cs changed the title Fix #577: Profile name to be displayed on navigation drawer. Fix #577: Display profile name on navigation drawer. Dec 31, 2019
rt4914
rt4914 reviewed Dec 31, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the approach should be different in this implementation, we should try to use viewmodel for data binding. I am currently trying one solution, for a cleaner implementation .

@veena14cs
Copy link
Contributor Author

the approach should be different in this implementation, we should try to use viewmodel for data binding. I am currently trying one solution, for a cleaner implementation .

Okay.

@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Dec 31, 2019
@rt4914
Copy link
Contributor

rt4914 commented Dec 31, 2019

@veena14cs Please check my last commit. I have updated the implementation approach.

Also, please add test cases too.

nikitamarysolomanpvt
nikitamarysolomanpvt reviewed Jan 2, 2020
View reviewed changes
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM please add test-cases and assign me back.

@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Jan 2, 2020
nikitamarysolomanpvt
nikitamarysolomanpvt approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit suggestions, Beside that PR LGTM

app/src/main/java/org/oppia/app/drawer/NavigationDrawerFragmentPresenter.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/drawer/NavigationDrawerFragmentPresenter.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/drawer/NavigationDrawerFragmentPresenter.kt Outdated Show resolved Hide resolved
@veena14cs veena14cs assigned veena14cs and unassigned veena14cs Jan 31, 2020
rt4914
rt4914 approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have mentioned some nit changes and 1 more test case.

app/src/main/java/org/oppia/app/drawer/NavigationDrawerFragmentPresenter.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/drawer/NavigationDrawerFragmentPresenter.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/drawer/NavigationDrawerHeaderViewModel.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/testing/NavigationDrawerTestActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/testing/NavigationDrawerTestActivity.kt Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/app/testing/NavigationDrawerTestActivityTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/app/testing/NavigationDrawerTestActivityTest.kt Outdated Show resolved Hide resolved
@rt4914 rt4914 removed their assignment Feb 3, 2020
@veena14cs veena14cs merged commit 34c7feb into develop Feb 3, 2020
@veena14cs veena14cs deleted the hifi-profile-name-on-drawer branch February 3, 2020 06:25
PrarabdhGarg pushed a commit to PrarabdhGarg/oppia-android that referenced this pull request Feb 12, 2020
@veena14cs @PrarabdhGarg
Fix oppia#577: Display profile name on navigation drawer. (oppia#578)
9bbd10b 
* display profile name in navigation drawer

* Updated code implementation

* adding tests

* added testcases

* Update NavigationDrawerFragmentPresenter.kt

* updated nit changes.
rt4914 pushed a commit that referenced this pull request Feb 13, 2020
@PrarabdhGarg @Luffy18346 @veena14cs
Fix #590: Full UI Switch Profile Option (#651)
018f06f 
* Fix #572: Keyboard visible by default in Admin Pin (#573)

* By default keyboard visibility issue in Admin Pin is resolved

* Created a test case to check about Keyboard visibility by default in Admin Pin.

* Test is modified with the suggested changes

* Fix #577:  Display profile name on navigation drawer. (#578)

* display profile name in navigation drawer

* Updated code implementation

* adding tests

* added testcases

* Update NavigationDrawerFragmentPresenter.kt

* updated nit changes.

* Fix part #44: Full UI profile pin/password screen. (#597)

* done ui corrections

* fixed issues.

* Update pin_password_activity.xml

* updated color

* updated icon

* updated pinview shadow

* updated icon color

* changed shadow

* updated mock color

* fix

* Update pin_password_activity.xml

* updated nit change.

* Update pin_password_activity.xml

* removed fixed width

* fixed dimen file changes

* Update dimens.xml

* Fix part #632: Replace current recyclerview implementation with BindableAdapter usage. (#641)

* working on topic practice.

* reverted

* updated implementation

* Update ContinuePlayingFragmentPresenter.kt

* Update ContinuePlayingFragmentPresenter.kt

* Update ContinuePlayingItemViewModel.kt

* Delete OngoingListAdapter.kt

* nit change

* Update ContinuePlayViewModel.kt

* fixed nit

* Add UI and finctionality for Switch Profile

* Add UI Tests for switch profile option in navigation drawer

* Add UI Tests for switch profile option in navigation drawer

* Minor styling changes

Co-authored-by: Akash Koradia <[email protected]>
Co-authored-by: Veena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitamarysolomanpvt nikitamarysolomanpvt nikitamarysolomanpvt approved these changes

@rt4914 rt4914 rt4914 approved these changes

Assignees

@veena14cs veena14cs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veena14cs @rt4914 @nikitamarysolomanpvt