Fix oppia#572: Keyboard visible by default in Admin Pin (oppia#573)

* By default keyboard visibility issue in Admin Pin is resolved * Created a test case to check about Keyboard visibility by default in Admin Pin. * Test is modified with the suggested changes
PrarabdhGarg · Feb 12, 2020 · 52e1eb4 · 52e1eb4
1 parent 043184f
commit 52e1eb4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -47,6 +47,7 @@
     <activity
       android:name=".profile.PinPasswordActivity"
       android:screenOrientation="portrait"
+      android:windowSoftInputMode="adjustResize"
       android:theme="@style/OppiaThemeWithoutActionBar" />
     <activity
       android:name=".profile.ProfileActivity"

diff --git a/app/src/main/java/org/oppia/app/profile/PinPasswordActivityPresenter.kt b/app/src/main/java/org/oppia/app/profile/PinPasswordActivityPresenter.kt
@@ -51,6 +51,7 @@ class PinPasswordActivityPresenter @Inject constructor(
       pinViewModel.showPassword.set(!pinViewModel.showPassword.get()!!)
     }
 
+    binding.inputPin.requestFocus()
     binding.inputPin.addTextChangedListener(object: TextWatcher {
       var wrong = false
       override fun onTextChanged(pin: CharSequence?, start: Int, before: Int, count: Int) {

diff --git a/app/src/sharedTest/java/org/oppia/app/profile/PinPasswordActivityTest.kt b/app/src/sharedTest/java/org/oppia/app/profile/PinPasswordActivityTest.kt
@@ -14,6 +14,7 @@ import androidx.test.espresso.assertion.ViewAssertions.matches
 import androidx.test.espresso.intent.Intents
 import androidx.test.espresso.intent.Intents.intended
 import androidx.test.espresso.intent.matcher.IntentMatchers.hasComponent
+import androidx.test.espresso.matcher.ViewMatchers.hasFocus
 import androidx.test.espresso.matcher.ViewMatchers.isDescendantOfA
 import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
 import androidx.test.espresso.matcher.ViewMatchers.withId
@@ -77,6 +78,13 @@ class PinPasswordActivityTest {
       .inject(this)
   }
 
+  @Test
+  fun testPinPasswordActivityWithAdmin_checkKeyboardIsVisibleByDefault() {
+    ActivityScenario.launch<PinPasswordActivity>(PinPasswordActivity.createPinPasswordActivityIntent(context, adminPin, adminId)).use {
+      onView(withId(R.id.input_pin)).check(matches(hasFocus()))
+    }
+  }
+
   @Test
   fun testPinPasswordActivityWithAdmin_inputCorrectPin_checkOpensHomeActivity() {
     ActivityScenario.launch<PinPasswordActivity>(PinPasswordActivity.createPinPasswordActivityIntent(context, adminPin, adminId)).use {