-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[A11y] Add labels for different screens for Talkback reader #2743
Comments
@rt4914 the links provided in the description point to this same issue |
@Arjupta This issue is not finished yet. I will add more information to this soon. |
@mschanteltc You can directly edit the description to edit and approve things. |
I updated the original post and have questions/comments for the following:
|
If we do not introduce any label it will output
Same for this too. If we do not add label it will output
Do you mean that we should label it as
So the output should be |
I see, let's stick with "Onboarding Flow" then. I approved this in the original post.
Yes those would work better. Would there be any issues since the heading does not match with the Talkback description?
I'm opened to doing a combination of both. So for example, "Topic page: Decimals". This gives a description on what kind of page it is and specifics on what the page is about.
Let's do |
Thanks.
No. Its completely fine to have label and title different.
Okay. Then in this case I will clarify one thing with Ben.
Sounds good. Thanks. |
@mschanteltc Can you update the description for 4 pending items |
Updated. |
@mschanteltc one concern I have around making the topic/story/etc. activities dynamic is we're now introducing redundancy for screenreader users. They will be hearing the topic title twice: once for the activity label, and second when they swipe through the toolbar. What benefit do we gain from having this redundancy? In general, I think we should aim to reduce the amount of information we need to convey so that it's easier to use the UI. WDYT? Edit: well it seems that this is actually standard (e.g. to have the toolbar title & activity label in-sync). However, I'm still leaning toward having static labels for all activities even if the toolbar is dynamic, especially since dynamic titles are probably longer to read out which means the redundancy is more noticeable in those cases. |
Thanks for your input Ben! I think as long as the Topic/Story/Revision names are mentioned at some point, we can use the static labels so we can eliminate the redundancies like you mentioned. Should I go ahead and edit the post to reflect this? |
@mschanteltc Yes, you can edit the description and add correct labels to reflect correct labels. |
Updated. One last thing that is PENDING is the Revision Card which was originally |
@mschanteltc Makes sense. I am updating the description. |
When
Talkback
is on, whenever we click on any option which leads to new screen the reader will automatically read thelabel
associated with that screen first. If in case label in not present then it will read app name i.e.Oppia
.We need correct labels for following screens:
Onboarding Flow
Profile selection page
Authorize to add profiles
Authorize to add profiles
Authorize to access Administrator Controls
PIN verification
Add Profile
Topic Page
Chapter List
Skill Page
Practice Mode
Concept Card
Exploration Player
Hints and Solution
Profile
Topics in Progress
Stories Completed
Options
Reading Text Size
Default Audio Language / App language
FAQs (Frequently Asked Questions)
FAQs (Frequently Asked Questions)
Help
App Version
Profile List
<Profile_name>
Rename Profile
Reset PIN
Whatever is shown in toolbar/actionbar
Approved (This will need slightly bigger changes to code.)In general if there is a static/fixed
Title
for the screen, we use that as label. And if there is dynamic title then we need astatic
label which will not be shown on screen but will be read by the talkback.Example
device-2021-02-24-021647.mp4
In this above video as soon as we double-tap
Battery
, new screen is opened.The reader first outputs
Battery
followed byNavigate up, Button
and finallyBattery
again. In this the firstBattery
output is thelabel
of this new screen which indicates the learner which screen is opened. The secondBattery
is because we selected the title in the screen and it's just reading that text.So we need
labels
for various screens general which matches the title but if the title is dynamic then we need static label.Note: The above list can change as and when we find more such issues.
The text was updated successfully, but these errors were encountered: