[A11y] Add label for RecentlyPlayedActivity [Blocked on #3095] #2824
Assignees
Labels
Impact: Low
Low perceived user impact (e.g. edge cases).
Priority: Essential
This work item must be completed for its milestone.
Type: Task
A single task of work corresponding to a greater milestone. Generally corresponds to a single PR.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Comments
rt4914
added
Priority: Essential
29 tasks
|
@rt4914 I would like to work on it, could you please assign it to me? |
|
@IAmJaishree I have assigned you two similar issues. Also I will be working on this as it involves some discussion with teammates. Thanks. |
rt4914
changed the title
8 tasks
|
I would like to work on this could you please assign this to me @bkaur-bkj |
|
@rt4914 can this issue be assigned to @shankarpriyank ? |
rt4914
removed
the
good first issue
|
@bkaur-bkj Actually no. I just removed good-first-issue label from it. |
okay |
|
@rt4914 @BenHenning can I work on this issue, as I am quite interested? |
|
@rishidyno Suggest doing following things:
Actually this issue is not like any other |
rt4914
changed the title
seanlip
moved this to Needs Triage
in [Team] Core Learner and Mastery flows & UI Frontend - Android
6 tasks
BenHenning
added
Impact: Low
BenHenning
added a commit
that referenced
this issue
Oct 5, 2022
…tivity (#4511) * RecentlyPlayedActivityParams proto created with ActivityRouter * Nit changes * Optimize imports * Shifted applicationComponent to developerApplicationComponent * Optimized import * ActivityRouterModule updated * Updated RECENTLY_PLAYED_ACTIVITY_INTENT_EXTRAS_KEY in ProfileProgressFragmentTest * Static checks fixed * setTitle added in ReceltyPlayedActivityPresenter * bazel added and set title to toolbar * removed unused import * nit changes * test updated and made changes in bazel * dependencies added BUILD.bazel * static and lint checks fixed * protobuf lint issue fixed * Revert "protobuf lint issue fixed" This reverts commit 8b0c707. * protofub lint test fixed * UNSPECIFIED enum renamed * order changed in bazel * src of bazel fixed * dagger deps added in bazel * KDoc updated for bazel * nit changes * Revert "nit changes" This reverts commit 00c426a. * Updated kdoc and optimized code * klint issue fixed * reformated route/BUILD.bazel * regex pattern checks fixed * optimized import * Nit changes * Test updated and RecentlyPlayedActivityTitle used * Optimized import * Added newline EOF * ActivityRouter added to bazel * reformat bazel * corrected path * made nit changes * Nit changes * added new line * New approach implemented for dagger * code optimized * Fix broken builds for #4511. * Fixed intentname failing tests * Imports optimized * Added tests for ActivityRouter and ActivityRouterModule * optimized code * Added KDoc and ActivityRouter in bazel * fixed typo * removed practicetab * ActivityRouterModule added in BottomSheetOptionsMenu * Optimized imports * Updated failing tests * Added activityRouterModule in Intrumentation * removed activity_router_module from bazel in Instrumentation * removed activityRouterModule from LogReportingModuleTest * removed activity_component_factory from bazel in route/BUILD.bazel * Nit changes * Optimized import * Tests for ActivityRouter and ActivityRouterModule updated * Optimized code for null safety in ProfileProgressHeaderViewModel * Optimized code * Updated KDoc * Updated kDoc * Nit changes * Added new tests and updated ActivityRouter to fix failing CI * Update app/src/sharedTest/java/org/oppia/android/app/profileprogress/ProfileProgressFragmentTest.kt Co-authored-by: Ben Henning <[email protected]> * Revert "Update app/src/sharedTest/java/org/oppia/android/app/profileprogress/ProfileProgressFragmentTest.kt" This reverts commit 3c141fb. * Updated testname * Updated logic in ActivityRouter Co-authored-by: Ben Henning <[email protected]> Co-authored-by: Ben Henning <[email protected]>
github-project-automation
bot
moved this to Todo
in [Team] Core Learner and Mastery flows & UI Frontend - Android
seanlip
moved this from Todo
to Done
in [Team] Core Learner and Mastery flows & UI Frontend - Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Task
Introduce label for
RecentlyPlayedActivityas eitherStories for youorRecently played stories.Reference PR: #2750
When you create a PR for this, make sure you add test to check the functionality. Also, suggest working on this PR only if its your first or second PR to Oppia-Android project.
General Explanation
When
Talkbackis on, whenever we click on any option which leads to new screen the reader will automatically read thelabelassociated with that screen first. If in case label in not present then it will read app name i.e.Oppia.Example
device-2021-02-24-021647.mp4
In this above video as soon as we double-tap
Battery, new screen is opened.The reader first outputs
Batteryfollowed byNavigate up, Buttonand finallyBatteryagain. In this the firstBatteryoutput is thelabelof this new screen which indicates the learner which screen is opened. The secondBatteryis because we selected the title in the screen and it's just reading that text.So we need
labelsfor various screens general which matches the title but if the title is dynamic then we need static label.The text was updated successfully, but these errors were encountered: