Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use protos with intent extras in RecenlyPlayedActivity #3095

Closed
rt4914 opened this issue Apr 15, 2021 · 0 comments · Fixed by #4511
Closed

Use protos with intent extras in RecenlyPlayedActivity #3095

rt4914 opened this issue Apr 15, 2021 · 0 comments · Fixed by #4511
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Apr 15, 2021

As per this comment and approach we should strive towards using protos in transferring information between activties.
@rt4914 rt4914 added this to the Beta milestone Apr 15, 2021
@rt4914 rt4914 added Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. labels Apr 15, 2021
@rt4914 rt4914 self-assigned this Apr 15, 2021
@rt4914 rt4914 mentioned this issue Apr 15, 2021
Closed
8 tasks
@rt4914 rt4914 mentioned this issue Aug 24, 2021
Closed
8 tasks
@rt4914 rt4914 removed their assignment Jan 18, 2022
@rishidyno rishidyno self-assigned this Feb 11, 2022
@rishidyno rishidyno mentioned this issue Feb 22, 2022
Closed
6 tasks
@rishidyno rishidyno removed their assignment Jun 28, 2022
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 14, 2022
@vrajdesai78 vrajdesai78 mentioned this issue Aug 19, 2022
Merged
6 tasks
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta milestone Sep 16, 2022
BenHenning added a commit that referenced this issue Oct 5, 2022
@vrajdesai78 @BenHenning
Fixes #3095, #2824: Use protos with intent extras in RecentlyPlayedAc…
162a50e 
…tivity (#4511)

* RecentlyPlayedActivityParams proto created with ActivityRouter

* Nit changes

* Optimize imports

* Shifted applicationComponent to developerApplicationComponent

* Optimized import

* ActivityRouterModule updated

* Updated RECENTLY_PLAYED_ACTIVITY_INTENT_EXTRAS_KEY in ProfileProgressFragmentTest

* Static checks fixed

* setTitle added in ReceltyPlayedActivityPresenter

* bazel added and set title to toolbar

* removed unused import

* nit changes

* test updated and made changes in bazel

* dependencies added BUILD.bazel

* static and lint checks fixed

* protobuf lint issue fixed

* Revert "protobuf lint issue fixed"

This reverts commit 8b0c707.

* protofub lint test fixed

* UNSPECIFIED enum renamed

* order changed in bazel

* src of bazel fixed

* dagger deps added in bazel

* KDoc updated for bazel

* nit changes

* Revert "nit changes"

This reverts commit 00c426a.

* Updated kdoc and optimized code

* klint issue fixed

* reformated route/BUILD.bazel

* regex pattern checks fixed

* optimized import

* Nit changes

* Test updated and RecentlyPlayedActivityTitle used

* Optimized import

* Added newline EOF

* ActivityRouter added to bazel

* reformat bazel

* corrected path

* made nit changes

* Nit changes

* added new line

* New approach implemented for dagger

* code optimized

* Fix broken builds for #4511.

* Fixed intentname failing tests

* Imports optimized

* Added tests for ActivityRouter and ActivityRouterModule

* optimized code

* Added KDoc and ActivityRouter in bazel

* fixed typo

* removed practicetab

* ActivityRouterModule added in BottomSheetOptionsMenu

* Optimized imports

* Updated failing tests

* Added activityRouterModule in Intrumentation

* removed activity_router_module from bazel in Instrumentation

* removed activityRouterModule from LogReportingModuleTest

* removed activity_component_factory from bazel in route/BUILD.bazel

* Nit changes

* Optimized import

* Tests for ActivityRouter and ActivityRouterModule updated

* Optimized code for null safety in ProfileProgressHeaderViewModel

* Optimized code

* Updated KDoc

* Updated kDoc

* Nit changes

* Added new tests and updated ActivityRouter to fix failing CI

* Update app/src/sharedTest/java/org/oppia/android/app/profileprogress/ProfileProgressFragmentTest.kt

Co-authored-by: Ben Henning <[email protected]>

* Revert "Update app/src/sharedTest/java/org/oppia/android/app/profileprogress/ProfileProgressFragmentTest.kt"

This reverts commit 3c141fb.

* Updated testname

* Updated logic in ActivityRouter

Co-authored-by: Ben Henning <[email protected]>
Co-authored-by: Ben Henning <[email protected]>
Repository owner moved this from Needs Triage to Done in [Team] Developer Workflow & Infrastructure - Android Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
5 participants
@rt4914 @BenHenning @vrajdesai78 @rishidyno @Broppia