Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3095: Use protos with intent extras in RecentlyPlayedActivity #3721

Closed
wants to merge 6 commits into from

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Aug 24, 2021

Explanation

Fix #3095: Use proto with intent extras in RecentlyPlayedActivity

Earlier this implementation was done in #3065 but was closed because of stale PR.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 self-assigned this Aug 30, 2021
@oppiabot
Copy link

oppiabot bot commented Sep 6, 2021

Hi @rt4914, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 3 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 6, 2021
@oppiabot oppiabot bot closed this Sep 13, 2021
@rt4914 rt4914 reopened this Sep 14, 2021
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 14, 2021
@oppiabot
Copy link

oppiabot bot commented Sep 21, 2021

Hi @rt4914, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 3 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 21, 2021
@oppiabot oppiabot bot closed this Sep 28, 2021
@rt4914 rt4914 reopened this Sep 28, 2021
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 28, 2021
@rt4914 rt4914 closed this Sep 28, 2021
@rt4914 rt4914 deleted the intent-protos-recently-played branch September 28, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use protos with intent extras in RecenlyPlayedActivity
1 participant