-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[A11y] Add label for ProfileListActivity #2823
Comments
@rt4914 Hey can you assign this issue to me |
@rt4914 I would like to work on this issue, as suggested to me by Abhay Garg |
@arjunrkaushik As @AnubhavPabby claimed it first, we should assign this issue to him, but I am assigning you #2819 which is almost similar to this. Can you please add a comment there so can I assign that issue to you? |
Can I work on this issue? @prayutsu I might need some help in testing as I am fairly new to contributing. |
@Karanjot-singh This issue is already assigned to @AnubhavPabby |
@rt4914 is this issue resolved? Can I work on this? |
@pravesh00 Thanks for your interest. Please checkout our wiki first. This will help you in setting up the project and once you sign the CLA and fill the survey form we can assign you issues to work on. |
Task
Introduce label for
ProfileListActivity
asProfile List
.Reference PR: #2750
When you create a PR for this, make sure you add test to check the functionality. Also, suggest working on this PR only if its your first or second PR to Oppia-Android project.
General Explanation
When
Talkback
is on, whenever we click on any option which leads to new screen the reader will automatically read thelabel
associated with that screen first. If in case label in not present then it will read app name i.e.Oppia
.Example
device-2021-02-24-021647.mp4
In this above video as soon as we double-tap
Battery
, new screen is opened.The reader first outputs
Battery
followed byNavigate up, Button
and finallyBattery
again. In this the firstBattery
output is thelabel
of this new screen which indicates the learner which screen is opened. The secondBattery
is because we selected the title in the screen and it's just reading that text.So we need
labels
for various screens general which matches the title but if the title is dynamic then we need static label.The text was updated successfully, but these errors were encountered: