FIX #2823: Profile list activity label #3225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @Victor-Titan @rt4914 |
|
@rt4914 can you please help me with how to remove these unit test failures? |
rt4914
suggested changes
May 23, 2021
There was a problem hiding this comment.
@pravesh00 Suggestion changes.
Also if you check sample PR number mentioned in the issue that PR contains a test too. You have to create a similar test file and add test. You can create a new test file ProfileListActivityTest
| <output url="file://$PROJECT_DIR$/build/classes" /> | ||
| </component> | ||
| <component name="ProjectType"> | ||
| <option name="id" value="Android" /> | ||
| </component> | ||
| </project> | ||
| </project> |
There was a problem hiding this comment.
This changes from this entire file. It should not be visible under Files changed section on github.
app/src/main/res/values/strings.xml
Outdated
| @@ -435,4 +435,5 @@ | |||
| <string name="audio_player_on">Audio, ON</string> | |||
| <string name="audio_player_off">Audio, OFF</string> | |||
| <string name="hints_android_solution_correct_answer">%s/%s</string> | |||
| <string name="profile_list_activity_label">Profile List</string> | |||
There was a problem hiding this comment.
Rename to profile_list_activity_title
app/src/main/AndroidManifest.xml
Outdated
| @@ -121,7 +121,8 @@ | |||
| <activity android:name=".app.settings.profile.ProfileEditActivity" /> | |||
| <activity | |||
| android:name=".app.settings.profile.ProfileListActivity" | |||
| android:theme="@style/OppiaThemeWithoutActionBar" /> | |||
| android:theme="@style/OppiaThemeWithoutActionBar" | |||
| android:label="@string/profile_list_activity_label"/> | |||
anandwana001
added
the
PR don't merge - NEEDS UPDATE
|
I was facing some gradle change issues so I have closed this PR and created a new one #3244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #2823: Profile list activity label added
Checklist