Fixes part of #2743: Label for Recently Played Activity A11y #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pull request template is not getting used by default now. cc: @BenHenning |
BenHenning
reviewed
Feb 26, 2021
| @@ -429,4 +429,5 @@ | |||
| <string name="coming_soon">Coming Soon</string> | |||
| <string name="recommended_stories">Recommended Stories</string> | |||
| <string name="stories_for_you">Stories For You</string> | |||
| <string name="recently_played_activity_label">Recently played stories</string> | |||
There was a problem hiding this comment.
Will we be using title instead of label per the discussion from the team meeting this week?
| @@ -41,6 +41,7 @@ | |||
| android:theme="@style/OppiaThemeWithoutActionBar" /> | |||
| <activity | |||
| android:name=".app.home.recentlyplayed.RecentlyPlayedActivity" | |||
| android:label="@string/recently_played_activity_label" | |||
There was a problem hiding this comment.
Should we also be using this for the toolbar to ensure the two are kept in sync?
|
@BenHenning I will update the PR meanwhile please have a look at the PR description and reply on the document. |
|
Responded to the comment. Assigning back to you until this is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #2743
I checked the app and found that the title inside the
Recently Played Activityis fixed and therefore just creating this PR.Should we make this header dynamic similar to the text that we have in
Home Screento the side ofView All. The possible options for the header are:Stories for youandRecently played stories.Reference: https://docs.google.com/document/d/1o7hOz1rP-hJaKn1f5x6LV6ms0bzhyCpsTifJQY5crCc/edit?disco=AAAALj4Y6X8