Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11y] Add label for PinPasswordActivity #2805

Closed
rt4914 opened this issue Mar 2, 2021 · 3 comments · Fixed by #3028
Closed

[A11y] Add label for PinPasswordActivity #2805

rt4914 opened this issue Mar 2, 2021 · 3 comments · Fixed by #3028
Assignees
@Arnold2381
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Mar 2, 2021

Task

Introduce label for PinPasswordActivity as PIN verification.

Reference PR: #2750

When you create a PR for this, make sure you add test to check the functionality. Also, suggest working on this PR only if its your first or second PR to Oppia-Android project.

General Explanation

When Talkback is on, whenever we click on any option which leads to new screen the reader will automatically read the label associated with that screen first. If in case label in not present then it will read app name i.e. Oppia.

Example

device-2021-02-24-021647.mp4

In this above video as soon as we double-tap Battery, new screen is opened.
The reader first outputs Battery followed by Navigate up, Button and finally Battery again. In this the first Battery output is the label of this new screen which indicates the learner which screen is opened. The second Battery is because we selected the title in the screen and it's just reading that text.
So we need labels for various screens general which matches the title but if the title is dynamic then we need static label.
@rt4914 rt4914 added Priority: Essential This work item must be completed for its milestone. good first issue This item is good for new contributors to make their pull request. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. labels Mar 2, 2021
@rt4914 rt4914 added this to the Beta milestone Mar 2, 2021
@rt4914 rt4914 mentioned this issue Mar 2, 2021
Closed
29 tasks
@IAmJaishree
Copy link

@rt4914 I want to work on this issue, can it be assigned to me?

@Arnold2381
Copy link
Contributor

@rt4914 can I work on this issue?

@rt4914 rt4914 assigned Arnold2381 and unassigned IAmJaishree Mar 30, 2021
@rt4914
Copy link
Contributor Author

rt4914 commented Mar 30, 2021

Unassigned @IAmJaishree because of no activity.

@Arnold2381 Arnold2381 mentioned this issue Mar 30, 2021
Merged
8 tasks
BenHenning pushed a commit that referenced this issue Apr 9, 2021
@Arnold2381
Fix #2805 : Added label for PinPasswordActivity (#3028)
285ecce 
* Added label for PinPasswordActivity

* Label Added for PinPasswordActivityTest as string value.

* Test added for label check

* string variable name changed to pin_password_activity_title for label

* Formatting errors fixed using ktlint.
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arnold2381 Arnold2381

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2805 : Added label for PinPasswordActivity Arnold2381/oppia-android
5 participants
@rt4914 @seanlip @BenHenning @Arnold2381 @IAmJaishree