Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] Add label for QuestionPlayerActivity #2806

Closed
rt4914 opened this issue Mar 2, 2021 · 1 comment · Fixed by #3013
Closed

[A11y] Add label for QuestionPlayerActivity #2806

rt4914 opened this issue Mar 2, 2021 · 1 comment · Fixed by #3013
Assignees
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Mar 2, 2021

Task

Introduce label for QuestionPlayerActivity as Practice Mode.

Reference PR: #2750

When you create a PR for this, make sure you add test to check the functionality. Also, suggest working on this PR only if its your first or second PR to Oppia-Android project.

General Explanation

When Talkback is on, whenever we click on any option which leads to new screen the reader will automatically read the label associated with that screen first. If in case label in not present then it will read app name i.e. Oppia.

Example

device-2021-02-24-021647.mp4

In this above video as soon as we double-tap Battery, new screen is opened.
The reader first outputs Battery followed by Navigate up, Button and finally Battery again. In this the first Battery output is the label of this new screen which indicates the learner which screen is opened. The second Battery is because we selected the title in the screen and it's just reading that text.
So we need labels for various screens general which matches the title but if the title is dynamic then we need static label.

@rt4914 rt4914 added Priority: Essential This work item must be completed for its milestone. good first issue This item is good for new contributors to make their pull request. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. labels Mar 2, 2021
@rt4914 rt4914 added this to the Beta milestone Mar 2, 2021
@Pranav-Bobde
Copy link
Contributor

Can i be assigned this issue? This will be my first time taking an issue. So, please help/guide me to make it through.

BenHenning pushed a commit that referenced this issue Apr 7, 2021
* Added Label For QuestionPlayerActivity

* made suggested changes

* EOF added and test passed

* trying a fix for test

* trying fix for test2

* trying a fix for test3

* string changed to Practice Mode

* updated branch
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

Successfully merging a pull request may close this issue.

4 participants