Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all the ignored test cases #2417

Open
anandwana001 opened this issue Jan 6, 2021 · 8 comments
Open

Fix all the ignored test cases #2417

anandwana001 opened this issue Jan 6, 2021 · 8 comments
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@anandwana001
Copy link
Contributor

anandwana001 commented Jan 6, 2021 •
edited
Loading

Describe the bug
Some of the test cases are ignored due to flakyness or blocked somewhere in other pr.

Expected behavior
Need to fix all.

Test file Test issue/pr
AudioFragmentTest #56(Landscape)
ExplorationActivityTest 2 - fake audio library (#2480)
StateFragmentTest 3 - #1612, 1 - #1611
ImageRegionSelectionInteractionViewTest 3 - #1611 , 3 - test doesn't seems correct
InputInteractionViewTestActivityTest 4 - #56(Landscape)
NavigationDrawerActivityTest 1 - #1806(MyDownloads)[BLOCKED]
CoroutineExecutorServiceTest 2 - #1763
Test file @RunOn(TestPlatform.ESPRESSO)
NavigationDrawerActivityTest 2 - Error 'is drawer closed' doesn't match the selected view. for robolectric
TopicInfoFragmentTest 7 - #2057 Text lines/Orientation change for robolectric
QuestionPlayerActivityTest. 4 - #2057
AudioFragmentTest 1 - #2568
Test file Need Tests to write
QuestionPlayerActivityTest #503
ExplorationActivityTest TODO(#163): Fill in remaining tests for this activity. (is this completed)
StateFragmentTest TODO(#388): Add more test-cases (@khushal1707 ) ,TODO(#56): Add support for testing that previous/next button states are properly retained on config changes.
@anandwana001 anandwana001 mentioned this issue Jan 6, 2021
Merged
8 tasks
@anandwana001
Copy link
Contributor Author

@ShridharGoel Do you want to work on ExplorationActivityTest explorationActivityTestRule.activity.isFinishing part

@ShridharGoel
Copy link
Contributor

@anandwana001 Yes, sure.

@anandwana001 anandwana001 mentioned this issue Jan 7, 2021
Merged
8 tasks
BenHenning pushed a commit that referenced this issue Jan 12, 2021
@anandwana001
Fix part of #2417: Fix Audio test correctness (#2425)
d7f4ce8 
* fix test correctness

* nit fix

* setting progress

* added only robolectric
@prayutsu prayutsu mentioned this issue Jan 15, 2021
Merged
8 tasks
@MaskedCarrot
Copy link
Contributor

@anandwana001 may I file a new issue regarding the failing robolectric test in #2499

@anandwana001
Copy link
Contributor Author

Sure and please also mention here in the comment with the new issue link.

@MaskedCarrot
Copy link
Contributor

Failing roboletric tests needs to be fixed in AudioFragmentTest #2568

@MaskedCarrot MaskedCarrot mentioned this issue Jan 28, 2021
Merged
8 tasks
@anandwana001 anandwana001 mentioned this issue Feb 3, 2021
Closed
10 tasks
@anandwana001 anandwana001 mentioned this issue Feb 12, 2021
Closed
8 tasks
@khushal1707
Copy link
Contributor

@anandwana001 Is TODO(#388): Add more test-cases available now ? Can I work on this?

@anandwana001
Copy link
Contributor Author

@khushal1707 done

@khushal1707
Copy link
Contributor

I'm having exams this week and I'll try to make pull request by the end of the week for TODO:(#388)

@khushal1707 khushal1707 mentioned this issue Mar 1, 2021
Closed
8 tasks
@anandwana001 anandwana001 self-assigned this Apr 29, 2021
@anandwana001 anandwana001 removed their assignment Jun 22, 2021
@Broppia Broppia added issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. and removed mini-project labels Sep 14, 2022
@BenHenning BenHenning added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). issue_type_infrastructure Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). labels Sep 15, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_type_infrastructure labels Mar 28, 2023
@MohitGupta121 MohitGupta121 added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
8 participants
@seanlip @BenHenning @anandwana001 @ShridharGoel @khushal1707 @MaskedCarrot @MohitGupta121 @Broppia