-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test to check pause button visibility #2480
Comments
@anandwana001 may I work on this? Also can you please give me a few pointers on how to get started? |
@MaskedCarrot We need to create a fake audio library so that we can test cases when the espresso test is idle like pause icon is only visible when espresso test is idle, but we need something using which we can fake our media player that audio is playing and the pause icon gets visible. |
@anandwana001 I tried reading about this online but I could not find any resource of much help. Can you please guide me on this? |
Basically, there is no third party lib todo this, but we need to create the whole thing here. |
@anandwana001 I am facing a few difficulties on this may we connect on giiter regarding this issue? |
Sure |
I took a look at this issue for the first test case
Interestingly, if we call |
On more deeper investigation, I found that there are two issues with this test:
|
@anandwana001 Can I work on this issue? |
@pravesh00 Before assigning, have you check the above comments? |
<!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> Fixes part of #2480 - Fixes `testAudioWifi_ratioExp_audioIcon_audioFragHasDefaultLangAndAutoPlays()` by checking default language at the end and testing audio icons in a better way. - Fixes `testAudioWifi_ratioExp_continueInteraction_audioButton_submitAns_feedbackAudioPlays()` by scrolling to the _**continue_interaction_button**_ before performing click on it , as it was positioned at the lower end of the recycler view. ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only <!-- Delete these section if this PR does not include UI-related changes. --> If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide)) - For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing --------- Co-authored-by: Adhiambo Peres <[email protected]>
Describe the bug
Espresso doesn't test anything when the app is in the idle state. Testing Audio becomes difficult in such cases.
Expected behavior
Propose a solution to test the pause icon visiblity while playing audio
Cases we need to test:
Additional context
Tests that needs to be fixed from
ExplorationActivityTest
andAudioFragmentTest
[These two in ExplorationActivityTest were fixed in #5245]
[Tests Pending fixes]
#2216 (comment)
The text was updated successfully, but these errors were encountered: