-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2213: TopicListControllerTest has failing tests on CI and Fix and Format few other tests #2216
Fix #2213: TopicListControllerTest has failing tests on CI and Fix and Format few other tests #2216
Conversation
app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anandwana001! Given that the audio stuff isn't relevant here anymore, the other changes largely LGTM. Just a few nits.
...edTest/java/org/oppia/android/app/administratorcontrols/AdministratorControlsActivityTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/android/app/profileprogress/ProfileProgressFragmentTest.kt
Outdated
Show resolved
Hide resolved
domain/src/test/java/org/oppia/android/domain/topic/TopicListControllerTest.kt
Outdated
Show resolved
Hide resolved
domain/src/test/java/org/oppia/android/domain/topic/TopicListControllerTest.kt
Outdated
Show resolved
Hide resolved
Hi--sorry will need to look at this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anandwana001! Generally LGTM--just have one comment.
domain/src/test/java/org/oppia/android/domain/topic/TopicListControllerTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anandwana001!
Explanation
Fix #2213
AdministratorControlsActivityTest.kt
- remove unused testRule and nit fixHomeActivityTest.kt
- CI Ignored test fixProfileProgressFragmentTest.kt
- removewaitForTheView
and nit fixTopicListControllerTest.kt
- Fix "Failing on Circle CI." and nit fixNeed to file a separate issue for this point and removing from this PR.
5.
ExplorationActivityTest.kt
- removewaitForTheView
, nit fix1 test is only passing on Robolectric as for Espresso we need to check the pause button is visible, but the pause button is visible only in the idle state.
1 test is ignored, with the same reason above and also not passing on robolectric.
Checklist