Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2213: TopicListControllerTest has failing tests on CI and Fix and Format few other tests #2216

Merged
merged 11 commits into from
Jan 11, 2021

Conversation

anandwana001
Copy link
Contributor

@anandwana001 anandwana001 commented Dec 3, 2020

Explanation

Fix #2213

  1. AdministratorControlsActivityTest.kt - remove unused testRule and nit fix
  2. HomeActivityTest.kt - CI Ignored test fix
  3. ProfileProgressFragmentTest.kt - remove waitForTheView and nit fix
  4. TopicListControllerTest.kt - Fix "Failing on Circle CI." and nit fix

Need to file a separate issue for this point and removing from this PR.
5. ExplorationActivityTest.kt - remove waitForTheView , nit fix
1 test is only passing on Robolectric as for Espresso we need to check the pause button is visible, but the pause button is visible only in the idle state.
1 test is ignored, with the same reason above and also not passing on robolectric.

Screenshot 2020-12-18 at 12 26 48
Screenshot 2020-12-18 at 12 25 28
Screenshot 2020-12-18 at 12 24 20
Screenshot 2020-12-18 at 12 20 43
Screenshot 2020-12-18 at 12 16 14
Screenshot 2020-12-18 at 12 14 13
Screenshot 2020-12-18 at 12 05 47

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@anandwana001 anandwana001 marked this pull request as draft December 7, 2020 11:44
@anandwana001 anandwana001 marked this pull request as ready for review December 13, 2020 03:35
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anandwana001! Given that the audio stuff isn't relevant here anymore, the other changes largely LGTM. Just a few nits.

@BenHenning
Copy link
Member

Hi--sorry will need to look at this tomorrow.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anandwana001! Generally LGTM--just have one comment.

@anandwana001 anandwana001 requested a review from rt4914 as a code owner January 4, 2021 22:50
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anandwana001!

@BenHenning BenHenning assigned anandwana001 and unassigned BenHenning Jan 8, 2021
@anandwana001 anandwana001 enabled auto-merge (squash) January 9, 2021 07:14
@anandwana001 anandwana001 merged commit 606a16a into oppia:develop Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TopicListControllerTest has failing tests on CI
3 participants