Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all broken tests on develop #295

Closed
3 of 10 tasks
BenHenning opened this issue Nov 4, 2019 · 5 comments
Closed
3 of 10 tasks

Fix all broken tests on develop #295

BenHenning opened this issue Nov 4, 2019 · 5 comments
Assignees
@vinitamurthi @BenHenning
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

BenHenning commented Nov 4, 2019 •
edited by vinitamurthi
Loading

Most of our tests are failing. We need to fix these.

Checklist

List of files which have failing test cases. You can start fixing these files and once you fix these files make sure you comment here mentioning what all files you have fixed.

app module

  • HtmlParserTest
  • AudioFragmentTest (This can be because of Roboelectric too. @jamesxu0 Please check this.)
  • CellularDataDialogFragmentTest
  • ExplorationActivityTest
  • TopicOverviewFragmentTest (Failing because the TopicActivityPresenter is loading TopicFragment as default)
  • TopicPlayFragmentTest (Failing because the TopicActivityPresenter is loading TopicFragment as default)
  • TopicReviewFragmentTest (Failing because the TopicActivityPresenter is loading TopicFragment as default)
  • TopicTrainFragmentTest (Failing because the TopicActivityPresenter is loading TopicFragment as default)

data module

  • NetworkInterceptorTest

** All modules**

  • Final check of all test cases
@BenHenning BenHenning added Type: Bug Priority: Essential This work item must be completed for its milestone. labels Nov 4, 2019
@BenHenning BenHenning self-assigned this Nov 4, 2019
@BenHenning BenHenning mentioned this issue Nov 4, 2019
Merged
@jamesxu0 jamesxu0 mentioned this issue Nov 5, 2019
Merged
6 tasks
@jamesxu0
Copy link
Contributor

jamesxu0 commented Nov 5, 2019

PR #284 and #290 fixed AudioFragmentTest. PR #296 fixes CellularDataDialogFragmentTest.

@rt4914
Copy link
Contributor

rt4914 commented Nov 5, 2019

@jamesxu0 I think there will be some more broken test cases a we move along, basically wherever we were using some dummy button needs to be removed and because of which these errors will occur. So you can expect that you are re-assigned to a broken-test which you have already solved.

@BenHenning
Copy link
Member Author

Thanks for breaking this down @rt4914 -- this is really helpful!

@BenHenning BenHenning mentioned this issue Nov 5, 2019
Merged
@jamesxu0
Copy link
Contributor

jamesxu0 commented Nov 6, 2019

PR #296 makes CellularDataDialogFragmentTest pass locally for Espresso, but not on CircleCI for unknown reasons. I tried running the test on Robolectric, which failed due to these exceptions:
Caused by: android.view.InflateException: Binary XML file line #17: Layout state should be one of 100 but it is 10
Caused by: java.lang.IllegalStateException: Layout state should be one of 100 but it is 10
It seems it has somethign to do with databinding in onCreateViewHolder in StateAdapter.

@vinitamurthi vinitamurthi mentioned this issue Nov 20, 2019
Merged
8 tasks
vinitamurthi added a commit that referenced this issue Nov 20, 2019
@vinitamurthi
Fix part of #295: Change the CircleCI workflow (#357)
98fc5b7 
* Change gradle tests for circleci

* Fix network interceptor test

* Ignore mock subtopic test

* Remove subtopic test

* Test if circleci fails

* Change gradle config for tests

* Remove source sets

* Change circleci config

* Add circleci_tests

* Fix lint test

* Fix data controller test

* Add a flaky test workflow

* Create a setup step

* Uncomment the mock subtopic test

* Remove the setup step because theres a long delay

* Uncomment mocksubtopictest

* Add space after catch
@vinitamurthi vinitamurthi mentioned this issue Nov 20, 2019
Merged
8 tasks
vinitamurthi added a commit that referenced this issue Nov 27, 2019
@vinitamurthi
Fix part of #295: Move passing tests of the app module to the non_fla…
d19815d 
…ky_tests workflow (#457)

* Test adding an emulator

* Fix topic list controller test

* try running app tests on robolectric

* Test splashactivity on robolectric

* comment out audio fragment test

* Run all app tests on robolectric

* test splash activity failure

* Move passing tests to non-flaky queue

* Add parser to non flaky tests

* Fix html parser test

* player and recycler view tests

* Change html parser test

* Change app tests in non_flaky_tests

* Remove passing tests from flaky_tests queue

* try uncommenting the audio fragment test

* Fix a build error in audio fragment test

* Fix HtmlParserTest and InputInteraction..Test compile issues
@BenHenning BenHenning added this to the Beta milestone Jun 23, 2020
@anandwana001
Copy link
Contributor

We are good to close this issue, as we have a master tracking issue for fixing test
#2417

@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinitamurthi vinitamurthi

@BenHenning BenHenning

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rt4914 @vinitamurthi @BenHenning @anandwana001 @jamesxu0