Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce shadows to properly lay out TextViews #2057

Open
BenHenning opened this issue Oct 30, 2020 · 2 comments
Open

Introduce shadows to properly lay out TextViews #2057

BenHenning opened this issue Oct 30, 2020 · 2 comments
Assignees
@BenHenning
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

See #1923 for context. We need to introduce a custom Paint shadow class that extends Robolectric's which actually computes the correct size for text in TextViews so that we can test wrapping & other scenarios.
@BenHenning BenHenning self-assigned this Oct 30, 2020
@BenHenning BenHenning mentioned this issue Oct 30, 2020
Merged
8 tasks
@BenHenning BenHenning mentioned this issue Nov 16, 2020
Open
@anandwana001
Copy link
Contributor

anandwana001 commented Nov 26, 2020 •
edited
Loading

In QuestionPlayerActivityTest all test cases are passing on robolectric without the need for @RunOn(TestPlatform.ESPRESSO).
@prayutsu Is there any update on this? How we solved the previous issue we are getting while we are trying to solve the tick problem?

Also, I didn't see OppiaTestRule in the QuestionPlayerActivityTest which I think needed to enable the RunOn!! Am I mistaken something here?

@anandwana001 anandwana001 mentioned this issue Nov 27, 2020
Merged
8 tasks
@BenHenning BenHenning mentioned this issue Dec 1, 2020
Merged
8 tasks
BenHenning pushed a commit that referenced this issue Dec 2, 2020
@anandwana001
Fix part of #2057: Remove unnecessary RunOn from QuestionPlayerActivi…
8e4b439 
…tyTest (#2189)

* remove unnecessary runon

* add doc and bind with OppiaTestRule

* fix typo
@ShridharGoel ShridharGoel mentioned this issue Jan 4, 2021
Closed
8 tasks
@anandwana001 anandwana001 mentioned this issue Jan 7, 2021
Open
@prayutsu
Copy link
Contributor

In QuestionPlayerActivityTest all test cases are passing on robolectric without the need for @RunOn(TestPlatform.ESPRESSO).
@prayutsu Is there any update on this? How we solved the previous issue we are getting while we are trying to solve the tick problem?

Also, I didn't see OppiaTestRule in the QuestionPlayerActivityTest which I think needed to enable the RunOn!! Am I mistaken something here?

@anandwana001 Actually, those tests didn't fail when we didn't merge PR #1923, they were passing because of this issue. So, those tests can't be considered right in robolectric until this issue is resolved.

@Broppia Broppia added issue_type_feature Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added issue_type_infrastructure Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed issue_type_enhancement labels Sep 16, 2022
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_type_infrastructure labels Mar 28, 2023
@MohitGupta121 MohitGupta121 added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenHenning BenHenning

Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
6 participants
@seanlip @BenHenning @anandwana001 @prayutsu @MohitGupta121 @Broppia