Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around Robolectric bug not computing TextView size correctly #2031

Open
BenHenning opened this issue Oct 22, 2020 · 2 comments
Open

Work around Robolectric bug not computing TextView size correctly #2031

BenHenning opened this issue Oct 22, 2020 · 2 comments
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

BenHenning commented Oct 22, 2020 •
edited
Loading

#1923 has context. Robolectric has a bug where it doesn't compute TextView sizes correctly (it assumes each character is 1 pixel wide), which leads to incorrect layouts in our Robolectric tests. Fixing this within Robolectric is probably practically infeasible, so we need to fix this with a workaround shadow that actually computes a reasonable text size for texts.
@anandwana001
Copy link
Contributor

Adding link for reference - https://chromium.googlesource.com/external/robolectric/+/0e0c6cbcda5605ac3f072cc6ce014347db763b75/robolectric/src/test/java/org/robolectric/shadows/TextViewTest.java

@BenHenning
Copy link
Member Author

#2057 is tracking the same thing.

@BenHenning BenHenning mentioned this issue Nov 16, 2020
Merged
8 tasks
@prayutsu prayutsu mentioned this issue Jan 14, 2021
Merged
8 tasks
@Broppia Broppia added issue_type_bug Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Jul 29, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_user_developer labels Mar 29, 2023
@MohitGupta121 MohitGupta121 added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
5 participants
@seanlip @BenHenning @anandwana001 @MohitGupta121 @Broppia