Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thorough tests for the question player #503

Open
BenHenning opened this issue Dec 2, 2019 · 8 comments
Open

Add thorough tests for the question player #503

BenHenning opened this issue Dec 2, 2019 · 8 comments
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

BenHenning commented Dec 2, 2019

Similar to #388 we need thorough tests for the question player once these can be written in a reliable way for both Espresso & Robolectric.

Test reference: https://github.com/oppia/oppia-android/blob/develop/app/src/sharedTest/java/org/oppia/android/app/topic/questionplayer/QuestionPlayerActivityTest.kt

@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Dec 2, 2019
@BenHenning BenHenning self-assigned this Dec 2, 2019
@BenHenning BenHenning added this to the Beta milestone Jun 23, 2020
@BenHenning BenHenning changed the title Add thorough tests for the question player [Blocked: #89] Add thorough tests for the question player Sep 24, 2020
@BenHenning
Copy link
Member Author

Enough of #89 is now complete that this is no longer blocked.

@chrk2205
Copy link
Contributor

chrk2205 commented Feb 2, 2021

@anandwana001 I would like to work on this

@anandwana001
Copy link
Contributor

@chrk2205 assigned to you.
Few points to get start:

  1. Write down all the edges case which needs to get tested.
  2. Don't include end to end test, example like opening and activity and the checking any view. Robolectric doesn't support end to end test.
  3. All the test should pass on both espresso and robolectric

How you can send a pr for this:

  1. After writing all the points what we need to test, create a comment block in the test file and write the test names and send for review
  2. Once above reviewed, you can write test cases.

Let me know if you need any help in this.

@chrk2205
Copy link
Contributor

chrk2205 commented Feb 3, 2021

there are some test cases already present in the QuestionPlayerActivityTest.kt
Do I need to write test cases apart from them ??
@anandwana001
thanks

@chrk2205
Copy link
Contributor

chrk2205 commented Feb 3, 2021

@anandwana001
for test cases should I include this??

  • OnBackPressed and its respective cases
  • toolbar title display

thanks

@anandwana001
Copy link
Contributor

Yes, for both comments above

@ayush0402
Copy link
Contributor

@anandwana001 Is this issue still needed to be fixed?

@BenHenning
Copy link
Member Author

@ayush0402 yes. There's no dedicated test suite for questions currently. We have a few tests in QuestionPlayerActivityTest, but what we really need are QuestionPlayerFragmentLocalTest and QuestionPlayerFragmentTest akin to StateFragmentLocalTest and StateFragmentTest, respectively, that test various interaction & hint scenarios for questions.

@BenHenning BenHenning added Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta milestone Sep 16, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_type_infrastructure labels Mar 28, 2023
@adhiamboperes adhiamboperes added the Work: Low Solution is clear and broken into good-first-issue-sized chunks. label Sep 22, 2023
@adhiamboperes adhiamboperes removed Priority: Essential This work item must be completed for its milestone. Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

Successfully merging a pull request may close this issue.

9 participants