Fix #511 : Past expanded answers do not collapse in the question player

[anandwana001]

Explanation

Fixes #511

Added QuestionPlayerActivityLocalTest. Added test cases for the previous header expand and collapse logic both in StateFragment and QuestionPlayer.

Test passing with these test cases

Test fails without this fix

Till here all test are passing in StateFragmentLocalTest

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

[BenHenning]

Thanks @anandwana001! I have one overall question that I left a comment on.

[BenHenning]

This is awesome, nice find @anandwana001! Since this is really subtle, can we add a GitHub action to test that new code doesn't use certain prohibited patterns like this import?

[anandwana001]

This is awesome, nice find @anandwana001! Since this is really subtle, can we add a GitHub action to test that new code doesn't use certain prohibited patterns like this import?

Yes, I can file issue regarding the check you mention with few others custom check we are thinking to good to have.

[rt4914]

LGTM, thanks.

[anandwana001]

@BenHenning Are we good to merge this PR now?
I had created another issue which will track the addition of custom lint checks we need in our codebase.
#1545

[BenHenning]

Thanks for filing the issue. I think adding a test should still be a priority since it should be possible.

[rt4914]

@anandwana001 Un-assigning myself until this comment related discussion gets and update #1456 (comment)

[BenHenning]

Thanks!