Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #511 : Past expanded answers do not collapse in the question player #1456

Merged
merged 26 commits into from
Aug 24, 2020
Merged

Fix #511 : Past expanded answers do not collapse in the question player #1456

Changes from 2 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
988e0cb
fix previous response collapse
anandwana001 Jul 8, 2020
f19973c
Merge branch 'develop' into question-player-previous-collapse
BenHenning Jul 13, 2020
6bebea4
Merge branch 'develop' into question-player-previous-collapse
BenHenning Jul 14, 2020
f3a5993
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
anandwana001 Jul 29, 2020
2585f95
Merge remote-tracking branch 'origin/question-player-previous-collaps…
anandwana001 Jul 29, 2020
6745596
added correct import
anandwana001 Jul 29, 2020
f6cf1f6
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
anandwana001 Jul 30, 2020
7409c79
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
anandwana001 Aug 4, 2020
839aa55
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
anandwana001 Aug 7, 2020
bed8507
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
anandwana001 Aug 11, 2020
a8a5c9b
added test cases
anandwana001 Aug 11, 2020
72c3933
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
anandwana001 Aug 13, 2020
3cbfbec
added test for question player
anandwana001 Aug 13, 2020
b2659b8
fix ktlint
anandwana001 Aug 13, 2020
c634780
update skill_id to test_skill_id
anandwana001 Aug 14, 2020
dbd9a4d
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
anandwana001 Aug 18, 2020
29548eb
added QuestionPlayerActivityLocalTest
anandwana001 Aug 19, 2020
9b68e3c
nit changes as suggested
anandwana001 Aug 20, 2020
14baaa2
removed unused import
anandwana001 Aug 20, 2020
4ca7d05
failed test to check over CI
anandwana001 Aug 22, 2020
9011b27
revert failed test to check over CI
anandwana001 Aug 22, 2020
ec8c7d3
updating dagger modules
anandwana001 Aug 23, 2020
e23ea0e
adding profile init in test
anandwana001 Aug 23, 2020
163d253
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
anandwana001 Aug 23, 2020
d28ea84
fix merge issue
anandwana001 Aug 23, 2020
0322c27
added questionplayer test to CI
anandwana001 Aug 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/org/oppia/app/topic/questionplayer/QuestionPlayerFragmentPresenter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ class QuestionPlayerFragmentPresenter @Inject constructor(

fun onResponsesHeaderClicked() {
recyclerViewAssembler.togglePreviousAnswers(questionViewModel.itemList)
recyclerViewAssembler.adapter.notifyDataSetChanged()
recyclerViewAssembler.adapter.setDataUnchecked(questionViewModel.itemList)
BenHenning marked this conversation as resolved.
Show resolved Hide resolved
}

/**
Expand Down