[PyOV] Extend Python API with Col2Im-15
#24569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2024
mitruska
approved these changes
May 17, 2024
akuporos
approved these changes
May 17, 2024
jiwaszki
reviewed
May 17, 2024
Comment on lines
68
to
73
| for param in [strides, dilations]: | ||
| if param is None: | ||
| param = [1, 1] | ||
| for param in [pads_begin, pads_end]: | ||
| if param is None: | ||
| param = [0, 0] |
There was a problem hiding this comment.
Can you test these None cases somehow?
There was a problem hiding this comment.
They are tested in the first test case: ((3, 4), [2, 2], [1, 1], [3, 2, 2], []),. The last empty list is params, which are given into the op constructor as *params.
rkazants
reviewed
May 18, 2024
| @@ -6,4 +6,5 @@ | |||
|
|
|||
| # TODO (ticket 138273): Add previous opset operators at the end of opset15 development | |||
| from openvino.runtime.opset1.ops import parameter | |||
| from openvino.runtime.opset15.ops import col2im | |||
There was a problem hiding this comment.
do we need from openvino.runtime.opset1.ops import parameter above?
There was a problem hiding this comment.
I'm not certain, my guess is that it was needed in opset15 for now for the tests to use it. One way or another since this PR is targeted for Code Freeze let's come back to it another time.
rkazants
approved these changes
May 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 21, 2024
### Details: - Similar in functionality to https://pytorch.org/docs/stable/generated/torch.nn.Fold.html, Col2Im is `torch.nn.Fold` restricted to two output spatial dimensions ### Tickets: - CVS-138919 ### Related PRs: - #24197 - #23947 - #24569 --------- Co-authored-by: Michal Lukaszewski <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
### Details: - Register `Col2im-15` in CPU Plugin - Use reference implementation, used #23844 as reference - Add tests ### Tickets: - CVS-142438 ### Related PRs: - #24548 - #24197 - #23947 - #24569 --------- Co-authored-by: Michal Lukaszewski <[email protected]> Co-authored-by: Maksim Kutakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Col2Im-15Col2Im-15reference implementation #24548 to work and pass CITickets:
Related PRs:
Col2Im-15reference implementation #24548Col2Im-15implementation to Core #24197