[CPU]: Added ROIAlignRotated basic impl. #23844

pkowalc1 · 2024-04-03T15:01:59Z

Details:

Added basic implementation of ROIAlignRotated
It uses implementation from core::reference - the goal was just to add support for the op, not the optimized implementation.
No unit tests added, since impl is already tested by core::reference and functional tests.

Tickets:

CVS-135847

…onformance test(not ref impl yet)

Co-authored-by: Pawel Raasz <[email protected]>

… there is no op's implementation.

…kowalc1/openvino into roi_align_rotated_operator_def

… change in spec.

…kowalc1/openvino into roi_align_rotated_operator_def

src/core/src/op/roi_align_rotated.cpp

Co-authored-by: Pawel Raasz <[email protected]>

…hub.com/pkowalc1/openvino into roi_align_rotated_intel_cpu_plugin_impl

…luate method." This reverts commit a7de6e2.

nshchego · 2024-05-19T19:40:22Z

src/plugins/intel_cpu/src/nodes/roi_align_rotated.cpp

+
+#include "roi_align_rotated.h"
+
+#include <openvino/opsets/opset14.hpp>


Please include just required operation headers.

nshchego · 2024-05-19T19:44:00Z

src/plugins/intel_cpu/src/nodes/roi_align_rotated.cpp

+namespace ov {
+namespace intel_cpu {
+namespace node {
+


Need to add fn isSupportedOperation(), like in other CPU nodes

nshchego · 2024-05-19T19:54:24Z

src/plugins/intel_cpu/src/nodes/roi_align_rotated.cpp

+    ov::element::Type outputPrec = getOriginalOutputPrecisionAtPort(0);
+
+    addSupportedPrimDesc(
+        {{LayoutType::ncsp, inputPrec0}, {LayoutType::ncsp, ov::element::f32}, {LayoutType::ncsp, ov::element::i32}},


As per specification, 1st and 2nd inputs have the same precisions. Why the second one is always f32?
Also need to check this value. Plugin supports only f32, f16 and bf16 floating point types.

nshchego · 2024-05-19T19:57:25Z

src/plugins/intel_cpu/src/nodes/roi_align_rotated.cpp

+
+void ROIAlignRotated::execute(dnnl::stream) {
+    const ov::element::Type type = getOriginalInputPrecisionAtPort(0);
+    executeImpl<ov::element::f32>();


Why this fn is called twice?

nshchego · 2024-05-19T19:58:43Z

src/plugins/intel_cpu/src/nodes/roi_align_rotated.cpp

+        CASE(bf16);
+        CASE(f16);
+        CASE(f32);
+        CASE(f64);


Not supported by plugin

nshchego · 2024-05-19T20:04:12Z

Please add CPU layer tests

nshchego · 2024-05-19T20:05:03Z

src/plugins/intel_cpu/CMakeLists.txt

@@ -186,6 +186,11 @@ if (ENABLE_SNIPPETS_LIBXSMM_TPP)
    target_include_directories(${TARGET_NAME} SYSTEM PRIVATE $<TARGET_PROPERTY:xsmm,INCLUDE_DIRECTORIES>)
 endif ()
 target_include_directories(${TARGET_NAME} SYSTEM PRIVATE $<TARGET_PROPERTY:dnnl,INCLUDE_DIRECTORIES>)
+
+# Temporal solution to use template reference implementations in cases where optimizied implementation


Please add a ticket number

nshchego · 2024-05-20T07:21:19Z

src/plugins/intel_cpu/src/nodes/roi_align_rotated.cpp

+        executeImpl<ov::element::OV_TYPE>(); \
+        break;
+
+    switch (type) {


Use OV_SWITCH instead

### Details: - Register `Col2im-15` in CPU Plugin - Use reference implementation, used #23844 as reference - Add tests ### Tickets: - CVS-142438 ### Related PRs: - #24548 - #24197 - #23947 - #24569 --------- Co-authored-by: Michal Lukaszewski <[email protected]> Co-authored-by: Maksim Kutakov <[email protected]>

pkowalc1 and others added 30 commits March 14, 2024 11:06

[Op]: Added definition of ROIAlignedRotated.

4a5775b

[Op]:[ROIAlignRotated]: Fixed tests code style.

e0c13d1

[Op]:[ROIAlignRotated]: Fixerd codestyle.

e713a7b

[Op][ROIAlignRotated]: Removed form opset14_tbl, to disable failing c…

fb113e6

…onformance test(not ref impl yet)

Merge branch 'master' into roi_align_rotated_operator_def

b09db55

Merge branch 'master' into roi_align_rotated_operator_def

f5e31b9

[Op]:[ROIAlign]: Refactoring, introduced ROIAlignBase.

77a4223

Update src/core/shape_inference/include/roi_align_shape_utils.hpp

5943fa8

Co-authored-by: Pawel Raasz <[email protected]>

Update src/core/shape_inference/include/roi_align_shape_inference.hpp

eb7720d

Co-authored-by: Pawel Raasz <[email protected]>

Update src/core/tests/type_prop/roi_align.cpp

ce5dcc6

Co-authored-by: Pawel Raasz <[email protected]>

Update src/core/src/op/roi_align_rotated.cpp

014f931

Co-authored-by: Pawel Raasz <[email protected]>

[Op][ROIAlignRotated]: Review comments.

d3a3c57

[Op]:[ROIAlignRotated]: code sytle fixes.

7b56861

[Op]:{ROIAlign]: Fixed code style.

0756ecf

[Op]:[ROIAlignRotated]: Fixed code style.

9008667

[Op]:[ROIAlign]: Fixed code style.

ac066f7

[Op]:[ROIAlign]: Fixed type bug.

e0e78a3

[Op]:[ROIAlignBase]: Fixed naming convention.

190cc6b

[Op][ROIAlignRotated]: Temporary removed new op from tests, since now…

af1b95e

… there is no op's implementation.

Merge branch 'master' into roi_align_rotated_operator_def

ee705be

[Op]:[ROIAlign]: Review fixes.

38206ee

Merge branch 'roi_align_rotated_operator_def' of https://github.com/p…

5e369cc

…kowalc1/openvino into roi_align_rotated_operator_def

[Op][ROIAlign]: Fixed code style.

074a209

[Op]:[ROIAlign]: Fixed crash in template plugin tests

995c542

Merge branch 'master' into roi_align_rotated_operator_def

2b4aec4

Merge branch 'master' into roi_align_rotated_operator_def

c2a1228

Merge branch 'master' into roi_align_rotated_operator_def

4b831c5

[Op][ROIAlignRotated]: Changed size of second dim of roi input due to…

4ecbfa7

… change in spec.

Merge branch 'roi_align_rotated_operator_def' of https://github.com/p…

242d91f

…kowalc1/openvino into roi_align_rotated_operator_def

Merge branch 'master' into roi_align_rotated_operator_def

fbe71f8

github-actions bot removed the category: build OpenVINO cmake script / infra label May 13, 2024

praasz reviewed May 14, 2024

View reviewed changes

pkowalc1 and others added 7 commits May 14, 2024 09:14

Merge branch 'master' into roi_align_rotated_intel_cpu_plugin_impl

aca6338

Review fix: src/core/src/op/roi_align_rotated.cpp

42a534b

Co-authored-by: Pawel Raasz <[email protected]>

Review fix: Update src/core/src/op/roi_align_rotated.cpp

f6dd302

Co-authored-by: Pawel Raasz <[email protected]>

Merge branch 'master' into roi_align_rotated_intel_cpu_plugin_impl

5624e0a

[opset]: Fixed error after merge conflict resolution.

328dabf

Merge branch 'roi_align_rotated_intel_cpu_plugin_impl' of https://git…

6ad51f3

…hub.com/pkowalc1/openvino into roi_align_rotated_intel_cpu_plugin_impl

Revert "[cpu_plugin]: Added support for ROIAlignRotated by adding eva…

33960ed

…luate method." This reverts commit a7de6e2.

github-actions bot added category: CPU OpenVINO CPU plugin category: build OpenVINO cmake script / infra labels May 14, 2024

Merge branch 'master' into roi_align_rotated_intel_cpu_plugin_impl

a9a6316

pkowalc1 removed the do not merge label May 14, 2024

Merge branch 'master' into roi_align_rotated_intel_cpu_plugin_impl

c68e148

mlukasze added the Code Freeze label May 15, 2024

mlukasze added this to the 2024.2 milestone May 15, 2024

pkowalc1 added this pull request to the merge queue May 15, 2024

Merged via the queue into openvinotoolkit:master with commit cf5bf71 May 15, 2024
115 checks passed

pkowalc1 deleted the roi_align_rotated_intel_cpu_plugin_impl branch May 15, 2024 13:52

nshchego reviewed May 19, 2024

View reviewed changes

src/plugins/intel_cpu/src/nodes/roi_align_rotated.cpp

CASE(bf16);

CASE(f16);

CASE(f32);

CASE(f64);

Copy link

Contributor

nshchego May 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not supported by plugin

nshchego reviewed May 19, 2024

View reviewed changes

nshchego reviewed May 20, 2024

View reviewed changes

p-wysocki mentioned this pull request Jun 10, 2024

[Op] Extend CPU Plugin with Col2Im reference implementation #24931

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CPU]: Added ROIAlignRotated basic impl. #23844

[CPU]: Added ROIAlignRotated basic impl. #23844

pkowalc1 commented Apr 3, 2024 •

edited

Loading

nshchego May 19, 2024

nshchego May 19, 2024

nshchego May 19, 2024

nshchego May 19, 2024

nshchego May 19, 2024

nshchego commented May 19, 2024

nshchego May 19, 2024

mlukasze May 20, 2024

nshchego May 20, 2024


		#include "roi_align_rotated.h"

		#include <openvino/opsets/opset14.hpp>

[CPU]: Added ROIAlignRotated basic impl. #23844

[CPU]: Added ROIAlignRotated basic impl. #23844

Conversation

pkowalc1 commented Apr 3, 2024 • edited Loading

Details:

Tickets:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nshchego commented May 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pkowalc1 commented Apr 3, 2024 •

edited

Loading