New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Op] Extend CPU Plugin with `Col2Im` reference implementation #24931

Merged

p-wysocki merged 26 commits into openvinotoolkit:master from p-wysocki:col2im_cpu

Jul 3, 2024

Contributor

p-wysocki commented Jun 10, 2024 •

edited

Loading

Details:

Register Col2im-15 in CPU Plugin
Use reference implementation, used [CPU]: Added ROIAlignRotated basic impl. #23844 as reference
Add tests

Tickets:

CVS-142438

Related PRs:

p-wysocki added 3 commits

June 10, 2024 14:41


          Add support and tests

f43da34


          Merge branch 'master' of https://github.com/openvinotoolkit/openvino …

df9750e

…into col2im_cpu


          Remove comment

d8c46a0

p-wysocki requested review from mitruska, mmikolajcz, PiotrKrzem and nshchego

June 10, 2024 12:46

p-wysocki requested review from a team as code owners

June 10, 2024 12:46

github-actions bot added category: Core category: CPU labels

p-wysocki changed the title ~~[Op] Extend CPU with Col2Im reference implementation~~ [Op] Extend CPU Plugin with Col2Im reference implementation

Contributor

dmitry-gorokhov commented Jun 10, 2024

@nshchego Please take a look

dmitry-gorokhov assigned nshchego

p-wysocki requested a review from praasz

June 10, 2024 14:37


          Merge branch 'master' into col2im_cpu

4669b19

nshchego reviewed

View reviewed changes

src/plugins/intel_cpu/src/nodes/col2im.cpp Outdated Show resolved Hide resolved

nshchego reviewed

View reviewed changes

src/plugins/intel_cpu/src/nodes/col2im.cpp Show resolved Hide resolved

nshchego reviewed

View reviewed changes

src/plugins/intel_cpu/src/nodes/col2im.cpp Outdated Show resolved Hide resolved

nshchego reviewed

View reviewed changes

src/plugins/intel_cpu/src/nodes/col2im.cpp Outdated Show resolved Hide resolved

praasz reviewed

View reviewed changes

src/core/reference/include/openvino/reference/col2im.hpp Outdated Show resolved Hide resolved

nshchego reviewed

View reviewed changes

src/plugins/intel_cpu/tests/functional/custom/single_layer_tests/col2im.cpp Outdated Show resolved Hide resolved

p-wysocki added 3 commits

June 17, 2024 11:47


          Merge branch 'master' of https://github.com/openvinotoolkit/openvino …

5116e98

…into col2im_cpu


          Apply CR

2b5c1bd


          Merge branch 'col2im_cpu' of https://github.com/p-wysocki/openvino in…

318e66e

…to col2im_cpu

p-wysocki requested review from praasz and nshchego

June 17, 2024 13:18

p-wysocki mentioned this pull request

[Good First Issue]: Extend ONNX Frontend with Operator Col2Im-18 #20549

Open

mitruska requested changes

View reviewed changes

src/plugins/intel_cpu/src/nodes/col2im.cpp Outdated Show resolved Hide resolved

src/plugins/intel_cpu/src/nodes/col2im.cpp Outdated Show resolved Hide resolved

p-wysocki added 2 commits

July 1, 2024 12:05


          Skip bf16 tests

6ff668e


          Merge branch 'master' of https://github.com/openvinotoolkit/openvino …

95a5067

…into col2im_cpu

p-wysocki enabled auto-merge

July 1, 2024 10:41

maxnick disabled auto-merge

July 1, 2024 11:12

maxnick requested changes

View reviewed changes

src/plugins/intel_cpu/tests/functional/custom/single_layer_tests/col2im.cpp Outdated Show resolved Hide resolved

src/plugins/intel_cpu/tests/functional/shared_tests_instances/skip_tests_config.cpp Outdated Show resolved Hide resolved


          Apply CR

f6cf664

p-wysocki requested a review from maxnick

July 1, 2024 13:21

maxnick reviewed

View reviewed changes

src/plugins/intel_cpu/tests/functional/custom/single_layer_tests/col2im.cpp Outdated Show resolved Hide resolved

mlukasze and others added 5 commits

July 2, 2024 07:30


          Merge branch 'master' into col2im_cpu

fb858f5


          temp

8eeca44


          Move tests

567c30c


          Merge branch 'col2im_cpu' of https://github.com/p-wysocki/openvino in…

d383b0b

…to col2im_cpu


          Minor change

4dea038

p-wysocki requested a review from maxnick

July 2, 2024 09:20

maxnick reviewed

View reviewed changes

src/plugins/intel_cpu/tests/functional/custom/single_layer_tests/classes/col2im.hpp Outdated Show resolved Hide resolved

src/plugins/intel_cpu/tests/functional/custom/single_layer_tests/classes/col2im.cpp Outdated Show resolved Hide resolved

maxnick reviewed

View reviewed changes

src/plugins/intel_cpu/tests/functional/custom/single_layer_tests/instances/common/col2im.cpp Outdated Show resolved Hide resolved

src/plugins/intel_cpu/tests/functional/custom/single_layer_tests/instances/x64/col2im.cpp Outdated Show resolved Hide resolved

src/plugins/intel_cpu/tests/functional/custom/single_layer_tests/classes/col2im.hpp Outdated Show resolved Hide resolved

p-wysocki and others added 5 commits

July 2, 2024 11:48


          Update src/plugins/intel_cpu/tests/functional/custom/single_layer_tes…

45a89a2

…ts/classes/col2im.hpp

Co-authored-by: Maksim Kutakov <[email protected]>


          Update src/plugins/intel_cpu/tests/functional/custom/single_layer_tes…

637fc89

…ts/instances/x64/col2im.cpp

Co-authored-by: Maksim Kutakov <[email protected]>


          Update src/plugins/intel_cpu/tests/functional/custom/single_layer_tes…

972a2ed

…ts/instances/common/col2im.cpp

Co-authored-by: Maksim Kutakov <[email protected]>


          Apply CR

002eab4


          Merge branch 'col2im_cpu' of https://github.com/p-wysocki/openvino in…

45eadcb

…to col2im_cpu

p-wysocki requested a review from maxnick

July 2, 2024 09:57

maxnick approved these changes

View reviewed changes


          Merge branch 'master' into col2im_cpu

f5fec06

p-wysocki enabled auto-merge

July 2, 2024 20:44


          Merge branch 'master' into col2im_cpu

c9c229a

p-wysocki added this pull request to the merge queue

Merged via the queue into openvinotoolkit:master with commit ba05386

116 checks passed

p-wysocki deleted the col2im_cpu branch

July 3, 2024 06:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

praasz praasz left review comments

nshchego nshchego approved these changes

mmikolajcz mmikolajcz approved these changes

maxnick maxnick approved these changes

mitruska mitruska approved these changes

PiotrKrzem Awaiting requested review from PiotrKrzem

Labels