Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Op] Add Col2Im-15 implementation to Core #24197

Merged
merged 20 commits into from
May 14, 2024
Merged

[Op] Add Col2Im-15 implementation to Core #24197

merged 20 commits into from
May 14, 2024

Conversation

p-wysocki
Copy link
Contributor

@p-wysocki p-wysocki commented Apr 23, 2024 •
edited
Loading

@p-wysocki p-wysocki requested review from a team as code owners April 23, 2024 13:18
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin category: CPP API OpenVINO CPP API bindings labels Apr 23, 2024
@p-wysocki p-wysocki mentioned this pull request Apr 23, 2024
Merged
@openvinotoolkit openvinotoolkit deleted a comment from praasz May 8, 2024
praasz
praasz reviewed May 10, 2024
View reviewed changes
src/core/shape_inference/include/col2im_shape_inference.hpp Show resolved Hide resolved
src/core/tests/type_prop/col2im.cpp Show resolved Hide resolved
src/core/tests/type_prop/col2im.cpp Outdated Show resolved Hide resolved
src/core/tests/type_prop/col2im.cpp Show resolved Hide resolved
src/core/tests/type_prop/col2im.cpp Outdated Show resolved Hide resolved
src/core/shape_inference/include/col2im_shape_inference.hpp Show resolved Hide resolved
src/core/shape_inference/include/col2im_shape_inference.hpp Outdated Show resolved Hide resolved
src/core/shape_inference/include/col2im_shape_inference.hpp Outdated Show resolved Hide resolved
src/core/shape_inference/include/col2im_shape_inference.hpp Outdated Show resolved Hide resolved
src/core/shape_inference/include/col2im_shape_inference.hpp Outdated Show resolved Hide resolved
@p-wysocki p-wysocki requested a review from praasz May 10, 2024 13:24
@p-wysocki p-wysocki requested a review from praasz May 10, 2024 14:42
praasz
praasz approved these changes May 13, 2024
View reviewed changes
src/plugins/intel_cpu/tests/unit/shape_inference_test/col2im_shape_inference_test.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/tests/unit/shape_inference_test/col2im_shape_inference_test.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/tests/unit/shape_inference_test/col2im_shape_inference_test.cpp Outdated Show resolved Hide resolved
src/core/shape_inference/include/col2im_shape_inference.hpp Show resolved Hide resolved
src/core/shape_inference/include/col2im_shape_inference.hpp Show resolved Hide resolved
src/core/shape_inference/include/col2im_shape_inference.hpp Outdated Show resolved Hide resolved
src/core/shape_inference/include/col2im_shape_inference.hpp Outdated Show resolved Hide resolved
@mlukasze mlukasze enabled auto-merge May 14, 2024 05:28
@mlukasze mlukasze added this pull request to the merge queue May 14, 2024
Merged via the queue into openvinotoolkit:master with commit 239b578 May 14, 2024
115 checks passed
@p-wysocki p-wysocki deleted the col2im_core branch May 14, 2024 07:31
github-merge-queue bot pushed a commit that referenced this pull request May 16, 2024
@p-wysocki
[Opset15][Spec] Col2Im-15 specification (#23947)
9280cec 
### Details:
- Similar in functionality to
https://pytorch.org/docs/stable/generated/torch.nn.Fold.html, `Col2Im`
is `torch.nn.Fold` restricted to two output spatial dimensions
- Some `Col2Im` related discussions:
#20549

### Related PRs
- #24197

### Tickets:
 - CVS-133358
This was referenced May 16, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 21, 2024
@p-wysocki @mlukasze
[Op] Col2Im-15 reference implementation (#24548)
fba3ec0 
### Details:
- Similar in functionality to
https://pytorch.org/docs/stable/generated/torch.nn.Fold.html, Col2Im is
`torch.nn.Fold` restricted to two output spatial dimensions

### Tickets:
 - CVS-138919

### Related PRs:
- #24197
- #23947
- #24569

---------

Co-authored-by: Michal Lukaszewski <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request May 23, 2024
@p-wysocki @mlukasze
[PyOV] Extend Python API with Col2Im-15 (#24569)
c4f33ce 
### Details:
 - Add Python API for `Col2Im-15`
- Requires #24548 to
work and pass CI

### Tickets:
 - CVS-138920

### Related PRs:
- #24548
- #24197
- #23947

---------

Co-authored-by: Michal Lukaszewski <[email protected]>
@p-wysocki p-wysocki mentioned this pull request Jun 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 3, 2024
@p-wysocki @mlukasze @maxnick
[Op] Extend CPU Plugin with Col2Im reference implementation (#24931)
ba05386 
### Details:
 - Register `Col2im-15` in CPU Plugin
- Use reference implementation, used
#23844 as reference
 - Add tests

### Tickets:
 - CVS-142438

### Related PRs:
 - #24548
 - #24197
 - #23947
 - #24569

---------

Co-authored-by: Michal Lukaszewski <[email protected]>
Co-authored-by: Maksim Kutakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praasz praasz praasz approved these changes

@t-jankowski t-jankowski t-jankowski approved these changes

@mmikolajcz mmikolajcz Awaiting requested review from mmikolajcz

@mitruska mitruska Awaiting requested review from mitruska

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@p-wysocki @mitruska @t-jankowski @praasz @mlukasze