-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Good First Issue]: Extend Python API with ROIAlignRotated-15
#25325
Labels
category: Opset
OpenVINO Opset
category: Python API
OpenVINO Python bindings
good first issue
Good for newcomers
Milestone
Comments
mitruska
added
category: Python API
OpenVINO Python bindings
category: Opset
OpenVINO Opset
labels
Jul 2, 2024
.take |
Thank you for looking into this issue! Please let us know if you have any questions or require any help. |
.take |
Thank you for looking into this issue! Please let us know if you have any questions or require any help. |
@hub-bla The PR #25755 has been merged, thank you for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: Opset
OpenVINO Opset
category: Python API
OpenVINO Python bindings
good first issue
Good for newcomers
Context
Instead of doing C++ to Python bindings for each and every OpenVINO operator, we are using internal
NodeFactory
, which takes the name of the operator as an argument:Such an API is counter intuitive for an end user, so we are also adding Python API with a proper, pythonic and clear functions. Those Python functions are just wrappers around
NodeFactory
object call, and their primary goal is to provide appropriate inputs docs and more pythonic API:This task regards adding such a Python API function for ROIAlignRotated-15 operator.
What needs to be done?
ROIAlignRotated
is a similar op toROIAlign
, with some modifications to enable rotation.Python API
roi_align
can be used as an example:openvino/src/bindings/python/src/openvino/runtime/opset9/ops.py
Lines 97 to 141 in bc505ba
Python API
roi_align_rotated
function should reflect ROIAlignRotated C++ constructor:openvino/src/core/include/openvino/op/roi_align_rotated.hpp
Lines 20 to 39 in bc505ba
Please see attached PR, this task is very similar to the linked
Col2Im
Python API.Example Pull Requests
#24569
Resources
Contact points
@mitruska
@p-wysocki
@akuporos
Ticket
141569
The text was updated successfully, but these errors were encountered: