Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Notification event page #549

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

manasvinibs
Copy link
Member

@manasvinibs manasvinibs commented Mar 1, 2023

Description

  • remove all logos from each example
  • remove "beta" from page
  • remove "new" from side navigation

Screenshots:

remove "new" from side navigation

Before:
Screenshot 2023-03-01 at 11 57 50 AM

After:

Screenshot 2023-03-01 at 11 46 26 AM

* remove "beta" from page

Before:

Screenshot 2023-03-01 at 11 59 21 AM

After:

Screenshot 2023-03-01 at 11 46 14 AM

* remove all logos from each example

Before:
Screenshot 2023-03-01 at 12 14 44 PM

After:

Screenshot 2023-03-01 at 11 46 47 AM

Before:
Screenshot 2023-03-01 at 12 17 09 PM

After:

Screenshot 2023-03-01 at 11 53 04 AM

Before:
Screenshot 2023-03-01 at 12 18 26 PM

After:

Screenshot 2023-03-01 at 11 47 11 AM

Before:
Screenshot 2023-03-01 at 12 18 47 PM

After:

Screenshot 2023-03-01 at 11 47 19 AM

Issues Resolved

Fixes #88

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@manasvinibs manasvinibs requested a review from a team as a code owner March 1, 2023 01:22
@KrooshalUX
Copy link
Contributor

@manasvinibs can you provide a screenshot of the changes for UX review?

@manasvinibs
Copy link
Member Author

@manasvinibs can you provide a screenshot of the changes for UX review?

I've updated the screenshots. Please take a look.

kgcreative
kgcreative previously approved these changes Mar 1, 2023
Copy link
Member

@kgcreative kgcreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgcreative
Copy link
Member

@kroosh, should we show at least one glyph instead of a logo to show some flexibility here?

Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@BSFishy BSFishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for UX approval

@KrooshalUX
Copy link
Contributor

Waiting for UX approval

LGTM !

@KrooshalUX KrooshalUX self-requested a review March 3, 2023 00:33
Copy link
Contributor

@KrooshalUX KrooshalUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BSFishy BSFishy merged commit 8e5ca5c into opensearch-project:main Mar 3, 2023
AMoo-Miki pushed a commit to AMoo-Miki/oui that referenced this pull request Jul 2, 2023
AMoo-Miki added a commit that referenced this pull request Jul 15, 2023
* Remove beta badge accent color (#99)

Signed-off-by: Matt Provost <[email protected]>

Signed-off-by: Matt Provost <[email protected]>

* OUI combo box refine (#183)

* Added a prop clearOnBlur

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Added example for prop clearOnBlur

Signed-off-by: AbhishekReddy1127 <[email protected]>

---------

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Update Comment List Docs (#252)

Signed-off-by: Matt Provost <[email protected]>

* Updated the section Collapsable Nav (#330)

Signed-off-by: AbhishekReddy1127 <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>

* Updated the kibana to opensearch_dashboards (#343)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Updated the section drag and drop (#514)

Signed-off-by: AbhishekReddy1127 <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>

* Update @svgr/core and @svgr/plugin-svgo (#594) (#649)

Signed-off-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>

* Migrate from faker to @faker-js/faker (#594) (#655)

Signed-off-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>

* Bump @faker-js/faker to v8 (#594) (#768)

Signed-off-by: Andrey Myssak <[email protected]>

* change beta to experimental (#383)

Signed-off-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>

* Normalize interlink URL usage (#698) (#720)

Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>

* [CCI] Add `useDeprecatedPropWarning` and align with `deprecated` hoc (#762)

* Add useDeprecatedPropWarning and align with deprecated hoc (#761)

Co-authored-by: Andrey Myssak <[email protected]>
Signed-off-by: Sergey Myssak <[email protected]>

* Add multiple props to useDeprecatedPropWarning and pass getMessage to deprecatedComponentWarning (#761)

Co-authored-by: Andrey Myssak <[email protected]>
Signed-off-by: Sergey Myssak <[email protected]>

* Use ExclusiveUnion in interfaces (#761)

Co-authored-by: Andrey Myssak <[email protected]>
Signed-off-by: Sergey Myssak <[email protected]>

---------

Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>

* Update the default branch (#584) (#798)

Signed-off-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>

* [OuiComboBox] Add docs for icon and revise example for clearOnBlur (#806)

Signed-off-by: Miki <[email protected]>

* Updated bug issue template (#764)

* Update bug issue template

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Add spacing

Signed-off-by: Sirazh Gabdullin <[email protected]>

---------

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Move OuiBottomBar default inline styles to the CSS file (#693) (#694)

Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>

* [CCI] Update react-window and react-virtualized-auto-sizer dependencies (#652)

* Update react-window (#594)
* Update react-virtualized-auto-sizer (#594)

Co-authored-by: Sergey Myssak <[email protected]>
Signed-off-by: Andrey Myssak <[email protected]>

---------

Signed-off-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>

* Update dropzone (#594) (#651)

Signed-off-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>

* Updated the section Beta badge (#338)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Add props and examples for the combobox (#660)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Updated the links in the section Markdown Format (#365)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Update Notification event page (#549)

Signed-off-by: manasvinibs <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>

* Updated the content in the section Messages and loading (#350)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Updated the content in the section suggest (#347)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Update affiliation of Andrey and Sergey (#794)

Signed-off-by: Matt Provost <[email protected]>

* [CCI] Update dependencies (#716)

* Update dependencies (#594)

Co-authored-by: Sergey Myssak <[email protected]>
Signed-off-by: Andrey Myssak <[email protected]>

* Bump @axe-core/puppeteer to v4.6.1 and puppeteer to v19.11.1

Signed-off-by: Andrey Myssak <[email protected]>

* Bump react-window, tabbable and rimraf patch versions

Signed-off-by: Andrey Myssak <[email protected]>

* Bump @svgr/core, @svgr/plugin-svgo and @svgr/plugin-jsx to v8

Signed-off-by: Andrey Myssak <[email protected]>

---------

Signed-off-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>

* Replace @elastic/datemath with @opensearch/datemath (#204)

* Replace @elastic/datemath with @opensearch/datemath

Signed-off-by: Matt Provost <[email protected]>

* Clean up

Signed-off-by: Matt Provost <[email protected]>

---------

Signed-off-by: Matt Provost <[email protected]>

* Bump semver to 7.5.3 (#855)

* Bump semver to 7.5.3

Signed-off-by: Matt Provost <[email protected]>

* Add resolution to eslint plugin

Signed-off-by: Matt Provost <[email protected]>

---------

Signed-off-by: Matt Provost <[email protected]>

* Remove Split button from OUI docs (#805) (#812)

Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>

* Updated the text in the section ErrorBoundary (#366)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Docs site changes (#96)

* first change

Signed-off-by: Kroosh Crusius <[email protected]>

* undoing first change

Signed-off-by: Kroosh Crusius <[email protected]>

* making a sample change to test commit success or failure

Signed-off-by: Kroosh Crusius <[email protected]>

* undoes sample change for testing

Signed-off-by: Kroosh Crusius <[email protected]>

* minor changes for tone, deleted references to starter projects as they are not maintained by OSD

Signed-off-by: Kroosh Crusius <[email protected]>

* Delete OUI.iml

Removing as included accidentally.

* Delete oui.iml

Removing as included accidentally.

* Update getting_started.md

Updated link to node version manager to avoid redirect

---------

Signed-off-by: Kroosh Crusius <[email protected]>

* Update getting_started.md to remove elastic reference and other changes (#502)

Signed-off-by: manasvinibs <[email protected]>

* Removed GitHub column from all the tables (#371)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Updated the content and Icons in the section CssUtilityClasses (#368)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Delete Kibana reference in commands (#535)

* Delete kibana reference in commands

Signed-off-by: abbyhu2000 <[email protected]>

* Change the tgz naming to opensearch

Signed-off-by: abbyhu2000 <[email protected]>

* Updated doc site link and github reference

Signed-off-by: abbyhu2000 <[email protected]>

* Change URL to only include domain

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>

* fixed invalid link in FAQ.md (#751)

Signed-off-by: Aigerim Suleimenova <[email protected]>

---------

Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: Andrey Myssak <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Sergey Myssak <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Sirazh Gabdullin <[email protected]>
Signed-off-by: manasvinibs <[email protected]>
Signed-off-by: Kroosh Crusius <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: Aigerim Suleimenova <[email protected]>
Co-authored-by: Matt Provost <[email protected]>
Co-authored-by: Abhishek Reddy <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>
Co-authored-by: Sirazh Gabdullin <[email protected]>
Co-authored-by: Manasvini B Suryanarayana <[email protected]>
Co-authored-by: Kroosh <[email protected]>
Co-authored-by: Qingyang(Abby) Hu <[email protected]>
Co-authored-by: Aigerim Suleimenova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(OUI Docs) Notification event
6 participants