Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual][backport 1.x] Several changes #872

Merged
merged 36 commits into from
Jul 15, 2023

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Jul 2, 2023

Do not squash for merge

To Reviewers: Please check if a change is a breaking change that shouldn't be added to 1.x

Description

fixed invalid link in FAQ.md (#751)
Delete Kibana reference in commands (#535)
Updated the content and Icons in the section CssUtilityClasses (#368)
Removed GitHub column from all the tables (#371)
Update getting_started.md to remove elastic reference and other changes (#502)
Docs site changes (#96)
Updated the text in the section ErrorBoundary (#366)
Remove Split button from OUI docs (#805) (#812)
Bump semver to 7.5.3 (#855)
Replace @elastic/datemath with @opensearch/datemath (#204)
[CCI] Update dependencies (#716)
Update affiliation of Andrey and Sergey (#794)
Updated the content in the section suggest (#347)
Updated the content in the section Messages and loading (#350)
Update Notification event page (#549)
Updated the links in the section Markdown Format (#365)
Add props and examples for the combobox (#660)
Updated the section Beta badge (#338)
Update dropzone (#651)
[CCI] Update react-window and react-virtualized-auto-sizer dependencies (#652)
Move OuiBottomBar default inline styles to the CSS file (#694)
Updated bug issue template (#764)
[OuiComboBox] Add docs for icon and revise example for clearOnBlur (#806)
Update the default branch (#798)
[CCI] Add useDeprecatedPropWarning and align with deprecated hoc (#762)
Normalize interlink URL usage (#720)
change beta to experimental (#383)
Bump @faker-js/faker to v8 (#768)
Migrate from faker to @faker-js/faker (#655)
Update @svgr/core and @svgr/plugin-svgo (#649)
Updated the section drag and drop (#514)
Updated the kibana to opensearch_dashboards (#343)
Updated the section Collapsable Nav (#330)
Update Comment List Docs (#252)
OUI combo box refine (#183)
Remove beta badge accent color (#99)

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

BSFishy and others added 30 commits July 2, 2023 13:20
Signed-off-by: Matt Provost <[email protected]>

Signed-off-by: Matt Provost <[email protected]>
* Added a prop clearOnBlur

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Added example for prop clearOnBlur

Signed-off-by: AbhishekReddy1127 <[email protected]>

---------

Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: AbhishekReddy1127 <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
Signed-off-by: AbhishekReddy1127 <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
…pensearch-project#762)

* Add useDeprecatedPropWarning and align with deprecated hoc (opensearch-project#761)

Co-authored-by: Andrey Myssak <[email protected]>
Signed-off-by: Sergey Myssak <[email protected]>

* Add multiple props to useDeprecatedPropWarning and pass getMessage to deprecatedComponentWarning (opensearch-project#761)

Co-authored-by: Andrey Myssak <[email protected]>
Signed-off-by: Sergey Myssak <[email protected]>

* Use ExclusiveUnion in interfaces (opensearch-project#761)

Co-authored-by: Andrey Myssak <[email protected]>
Signed-off-by: Sergey Myssak <[email protected]>

---------

Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>
* Update bug issue template

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Add spacing

Signed-off-by: Sirazh Gabdullin <[email protected]>

---------

Signed-off-by: Sirazh Gabdullin <[email protected]>
…es (opensearch-project#652)

* Update react-window (opensearch-project#594)
* Update react-virtualized-auto-sizer (opensearch-project#594)

Co-authored-by: Sergey Myssak <[email protected]>
Signed-off-by: Andrey Myssak <[email protected]>

---------

Signed-off-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>
* Update dependencies (opensearch-project#594)

Co-authored-by: Sergey Myssak <[email protected]>
Signed-off-by: Andrey Myssak <[email protected]>

* Bump @axe-core/puppeteer to v4.6.1 and puppeteer to v19.11.1

Signed-off-by: Andrey Myssak <[email protected]>

* Bump react-window, tabbable and rimraf patch versions

Signed-off-by: Andrey Myssak <[email protected]>

* Bump @svgr/core, @svgr/plugin-svgo and @svgr/plugin-jsx to v8

Signed-off-by: Andrey Myssak <[email protected]>

---------

Signed-off-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>
…ct#204)

* Replace @elastic/datemath with @opensearch/datemath

Signed-off-by: Matt Provost <[email protected]>

* Clean up

Signed-off-by: Matt Provost <[email protected]>

---------

Signed-off-by: Matt Provost <[email protected]>
* Bump semver to 7.5.3

Signed-off-by: Matt Provost <[email protected]>

* Add resolution to eslint plugin

Signed-off-by: Matt Provost <[email protected]>

---------

Signed-off-by: Matt Provost <[email protected]>
KrooshalUX and others added 6 commits July 2, 2023 13:24
* first change

Signed-off-by: Kroosh Crusius <[email protected]>

* undoing first change

Signed-off-by: Kroosh Crusius <[email protected]>

* making a sample change to test commit success or failure

Signed-off-by: Kroosh Crusius <[email protected]>

* undoes sample change for testing

Signed-off-by: Kroosh Crusius <[email protected]>

* minor changes for tone, deleted references to starter projects as they are not maintained by OSD

Signed-off-by: Kroosh Crusius <[email protected]>

* Delete OUI.iml

Removing as included accidentally.

* Delete oui.iml

Removing as included accidentally.

* Update getting_started.md

Updated link to node version manager to avoid redirect

---------

Signed-off-by: Kroosh Crusius <[email protected]>
* Delete kibana reference in commands

Signed-off-by: abbyhu2000 <[email protected]>

* Change the tgz naming to opensearch

Signed-off-by: abbyhu2000 <[email protected]>

* Updated doc site link and github reference

Signed-off-by: abbyhu2000 <[email protected]>

* Change URL to only include domain

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed all the PR titles, and they all made sense to me as backports. @AMoo-Miki How did you go about generating this list? Is it something we can automate?

Copy link
Collaborator

@andreymyssak andreymyssak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AMoo-Miki, #798 is not intended for backport, as this change is purely for the master branch. If we merge it in 1.x, then the master header will not be hidden on the /package/changelog page

const changelogSource = require('!!raw-loader!../../../../CHANGELOG.md').default.replace(
/## \[`main`\].+?##/s, // remove the `main` heading & contents
'##'
);

But in 1.x we use
## [`master`](https://github.com/opensearch-project/oui/tree/master)

This does not break anything for the user as it is documentation, as an option we can create a separate PR to change the default branch to main in the 1.x version and be in sync with the version that is in master.

The rest of the PRs don't break anything.

@AMoo-Miki
Copy link
Collaborator Author

@andreymyssak, thanks for your input. I looked through #798 which replaced master with main; not having it makes 1.x have incorrect references to master. The changelog pages (1.1 and 1.2) are directly pulled from the CHANGELOG.md files of those branches and all branches have broken CHANGELOG.md files that are missing any entries for their versions; we will have to clean them up separately.

Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changeset looks good, I did notice that two failed backports are missing in this diff, did you miss them or were they intentional?

  • Update changelog with 1.1 info
    Missing backports: ["backport 1.x","backport 1.1"]
    ID: 718 | Verify
  • [CCI] Revert changes to chart themes
    Missing backports: ["backport 1.x"]
    ID: 831 | Verify

@AMoo-Miki
Copy link
Collaborator Author

The changeset looks good, I did notice that two failed backports are missing in this diff, did you miss them or were they intentional?

* Update changelog with 1.1 info
  Missing backports: ["backport 1.x","backport 1.1"]
  ID: 718 | [Verify](https://github.com/opensearch-project/oui/pulls?q=Update%20changelog%20with%201.1%20info)

* [CCI] Revert changes to chart themes
  Missing backports: ["backport 1.x"]
  ID: 831 | [Verify](https://github.com/opensearch-project/oui/pulls?q=%20Revert%20changes%20to%20chart%20themes)

Thanks. I will have to do another pass after this is merged.

@AMoo-Miki AMoo-Miki merged commit a1ee072 into opensearch-project:1.x Jul 15, 2023
@AMoo-Miki AMoo-Miki deleted the giant-backport-1.x-batch-1 branch September 27, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.