Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add props and examples for the combobox #660

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

AbhishekReddy1127
Copy link
Contributor

Description

Added props and examples for the combo box.

Screenshot 2023-04-04 at 1 32 56 PM

Issues Resolved

Fixes #98

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AbhishekReddy1127 AbhishekReddy1127 marked this pull request as ready for review April 4, 2023 20:34
@AbhishekReddy1127 AbhishekReddy1127 requested a review from a team as a code owner April 4, 2023 20:34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is 4c5e17dc9ff66a401874a161a8f3ea3c65904a4d in this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rebase this PR to main?

},
]);

const [selectedOptions, setSelected] = useState([options[2], options[4]]);
Copy link
Member

@bandinib-amzn bandinib-amzn Apr 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we choose option 2 and option 4? If they are default values, can we store them in constant and add comment so that in future if want to decide change the default values it will be easier for other developers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These examples are just to demo icon prop usage, I think moving to common won't be the right thing because consumers when use the example will also need to be aware and refer to common code stored which would be else where.


// Select the option.
setSelected((prevSelected) => [...prevSelected, newOption]);
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code from Line 16 to Line 80 is same in both combo_box_custome_icon.js and combo_box_default_icon.js. Is it possible to reuse the code?

Copy link
Contributor Author

@AbhishekReddy1127 AbhishekReddy1127 Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are just for demonstration purpose, examples on how to combo box with custom icon and and default search icon.
It not basically part of actual implementation. If we re-use then i think the example snippet will be disturbed...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember seeing some of these sample codes shared between examples. We could look at combining them after merging this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create an issue to refactor this code and avoid duplication and reuse examples. Approving this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Created: #830

@AMoo-Miki AMoo-Miki merged commit af0883c into opensearch-project:main Jun 20, 2023
@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-660-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 af0883cb0b87fe93fb3f6c6bd5aaafc8014880c0
# Push it to GitHub
git push --set-upstream origin backport/backport-660-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-660-to-1.x.

AMoo-Miki pushed a commit to AMoo-Miki/oui that referenced this pull request Jul 2, 2023
AMoo-Miki added a commit that referenced this pull request Jul 15, 2023
* Remove beta badge accent color (#99)

Signed-off-by: Matt Provost <[email protected]>

Signed-off-by: Matt Provost <[email protected]>

* OUI combo box refine (#183)

* Added a prop clearOnBlur

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Added example for prop clearOnBlur

Signed-off-by: AbhishekReddy1127 <[email protected]>

---------

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Update Comment List Docs (#252)

Signed-off-by: Matt Provost <[email protected]>

* Updated the section Collapsable Nav (#330)

Signed-off-by: AbhishekReddy1127 <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>

* Updated the kibana to opensearch_dashboards (#343)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Updated the section drag and drop (#514)

Signed-off-by: AbhishekReddy1127 <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>

* Update @svgr/core and @svgr/plugin-svgo (#594) (#649)

Signed-off-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>

* Migrate from faker to @faker-js/faker (#594) (#655)

Signed-off-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>

* Bump @faker-js/faker to v8 (#594) (#768)

Signed-off-by: Andrey Myssak <[email protected]>

* change beta to experimental (#383)

Signed-off-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>

* Normalize interlink URL usage (#698) (#720)

Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>

* [CCI] Add `useDeprecatedPropWarning` and align with `deprecated` hoc (#762)

* Add useDeprecatedPropWarning and align with deprecated hoc (#761)

Co-authored-by: Andrey Myssak <[email protected]>
Signed-off-by: Sergey Myssak <[email protected]>

* Add multiple props to useDeprecatedPropWarning and pass getMessage to deprecatedComponentWarning (#761)

Co-authored-by: Andrey Myssak <[email protected]>
Signed-off-by: Sergey Myssak <[email protected]>

* Use ExclusiveUnion in interfaces (#761)

Co-authored-by: Andrey Myssak <[email protected]>
Signed-off-by: Sergey Myssak <[email protected]>

---------

Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>

* Update the default branch (#584) (#798)

Signed-off-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>

* [OuiComboBox] Add docs for icon and revise example for clearOnBlur (#806)

Signed-off-by: Miki <[email protected]>

* Updated bug issue template (#764)

* Update bug issue template

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Add spacing

Signed-off-by: Sirazh Gabdullin <[email protected]>

---------

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Move OuiBottomBar default inline styles to the CSS file (#693) (#694)

Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>

* [CCI] Update react-window and react-virtualized-auto-sizer dependencies (#652)

* Update react-window (#594)
* Update react-virtualized-auto-sizer (#594)

Co-authored-by: Sergey Myssak <[email protected]>
Signed-off-by: Andrey Myssak <[email protected]>

---------

Signed-off-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>

* Update dropzone (#594) (#651)

Signed-off-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>

* Updated the section Beta badge (#338)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Add props and examples for the combobox (#660)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Updated the links in the section Markdown Format (#365)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Update Notification event page (#549)

Signed-off-by: manasvinibs <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>

* Updated the content in the section Messages and loading (#350)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Updated the content in the section suggest (#347)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Update affiliation of Andrey and Sergey (#794)

Signed-off-by: Matt Provost <[email protected]>

* [CCI] Update dependencies (#716)

* Update dependencies (#594)

Co-authored-by: Sergey Myssak <[email protected]>
Signed-off-by: Andrey Myssak <[email protected]>

* Bump @axe-core/puppeteer to v4.6.1 and puppeteer to v19.11.1

Signed-off-by: Andrey Myssak <[email protected]>

* Bump react-window, tabbable and rimraf patch versions

Signed-off-by: Andrey Myssak <[email protected]>

* Bump @svgr/core, @svgr/plugin-svgo and @svgr/plugin-jsx to v8

Signed-off-by: Andrey Myssak <[email protected]>

---------

Signed-off-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>

* Replace @elastic/datemath with @opensearch/datemath (#204)

* Replace @elastic/datemath with @opensearch/datemath

Signed-off-by: Matt Provost <[email protected]>

* Clean up

Signed-off-by: Matt Provost <[email protected]>

---------

Signed-off-by: Matt Provost <[email protected]>

* Bump semver to 7.5.3 (#855)

* Bump semver to 7.5.3

Signed-off-by: Matt Provost <[email protected]>

* Add resolution to eslint plugin

Signed-off-by: Matt Provost <[email protected]>

---------

Signed-off-by: Matt Provost <[email protected]>

* Remove Split button from OUI docs (#805) (#812)

Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>

* Updated the text in the section ErrorBoundary (#366)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Docs site changes (#96)

* first change

Signed-off-by: Kroosh Crusius <[email protected]>

* undoing first change

Signed-off-by: Kroosh Crusius <[email protected]>

* making a sample change to test commit success or failure

Signed-off-by: Kroosh Crusius <[email protected]>

* undoes sample change for testing

Signed-off-by: Kroosh Crusius <[email protected]>

* minor changes for tone, deleted references to starter projects as they are not maintained by OSD

Signed-off-by: Kroosh Crusius <[email protected]>

* Delete OUI.iml

Removing as included accidentally.

* Delete oui.iml

Removing as included accidentally.

* Update getting_started.md

Updated link to node version manager to avoid redirect

---------

Signed-off-by: Kroosh Crusius <[email protected]>

* Update getting_started.md to remove elastic reference and other changes (#502)

Signed-off-by: manasvinibs <[email protected]>

* Removed GitHub column from all the tables (#371)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Updated the content and Icons in the section CssUtilityClasses (#368)

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Delete Kibana reference in commands (#535)

* Delete kibana reference in commands

Signed-off-by: abbyhu2000 <[email protected]>

* Change the tgz naming to opensearch

Signed-off-by: abbyhu2000 <[email protected]>

* Updated doc site link and github reference

Signed-off-by: abbyhu2000 <[email protected]>

* Change URL to only include domain

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>

* fixed invalid link in FAQ.md (#751)

Signed-off-by: Aigerim Suleimenova <[email protected]>

---------

Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: Andrey Myssak <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Sergey Myssak <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Sirazh Gabdullin <[email protected]>
Signed-off-by: manasvinibs <[email protected]>
Signed-off-by: Kroosh Crusius <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: Aigerim Suleimenova <[email protected]>
Co-authored-by: Matt Provost <[email protected]>
Co-authored-by: Abhishek Reddy <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>
Co-authored-by: Sirazh Gabdullin <[email protected]>
Co-authored-by: Manasvini B Suryanarayana <[email protected]>
Co-authored-by: Kroosh <[email protected]>
Co-authored-by: Qingyang(Abby) Hu <[email protected]>
Co-authored-by: Aigerim Suleimenova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(OUI Docs) Combo Box
4 participants