[CCI] Update @svgr/core and @svgr/plugin-svgo dependencies #649

andreymyssak · 2023-03-31T13:31:34Z

Description

Update @svgr/core and @svgr/plugin-svgo dependencies to v6.5.1

Before:

After:

Issues Resolved

#594

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

src/components/icon/assets/accessibility.js

package.json

andreymyssak · 2023-04-01T09:06:00Z

scripts/compile-icons.js

      svgSource,
      {
        plugins: ['@svgr/plugin-svgo', '@svgr/plugin-jsx'],
        svgoConfig: {
          plugins: [
-            { cleanupIDs: false },
-            { prefixIds: false },


For reviewers, prefixIds is not used anywhere in plugins, it makes no sense to disable it, so it has been removed

BSFishy

Looks good. Most likely merging this after #658, as that PR is urgent, so probably going to need to re-compile after that.

joshuarrrr

@andreymyssak This looks great!

Can you please add some before and after screenshots of the icon collection, just as an extra sanity test for UX to review?

joshuarrrr · 2023-04-11T22:58:38Z

I updated the branch with main as per #649 (review)

andreymyssak · 2023-04-12T16:23:52Z

@andreymyssak This looks great!

Can you please add some before and after screenshots of the icon collection, just as an extra sanity test for UX to review?

@joshuarrrr I would like to do this, but there is a broken code in the main branch from #554 and because of that I cannot start the application (see picture below)

@SergeyMyssak has already prepared a PR #657 to fix this.

joshuarrrr · 2023-04-12T17:45:04Z

@andreymyssak Thanks, we'll revert that commit. Stand by.

Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]>

andreymyssak · 2023-04-13T17:17:13Z

@joshuarrrr the PR has been updated, compile-icons command has been performed, "before" and "after" screenshots have been added to the description

joshuarrrr

LGTM

joshuarrrr · 2023-04-28T23:39:07Z

@rednaksi91 Can you be the second approving maintainer?

…nsearch-project#649) Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]>

* Remove beta badge accent color (#99) Signed-off-by: Matt Provost <[email protected]> Signed-off-by: Matt Provost <[email protected]> * OUI combo box refine (#183) * Added a prop clearOnBlur Signed-off-by: AbhishekReddy1127 <[email protected]> * Added example for prop clearOnBlur Signed-off-by: AbhishekReddy1127 <[email protected]> --------- Signed-off-by: AbhishekReddy1127 <[email protected]> * Update Comment List Docs (#252) Signed-off-by: Matt Provost <[email protected]> * Updated the section Collapsable Nav (#330) Signed-off-by: AbhishekReddy1127 <[email protected]> Co-authored-by: Sean Neumann <[email protected]> * Updated the kibana to opensearch_dashboards (#343) Signed-off-by: AbhishekReddy1127 <[email protected]> * Updated the section drag and drop (#514) Signed-off-by: AbhishekReddy1127 <[email protected]> Co-authored-by: Sean Neumann <[email protected]> * Update @svgr/core and @svgr/plugin-svgo (#594) (#649) Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> * Migrate from faker to @faker-js/faker (#594) (#655) Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> * Bump @faker-js/faker to v8 (#594) (#768) Signed-off-by: Andrey Myssak <[email protected]> * change beta to experimental (#383) Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Sean Neumann <[email protected]> * Normalize interlink URL usage (#698) (#720) Signed-off-by: Sergey Myssak <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> * [CCI] Add `useDeprecatedPropWarning` and align with `deprecated` hoc (#762) * Add useDeprecatedPropWarning and align with deprecated hoc (#761) Co-authored-by: Andrey Myssak <[email protected]> Signed-off-by: Sergey Myssak <[email protected]> * Add multiple props to useDeprecatedPropWarning and pass getMessage to deprecatedComponentWarning (#761) Co-authored-by: Andrey Myssak <[email protected]> Signed-off-by: Sergey Myssak <[email protected]> * Use ExclusiveUnion in interfaces (#761) Co-authored-by: Andrey Myssak <[email protected]> Signed-off-by: Sergey Myssak <[email protected]> --------- Signed-off-by: Sergey Myssak <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> * Update the default branch (#584) (#798) Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> * [OuiComboBox] Add docs for icon and revise example for clearOnBlur (#806) Signed-off-by: Miki <[email protected]> * Updated bug issue template (#764) * Update bug issue template Signed-off-by: Sirazh Gabdullin <[email protected]> * Add spacing Signed-off-by: Sirazh Gabdullin <[email protected]> --------- Signed-off-by: Sirazh Gabdullin <[email protected]> * Move OuiBottomBar default inline styles to the CSS file (#693) (#694) Signed-off-by: Sergey Myssak <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> * [CCI] Update react-window and react-virtualized-auto-sizer dependencies (#652) * Update react-window (#594) * Update react-virtualized-auto-sizer (#594) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> --------- Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> * Update dropzone (#594) (#651) Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> * Updated the section Beta badge (#338) Signed-off-by: AbhishekReddy1127 <[email protected]> * Add props and examples for the combobox (#660) Signed-off-by: AbhishekReddy1127 <[email protected]> * Updated the links in the section Markdown Format (#365) Signed-off-by: AbhishekReddy1127 <[email protected]> * Update Notification event page (#549) Signed-off-by: manasvinibs <[email protected]> Co-authored-by: Sean Neumann <[email protected]> * Updated the content in the section Messages and loading (#350) Signed-off-by: AbhishekReddy1127 <[email protected]> * Updated the content in the section suggest (#347) Signed-off-by: AbhishekReddy1127 <[email protected]> * Update affiliation of Andrey and Sergey (#794) Signed-off-by: Matt Provost <[email protected]> * [CCI] Update dependencies (#716) * Update dependencies (#594) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> * Bump @axe-core/puppeteer to v4.6.1 and puppeteer to v19.11.1 Signed-off-by: Andrey Myssak <[email protected]> * Bump react-window, tabbable and rimraf patch versions Signed-off-by: Andrey Myssak <[email protected]> * Bump @svgr/core, @svgr/plugin-svgo and @svgr/plugin-jsx to v8 Signed-off-by: Andrey Myssak <[email protected]> --------- Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> * Replace @elastic/datemath with @opensearch/datemath (#204) * Replace @elastic/datemath with @opensearch/datemath Signed-off-by: Matt Provost <[email protected]> * Clean up Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]> * Bump semver to 7.5.3 (#855) * Bump semver to 7.5.3 Signed-off-by: Matt Provost <[email protected]> * Add resolution to eslint plugin Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]> * Remove Split button from OUI docs (#805) (#812) Signed-off-by: Sergey Myssak <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> * Updated the text in the section ErrorBoundary (#366) Signed-off-by: AbhishekReddy1127 <[email protected]> * Docs site changes (#96) * first change Signed-off-by: Kroosh Crusius <[email protected]> * undoing first change Signed-off-by: Kroosh Crusius <[email protected]> * making a sample change to test commit success or failure Signed-off-by: Kroosh Crusius <[email protected]> * undoes sample change for testing Signed-off-by: Kroosh Crusius <[email protected]> * minor changes for tone, deleted references to starter projects as they are not maintained by OSD Signed-off-by: Kroosh Crusius <[email protected]> * Delete OUI.iml Removing as included accidentally. * Delete oui.iml Removing as included accidentally. * Update getting_started.md Updated link to node version manager to avoid redirect --------- Signed-off-by: Kroosh Crusius <[email protected]> * Update getting_started.md to remove elastic reference and other changes (#502) Signed-off-by: manasvinibs <[email protected]> * Removed GitHub column from all the tables (#371) Signed-off-by: AbhishekReddy1127 <[email protected]> * Updated the content and Icons in the section CssUtilityClasses (#368) Signed-off-by: AbhishekReddy1127 <[email protected]> * Delete Kibana reference in commands (#535) * Delete kibana reference in commands Signed-off-by: abbyhu2000 <[email protected]> * Change the tgz naming to opensearch Signed-off-by: abbyhu2000 <[email protected]> * Updated doc site link and github reference Signed-off-by: abbyhu2000 <[email protected]> * Change URL to only include domain Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> Co-authored-by: Sean Neumann <[email protected]> * fixed invalid link in FAQ.md (#751) Signed-off-by: Aigerim Suleimenova <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]> Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Sergey Myssak <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: manasvinibs <[email protected]> Signed-off-by: Kroosh Crusius <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Aigerim Suleimenova <[email protected]> Co-authored-by: Matt Provost <[email protected]> Co-authored-by: Abhishek Reddy <[email protected]> Co-authored-by: Sean Neumann <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> Co-authored-by: Sirazh Gabdullin <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Kroosh <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Aigerim Suleimenova <[email protected]>

andreymyssak requested a review from a team as a code owner March 31, 2023 13:31

andreymyssak mentioned this pull request Mar 31, 2023

[CCI] Update dependencies #609

Closed

6 tasks

BSFishy reviewed Mar 31, 2023

View reviewed changes

src/components/icon/assets/accessibility.js Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

andreymyssak force-pushed the 594-update-svgr branch from bfebfa8 to c3f371a Compare April 1, 2023 07:07

andreymyssak commented Apr 1, 2023

View reviewed changes

BSFishy previously approved these changes Apr 5, 2023

View reviewed changes

ashwin-pc added the CCI College Contributor Initiative label Apr 7, 2023

joshuarrrr reviewed Apr 11, 2023

View reviewed changes

joshuarrrr requested review from seanneumann, AMoo-Miki, rednaksi91, KrooshalUX and bandinib-amzn as code owners April 11, 2023 22:58

andreymyssak dismissed BSFishy’s stale review via e38cab0 April 13, 2023 16:56

andreymyssak force-pushed the 594-update-svgr branch from 08d49ce to e38cab0 Compare April 13, 2023 16:56

Update @svgr/core and @svgr/plugin-svgo (opensearch-project#594)

1ddfdee

Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]>

andreymyssak force-pushed the 594-update-svgr branch from e38cab0 to 1ddfdee Compare April 13, 2023 17:02

andreymyssak mentioned this pull request Apr 17, 2023

Audit outdated dependencies #594

Open

joshuarrrr approved these changes Apr 25, 2023

View reviewed changes

BSFishy approved these changes Apr 25, 2023

View reviewed changes

rednaksi91 approved these changes May 1, 2023

View reviewed changes

bandinib-amzn approved these changes May 1, 2023

View reviewed changes

rednaksi91 merged commit 57aaf66 into opensearch-project:main May 2, 2023

AMoo-Miki pushed a commit to AMoo-Miki/oui that referenced this pull request Jul 2, 2023

Update @svgr/core and @svgr/plugin-svgo (opensearch-project#594) (ope…

6043f7c

…nsearch-project#649) Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]>

AMoo-Miki mentioned this pull request Jul 2, 2023

[Manual][backport 1.x] Several changes #872

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CCI] Update @svgr/core and @svgr/plugin-svgo dependencies #649

[CCI] Update @svgr/core and @svgr/plugin-svgo dependencies #649

andreymyssak commented Mar 31, 2023 •

edited

Loading

andreymyssak Apr 1, 2023

BSFishy left a comment

joshuarrrr left a comment

joshuarrrr commented Apr 11, 2023

andreymyssak commented Apr 12, 2023

joshuarrrr commented Apr 12, 2023

andreymyssak commented Apr 13, 2023

joshuarrrr left a comment

joshuarrrr commented Apr 28, 2023

[CCI] Update @svgr/core and @svgr/plugin-svgo dependencies #649

[CCI] Update @svgr/core and @svgr/plugin-svgo dependencies #649

Conversation

andreymyssak commented Mar 31, 2023 • edited Loading

Description

Issues Resolved

Check List

andreymyssak Apr 1, 2023

Choose a reason for hiding this comment

BSFishy left a comment

Choose a reason for hiding this comment

joshuarrrr left a comment

Choose a reason for hiding this comment

joshuarrrr commented Apr 11, 2023

andreymyssak commented Apr 12, 2023

joshuarrrr commented Apr 12, 2023

andreymyssak commented Apr 13, 2023

joshuarrrr left a comment

Choose a reason for hiding this comment

joshuarrrr commented Apr 28, 2023

andreymyssak commented Mar 31, 2023 •

edited

Loading