Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Notification event page #549

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Update Notification event page #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
013223a
Update Notification event page
manasvinibs Mar 1, 2023
12cbed0
Merge branch 'main' into manasvinibs/Issue-88
seanneumann Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src-docs/src/views/notification_event/notification_event.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ export default () => {
<OuiNotificationEvent
id="report"
type="Report"
iconType="logoKibana"
iconAriaLabel="Kibana"
time="1 min ago"
title="[Error Monitoring Report] is generated"
primaryAction="Download"
Expand Down
10 changes: 2 additions & 8 deletions src-docs/src/views/notification_event/notification_event_example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ const notificationsFeedHtml = renderToHtml(NotificationsFeed);
const notificationEventSnippet = `<OuiNotificationEvent
id={id}
type="Alert"
iconType= "logoMaps"
iconAriaLabel="Maps"
time={time}
title={title}
isRead={isRead}
Expand Down Expand Up @@ -82,8 +80,8 @@ const notificationEvents = events.map((event) => (

export const NotificationEventExample = {
title: 'Notification event',
beta: true,
isNew: true,
beta: false,
isNew: false,
intro: (
<OuiText>
<p>
Expand Down Expand Up @@ -159,10 +157,6 @@ export const NotificationEventExample = {
<OuiCode>onRead</OuiCode> to allow users to toggle between read
and unread states.
</li>
<li>
<OuiCode>iconType</OuiCode>: Display an icon or logo to help
users quickly identify where the event originated.
</li>
<li>
<OuiCode>type</OuiCode> (required): Shows inside a badge
denoting what type of event it is. Use in conjunction with{' '}
Expand Down
6 changes: 0 additions & 6 deletions src-docs/src/views/notification_event/notification_event_flexible.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ const notificationEventsData = [
{
id: 'report',
type: 'Report',
iconType: 'logoKibana',
iconAriaLabel: 'Kibana',
time: '1 min ago',
title: '[Error Monitoring Report] is generated',
primaryAction: 'Download',
Expand All @@ -34,9 +32,7 @@ const notificationEventsData = [
{
id: 'alert',
type: 'Alert',
iconType: 'logoMaps',
severity: 'Warning',
iconAriaLabel: 'Maps',
badgeColor: 'warning',
time: '2 min ago',
title: '[Maps] Geo Alert',
Expand All @@ -51,8 +47,6 @@ const notificationEventsData = [
{
id: 'news',
type: 'News',
iconType: 'logoElastic',
iconAriaLabel: 'Elastic',
time: '3 min ago',
badgeColor: 'accent',
title: 'Search more, spend less',
Expand Down
20 changes: 5 additions & 15 deletions src-docs/src/views/notification_event/notification_event_props_methods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import React from 'react';
import { OuiPanel } from '../../../../src/components/panel';
import { OuiBadge } from '../../../../src/components/badge';
import { OuiButtonIcon } from '../../../../src/components/button';
import { OuiIcon } from '../../../../src/components/icon';

const CircleIndicator = ({ name }) => (
<span className="guideDemo__notificationEventCircleIndicator">{name}</span>
Expand All @@ -35,17 +34,8 @@ export default () => {
aria-hidden="true"
/>
</div>

<div className="guideDemo__notificationEventHighlight">
<CircleIndicator name="B" />
<OuiIcon
type="logoElastic"
className="guideDemo__notificationEventIcon"
/>
</div>

<div className="guideDemo__notificationEventBadge guideDemo__notificationEventHighlight">
<CircleIndicator name="C" />
<CircleIndicator name="B" />
<OuiBadge
className="ouiNotificationEventMeta__badge"
color="hollow">
Expand All @@ -54,12 +44,12 @@ export default () => {
</div>

<div className="guideDemo__notificationEventHighlight">
<CircleIndicator name="D" />
<CircleIndicator name="C" />
time
</div>

<div className="guideDemo__notificationEventHighlight">
<CircleIndicator name="E" />
<CircleIndicator name="D" />
<OuiButtonIcon
aria-hidden="true"
iconType="boxesVertical"
Expand All @@ -69,10 +59,10 @@ export default () => {
</div>
<div className="guideDemo__notificationEventSections">
<div className="guideDemo__notificationEventHighlight">
<CircleIndicator name="F" /> <span>title</span>
<CircleIndicator name="E" /> <span>title</span>
</div>
<div className="guideDemo__notificationEventHighlight">
<CircleIndicator name="G" /> <span>messages</span>
<CircleIndicator name="F" /> <span>messages</span>
</div>
<div className="guideDemo__notificationEventHighlight">
<CircleIndicator name="G" /> <span>primaryAction</span>
Expand Down
10 changes: 0 additions & 10 deletions src-docs/src/views/notification_event/notifications_feed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ const notificationEventsData = [
id: 'alert-01',
type: 'Alert',
severity: 'Warning',
iconType: 'logoMaps',
iconAriaLabel: 'Maps',
badgeColor: 'warning',
time: '1 min ago',
title: '[Maps] Geo Alert',
Expand All @@ -36,8 +34,6 @@ const notificationEventsData = [
{
id: 'report-01',
type: 'Report',
iconType: 'logoKibana',
iconAriaLabel: 'Kibana',
time: '3 min ago',
title: '[Error Monitoring Report] is generated',
primaryAction: 'Download',
Expand All @@ -52,8 +48,6 @@ const notificationEventsData = [
{
id: 'news-01',
type: 'News',
iconType: 'logoElastic',
iconAriaLabel: 'Elastic',
time: '6 min ago',
badgeColor: 'accent',
title: 'Search more, spend less',
Expand All @@ -67,8 +61,6 @@ const notificationEventsData = [
id: 'alert-02',
type: 'Alert',
severity: 'Critical',
iconType: 'logoKibana',
iconAriaLabel: 'Kibana',
badgeColor: 'danger',
time: '8 min ago',
title: 'Index Threshold Alert',
Expand All @@ -81,8 +73,6 @@ const notificationEventsData = [
{
id: 'background-search-01',
type: 'Background Search',
iconType: 'logoKibana',
iconAriaLabel: 'Kibana',
time: '10 min ago',
title: '[Flights] Flight Count and Average Ticket Price',
messages: ['The request completed at 12:32:33 GMT+4'],
Expand Down