Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for Dev Tools multple data source integration feature #3653

Merged
merged 110 commits into from
Apr 25, 2023
Merged

Add documentation for Dev Tools multple data source integration feature #3653

merged 110 commits into from
Apr 25, 2023

Conversation

vagimeli
Copy link
Contributor

@vagimeli vagimeli commented Apr 3, 2023 •
edited
Loading

Description

Add new documentation on multidata source Dev Tools integration and create new TOC section Dev Tools

Issues Resolved

#3452

opensearch-project/OpenSearch-Dashboards#3577

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vagimeli vagimeli requested a review from a team as a code owner April 3, 2023 20:12
@vagimeli vagimeli self-assigned this Apr 3, 2023
@vagimeli vagimeli added 2 - In progress Issue/PR: The issue or PR is in progress. Sev2 High-medium priority. Upcoming release or incorrect information. dashboards v2.7.0 labels Apr 3, 2023
@vagimeli vagimeli added this to the v2.7 milestone Apr 3, 2023
@vagimeli vagimeli linked an issue Apr 3, 2023 that may be closed by this pull request
[DOC] OSD Multiple Datasource integration features for GA release #3452
Closed
4 tasks
@zhongnansu zhongnansu self-requested a review April 5, 2023 20:14
@vagimeli
Copy link
Contributor Author

vagimeli commented Apr 5, 2023

@zhongnansu Please review this draft and make suggestions. Is any key information missing?

zhongnansu
zhongnansu approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm. Left 1 non blocking comment. Thanks

_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
@vagimeli
Copy link
Contributor Author

vagimeli commented Apr 7, 2023

Overall lgtm. Left 1 non blocking comment. Thanks

@zhongnansu Revised to add steps 1 and 2 re: modifying YAML file

@vagimeli vagimeli added 4 - Doc review PR: Doc review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Apr 7, 2023
cwillum
cwillum approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just suggestions.

_dashboards/dev-tools/index-dev.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
ariamarble
ariamarble approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@ariamarble ariamarble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise looks good to me after Chris's comments

@vagimeli vagimeli added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Apr 12, 2023
@kolchfa-aws kolchfa-aws removed this from the v2.7 milestone Apr 17, 2023
natebower
natebower reviewed Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli Please see my comments and changes and let me know if you have any questions. Thanks!

_dashboards/dev-tools/index-dev.md Outdated Show resolved Hide resolved
_dashboards/dev-tools/index-dev.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
@vagimeli vagimeli removed the 5 - Editorial review PR: Editorial review in progress label Apr 25, 2023
vagimeli added 18 commits April 25, 2023 12:22
@vagimeli
Revert "Fix put rollup job api documentation (#3637)"
2a26593 
This reverts commit 2d74967.
@vagimeli
Revert "Add documentation for Searchable Snapshots GA release (#3462)"
81d6819 
This reverts commit 7513270.
@vagimeli
Revert "Updates Trace Analytics overview (#3727)"
100aebc 
This reverts commit 8bf381b.
@vagimeli
Revert "Add auto-truncation to pretrained models (#3756)"
06806c8 
This reverts commit 8dac80f.
@vagimeli
Revert "Use the modified dates of files in the sitemap (#3774)"
370eec9 
This reverts commit 5bd95aa.
@vagimeli
Revert "Add editorial to maintainers and codeowners (#3840)"
e974146 
This reverts commit 52355fb.
@vagimeli
Revert "Add list to map processor (#3806)"
6b7dc02 
This reverts commit 02c8c15.
@vagimeli
Revert "Add maximum allowed monitor number. (#3732)"
f12309c 
This reverts commit d5358ce.
@vagimeli
Revert "Update java client version (#3753)"
66f90a8 
This reverts commit 172b472.
@vagimeli
Revert "Add Trace peer forwarder doc. (#3238)"
c896b2c 
This reverts commit 81ef3d1.
@vagimeli
Revert "Add filtering data in maps doc. (#3640)"
08230dc 
This reverts commit 3c2b47b.
@vagimeli
Revert "Add documentation for wait_for_completion API (#3458)"
cb8f206 
This reverts commit 85a5aa6.
@vagimeli
Revert "Add config parameters for traced models (#3456)"
7f929dd 
This reverts commit cf9e0c6.
@vagimeli
Revert "Add additonal Snapshot Restore (#3783)"
92a5da4 
This reverts commit 1b7f6eb.
@vagimeli
Revert "Add documentation for dynamic configuration of tenancy in Das…
1a46c3b 
…hboards (#3694)"

This reverts commit c490b20.
@vagimeli
Revert "Add documentation for segment replication GA release (#3461)"
7c0e8f4 
This reverts commit 0d17e7d.
@vagimeli
Merge branch 'main' into issue-3452
3f2cfe0
@vagimeli
Resolve merge conflicts
d5a2ef8 
Signed-off-by: vagimeli <[email protected]>
@vagimeli vagimeli merged commit 74902a2 into main Apr 25, 2023
@vagimeli vagimeli deleted the issue-3452 branch April 25, 2023 21:06
@hdhalter hdhalter added the release-notes PR: Include this PR in the automated release notes label Apr 26, 2023
@vagimeli vagimeli added Closed - Complete Issue: Work is done and associated PRs closed and removed 6 - Done but waiting to merge PR: The work is done and ready to merge labels Apr 27, 2023
@vagimeli vagimeli changed the title [DOC] Add multidata source Dev Tools integration [DOC] Add documentation for Dev Tools multidata source integration feature Apr 27, 2023
Naarcha-AWS pushed a commit that referenced this pull request Apr 27, 2023
@vagimeli @Naarcha-AWS
[DOC] Add multidata source Dev Tools integration (#3653)
5da3a8c 
* Create new doc site section Dev Tools

Signed-off-by: vagimeli <[email protected]>
@hdhalter hdhalter changed the title [DOC] Add documentation for Dev Tools multidata source integration feature Add documentation for Dev Tools multple idata source integration feature May 2, 2023
@hdhalter hdhalter changed the title Add documentation for Dev Tools multple idata source integration feature Add documentation for Dev Tools multple data source integration feature May 2, 2023
vagimeli added a commit that referenced this pull request May 4, 2023
@vagimeli
[DOC] Add multidata source Dev Tools integration (#3653)
4bd885d 
* Create new doc site section Dev Tools

Signed-off-by: vagimeli <[email protected]>
vagimeli added a commit that referenced this pull request May 4, 2023
@vagimeli
Revert "[DOC] Add multidata source Dev Tools integration (#3653)"
28218cf 
This reverts commit 4bd885d.
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
@vagimeli @harshavamsi
[DOC] Add multidata source Dev Tools integration (opensearch-project#…
5c4b622 
…3653)

* Create new doc site section Dev Tools

Signed-off-by: vagimeli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebower natebower natebower left review comments

@ariamarble ariamarble ariamarble approved these changes

@cwillum cwillum cwillum approved these changes

@zhongnansu zhongnansu zhongnansu approved these changes

@carolxob carolxob Awaiting requested review from carolxob

@hdhalter hdhalter Awaiting requested review from hdhalter

@JeffHuss JeffHuss Awaiting requested review from JeffHuss

@kolchfa-aws kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@ananzh ananzh Awaiting requested review from ananzh

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

Assignees

@vagimeli vagimeli

Labels
Closed - Complete Issue: Work is done and associated PRs closed dashboards release-notes PR: Include this PR in the automated release notes Sev2 High-medium priority. Upcoming release or incorrect information. v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] OSD Multiple Datasource integration features for GA release