Add auto-truncation to pretrained models #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
added
3 - Tech review
dhrubo-os
reviewed
Apr 12, 2023
| | `sentence-transformers/all-distilroberta-v1` | 768-dimensional dense vector space. | No | - [model_url](https://artifacts.opensearch.org/models/ml-models/huggingface/sentence-transformers/all-distilroberta-v1/1.0.1/torch_script/sentence-transformers_all-distilroberta-v1-1.0.1-torch_script.zip)<br>- [config_url](https://artifacts.opensearch.org/models/ml-models/huggingface/sentence-transformers/all-distilroberta-v1/1.0.1/torch_script/config.json) | - [model_url](https://artifacts.opensearch.org/models/ml-models/huggingface/sentence-transformers/all-distilroberta-v1/1.0.1/onnx/sentence-transformers_all-distilroberta-v1-1.0.1-onnx.zip)<br>- [config_url](https://artifacts.opensearch.org/models/ml-models/huggingface/sentence-transformers/all-distilroberta-v1/1.0.1/onnx/config.json) | |
There was a problem hiding this comment.
Auto-truncation value should be Yes for sentence-transformers/all-distilroberta-v1 model
Signed-off-by: Naarcha-AWS <[email protected]>
dhrubo-os
approved these changes
Apr 12, 2023
Naarcha-AWS
added
4 - Doc review
JeffHuss
approved these changes
Apr 12, 2023
ylwu-amzn
reviewed
Apr 12, 2023
|
|
||
| | **Model name** | **Vector dimensions** | **Torchscript artifact** | **ONNX artifact** | | ||
| | **Model name** | **Vector dimensions** | **Auto-truncation** | **Torchscript artifact** | **ONNX artifact** | |
There was a problem hiding this comment.
Should we also add max token size for truncation? @dhrubo-os
There was a problem hiding this comment.
Discussed offline. We will not add max token size for now.
vagimeli
approved these changes
Apr 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Add auto-truncation to pretrained models Signed-off-by: Naarcha-AWS <[email protected]> * Fix review feedback Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit 08a4128) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Add auto-truncation to pretrained models * Fix review feedback --------- (cherry picked from commit 08a4128) Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli
pushed a commit
that referenced
this pull request
Apr 25, 2023
* Add auto-truncation to pretrained models Signed-off-by: Naarcha-AWS <[email protected]> * Fix review feedback Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Naarcha-AWS <[email protected]>
vagimeli
pushed a commit
that referenced
this pull request
May 4, 2023
* Add auto-truncation to pretrained models Signed-off-by: Naarcha-AWS <[email protected]> * Fix review feedback Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Naarcha-AWS <[email protected]>
harshavamsi
pushed a commit
to harshavamsi/documentation-website
that referenced
this pull request
Oct 31, 2023
* Add auto-truncation to pretrained models Signed-off-by: Naarcha-AWS <[email protected]> * Fix review feedback Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Naarcha-AWS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3652
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.