Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for wait_for_completion API #3458

Merged
merged 16 commits into from
Apr 20, 2023
Merged

Add documentation for wait_for_completion API #3458

merged 16 commits into from
Apr 20, 2023

Conversation

ariamarble
Copy link
Contributor

Description

Adds documentation for wait_for_completion API

Issues Resolved

fixes #3186

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ariamarble ariamarble requested a review from a team as a code owner March 15, 2023 17:54
@ariamarble ariamarble self-assigned this Mar 15, 2023
@ariamarble ariamarble added API 2 - In progress Issue/PR: The issue or PR is in progress. index-management release-notes PR: Include this PR in the automated release notes v2.7.0 labels Mar 15, 2023
@ariamarble
Copy link
Contributor Author

waiting on UI screenshots and UI steps

Signed-off-by: ariamarble <[email protected]>
Signed-off-by: ariamarble <[email protected]>
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion.

Signed-off-by: ariamarble <[email protected]>
@ariamarble ariamarble added 5 - Editorial review PR: Editorial review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Apr 20, 2023
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariamarble Please see my changes and apply to each duplicate instance. Let me know if you have any questions. Thanks!

_api-reference/index-apis/clone.md Outdated Show resolved Hide resolved
_api-reference/index-apis/clone.md Outdated Show resolved Hide resolved
@natebower natebower removed the 5 - Editorial review PR: Editorial review in progress label Apr 20, 2023
ariamarble and others added 2 commits April 20, 2023 08:36
@ariamarble ariamarble merged commit 872af11 into main Apr 20, 2023
vagimeli pushed a commit that referenced this pull request Apr 25, 2023
* Add documentation for wait_for_completion API

Signed-off-by: ariamarble <[email protected]>

* draft update

Signed-off-by: ariamarble <[email protected]>

* small comment

Signed-off-by: ariamarble <[email protected]>

* page and toc updates

Signed-off-by: ariamarble <[email protected]>

* page updates

Signed-off-by: ariamarble <[email protected]>

* final changes

Signed-off-by: ariamarble <[email protected]>

* doc review changes

Signed-off-by: ariamarble <[email protected]>

* link to task api

Signed-off-by: ariamarble <[email protected]>

* further doc review updates

Signed-off-by: ariamarble <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>

* made editorial changes

Signed-off-by: ariamarble <[email protected]>

---------

Signed-off-by: ariamarble <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
vagimeli added a commit that referenced this pull request Apr 25, 2023
vagimeli pushed a commit that referenced this pull request May 4, 2023
* Add documentation for wait_for_completion API

Signed-off-by: ariamarble <[email protected]>

* draft update

Signed-off-by: ariamarble <[email protected]>

* small comment

Signed-off-by: ariamarble <[email protected]>

* page and toc updates

Signed-off-by: ariamarble <[email protected]>

* page updates

Signed-off-by: ariamarble <[email protected]>

* final changes

Signed-off-by: ariamarble <[email protected]>

* doc review changes

Signed-off-by: ariamarble <[email protected]>

* link to task api

Signed-off-by: ariamarble <[email protected]>

* further doc review updates

Signed-off-by: ariamarble <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>

* made editorial changes

Signed-off-by: ariamarble <[email protected]>

---------

Signed-off-by: ariamarble <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
vagimeli added a commit that referenced this pull request May 4, 2023
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
* Add documentation for wait_for_completion API

Signed-off-by: ariamarble <[email protected]>

* draft update

Signed-off-by: ariamarble <[email protected]>

* small comment

Signed-off-by: ariamarble <[email protected]>

* page and toc updates

Signed-off-by: ariamarble <[email protected]>

* page updates

Signed-off-by: ariamarble <[email protected]>

* final changes

Signed-off-by: ariamarble <[email protected]>

* doc review changes

Signed-off-by: ariamarble <[email protected]>

* link to task api

Signed-off-by: ariamarble <[email protected]>

* further doc review updates

Signed-off-by: ariamarble <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>

* made editorial changes

Signed-off-by: ariamarble <[email protected]>

---------

Signed-off-by: ariamarble <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
@hdhalter hdhalter deleted the issue3186 branch March 28, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API index-management release-notes PR: Include this PR in the automated release notes v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add wait_for_completion parameter to resize&open&forcemerge APIs
4 participants