-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for wait_for_completion API #3458
Conversation
Signed-off-by: ariamarble <[email protected]>
waiting on UI screenshots and UI steps |
Signed-off-by: ariamarble <[email protected]>
Signed-off-by: ariamarble <[email protected]>
Signed-off-by: ariamarble <[email protected]>
Signed-off-by: ariamarble <[email protected]>
Signed-off-by: ariamarble <[email protected]>
Signed-off-by: ariamarble <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a suggestion.
Signed-off-by: ariamarble <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ariamarble Please see my changes and apply to each duplicate instance. Let me know if you have any questions. Thanks!
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: ariamarble <[email protected]>
* Add documentation for wait_for_completion API Signed-off-by: ariamarble <[email protected]> * draft update Signed-off-by: ariamarble <[email protected]> * small comment Signed-off-by: ariamarble <[email protected]> * page and toc updates Signed-off-by: ariamarble <[email protected]> * page updates Signed-off-by: ariamarble <[email protected]> * final changes Signed-off-by: ariamarble <[email protected]> * doc review changes Signed-off-by: ariamarble <[email protected]> * link to task api Signed-off-by: ariamarble <[email protected]> * further doc review updates Signed-off-by: ariamarble <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> * made editorial changes Signed-off-by: ariamarble <[email protected]> --------- Signed-off-by: ariamarble <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
* Add documentation for wait_for_completion API Signed-off-by: ariamarble <[email protected]> * draft update Signed-off-by: ariamarble <[email protected]> * small comment Signed-off-by: ariamarble <[email protected]> * page and toc updates Signed-off-by: ariamarble <[email protected]> * page updates Signed-off-by: ariamarble <[email protected]> * final changes Signed-off-by: ariamarble <[email protected]> * doc review changes Signed-off-by: ariamarble <[email protected]> * link to task api Signed-off-by: ariamarble <[email protected]> * further doc review updates Signed-off-by: ariamarble <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> * made editorial changes Signed-off-by: ariamarble <[email protected]> --------- Signed-off-by: ariamarble <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
* Add documentation for wait_for_completion API Signed-off-by: ariamarble <[email protected]> * draft update Signed-off-by: ariamarble <[email protected]> * small comment Signed-off-by: ariamarble <[email protected]> * page and toc updates Signed-off-by: ariamarble <[email protected]> * page updates Signed-off-by: ariamarble <[email protected]> * final changes Signed-off-by: ariamarble <[email protected]> * doc review changes Signed-off-by: ariamarble <[email protected]> * link to task api Signed-off-by: ariamarble <[email protected]> * further doc review updates Signed-off-by: ariamarble <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> * made editorial changes Signed-off-by: ariamarble <[email protected]> --------- Signed-off-by: ariamarble <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
Description
Adds documentation for wait_for_completion API
Issues Resolved
fixes #3186
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.