Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering data in maps doc #3640

Merged
merged 22 commits into from
Apr 18, 2023
Merged

Add filtering data in maps doc #3640

merged 22 commits into from
Apr 18, 2023

Conversation

carolxob
Copy link
Contributor

Description

Adds document describing how to filter data in maps by drawing shapes (boundaries).

Issues Resolved

Closes #2543

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@carolxob carolxob requested a review from a team as a code owner March 30, 2023 16:38
@carolxob carolxob self-assigned this Mar 30, 2023
@carolxob carolxob requested a review from vagimeli April 6, 2023 21:44
Copy link
Collaborator

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carolxob This is going in a good direction. I gave some feedback on this first-pass draft. Once the SME reviews, you're welcome to tag me for a more thorough review.

_dashboards/visualize/maps.md Outdated Show resolved Hide resolved
_dashboards/visualize/maps.md Outdated Show resolved Hide resolved
_dashboards/visualize/maps.md Outdated Show resolved Hide resolved
_dashboards/visualize/maps.md Outdated Show resolved Hide resolved
_dashboards/visualize/maps.md Outdated Show resolved Hide resolved
_dashboards/visualize/maps.md Outdated Show resolved Hide resolved
_dashboards/visualize/maps.md Outdated Show resolved Hide resolved
_dashboards/visualize/maps.md Outdated Show resolved Hide resolved
_dashboards/visualize/maps.md Outdated Show resolved Hide resolved
_dashboards/visualize/maps.md Outdated Show resolved Hide resolved
@kolchfa-aws kolchfa-aws self-requested a review April 7, 2023 18:22
carolxob and others added 8 commits April 10, 2023 11:34
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
@kolchfa-aws kolchfa-aws removed their request for review April 17, 2023 16:19
Copy link
Collaborator

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

_dashboards/visualize/maps.md Outdated Show resolved Hide resolved
Signed-off-by: Fanit Kolchina <[email protected]>
@carolxob carolxob added the 5 - Editorial review PR: Editorial review in progress label Apr 18, 2023
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carolxob Please see my changes (no comments on this one) and let me know if you have any questions. Thanks!

_dashboards/visualize/maps.md Outdated Show resolved Hide resolved
_dashboards/visualize/maps.md Outdated Show resolved Hide resolved
_dashboards/visualize/maps.md Outdated Show resolved Hide resolved
_dashboards/visualize/maps.md Outdated Show resolved Hide resolved
@natebower natebower removed the 5 - Editorial review PR: Editorial review in progress label Apr 18, 2023
@carolxob carolxob merged commit 58cd3e8 into main Apr 18, 2023
@kolchfa-aws kolchfa-aws added v2.7.0 release-notes PR: Include this PR in the automated release notes labels Apr 25, 2023
vagimeli pushed a commit that referenced this pull request Apr 25, 2023
* Add filtering data in maps doc.

Signed-off-by: carolxob <[email protected]>

* Updates to procedural steps for drawing shapes to filter data.

Signed-off-by: carolxob <[email protected]>

* Added a question.

Signed-off-by: carolxob <[email protected]>

* Minor content updates based on meeting with UX.

Signed-off-by: carolxob <[email protected]>

* Major content additions after viewing demo.

Signed-off-by: carolxob <[email protected]>

* Major content updates based on demo.

Signed-off-by: carolxob <[email protected]>

* Content edits based on doc review feedback/

Signed-off-by: carolxob <[email protected]>

* Edits from tech review feedback.

Signed-off-by: carolxob <[email protected]>

* Incorporated feedback from technical review.

Signed-off-by: carolxob <[email protected]>

* Updates from tech review feedback.

Signed-off-by: carolxob <[email protected]>

* Content updates.

Signed-off-by: carolxob <[email protected]>

* Minor update.

Signed-off-by: carolxob <[email protected]>

* Reconfigured the filter section

Signed-off-by: Fanit Kolchina <[email protected]>

* Minor rewording

Signed-off-by: Fanit Kolchina <[email protected]>

* Rewording

Signed-off-by: Fanit Kolchina <[email protected]>

* Fixes issue 3712 - adding labels to document layers

Signed-off-by: Fanit Kolchina <[email protected]>

* Reorders pages to accommodate the maps stats API

Signed-off-by: Fanit Kolchina <[email protected]>

* Implemented doc review comments

Signed-off-by: Fanit Kolchina <[email protected]>

* Update _dashboards/visualize/maps.md

Co-authored-by: Nathan Bower <[email protected]>

* Update _dashboards/visualize/maps.md

Co-authored-by: Nathan Bower <[email protected]>

* Update _dashboards/visualize/maps.md

Co-authored-by: Nathan Bower <[email protected]>

* Update _dashboards/visualize/maps.md

Co-authored-by: Nathan Bower <[email protected]>

---------

Signed-off-by: carolxob <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
vagimeli added a commit that referenced this pull request Apr 25, 2023
@kolchfa-aws kolchfa-aws changed the title Add filtering data in maps doc. Add filtering data in maps doc May 2, 2023
vagimeli pushed a commit that referenced this pull request May 4, 2023
* Add filtering data in maps doc.

Signed-off-by: carolxob <[email protected]>

* Updates to procedural steps for drawing shapes to filter data.

Signed-off-by: carolxob <[email protected]>

* Added a question.

Signed-off-by: carolxob <[email protected]>

* Minor content updates based on meeting with UX.

Signed-off-by: carolxob <[email protected]>

* Major content additions after viewing demo.

Signed-off-by: carolxob <[email protected]>

* Major content updates based on demo.

Signed-off-by: carolxob <[email protected]>

* Content edits based on doc review feedback/

Signed-off-by: carolxob <[email protected]>

* Edits from tech review feedback.

Signed-off-by: carolxob <[email protected]>

* Incorporated feedback from technical review.

Signed-off-by: carolxob <[email protected]>

* Updates from tech review feedback.

Signed-off-by: carolxob <[email protected]>

* Content updates.

Signed-off-by: carolxob <[email protected]>

* Minor update.

Signed-off-by: carolxob <[email protected]>

* Reconfigured the filter section

Signed-off-by: Fanit Kolchina <[email protected]>

* Minor rewording

Signed-off-by: Fanit Kolchina <[email protected]>

* Rewording

Signed-off-by: Fanit Kolchina <[email protected]>

* Fixes issue 3712 - adding labels to document layers

Signed-off-by: Fanit Kolchina <[email protected]>

* Reorders pages to accommodate the maps stats API

Signed-off-by: Fanit Kolchina <[email protected]>

* Implemented doc review comments

Signed-off-by: Fanit Kolchina <[email protected]>

* Update _dashboards/visualize/maps.md

Co-authored-by: Nathan Bower <[email protected]>

* Update _dashboards/visualize/maps.md

Co-authored-by: Nathan Bower <[email protected]>

* Update _dashboards/visualize/maps.md

Co-authored-by: Nathan Bower <[email protected]>

* Update _dashboards/visualize/maps.md

Co-authored-by: Nathan Bower <[email protected]>

---------

Signed-off-by: carolxob <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
vagimeli added a commit that referenced this pull request May 4, 2023
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
* Add filtering data in maps doc.

Signed-off-by: carolxob <[email protected]>

* Updates to procedural steps for drawing shapes to filter data.

Signed-off-by: carolxob <[email protected]>

* Added a question.

Signed-off-by: carolxob <[email protected]>

* Minor content updates based on meeting with UX.

Signed-off-by: carolxob <[email protected]>

* Major content additions after viewing demo.

Signed-off-by: carolxob <[email protected]>

* Major content updates based on demo.

Signed-off-by: carolxob <[email protected]>

* Content edits based on doc review feedback/

Signed-off-by: carolxob <[email protected]>

* Edits from tech review feedback.

Signed-off-by: carolxob <[email protected]>

* Incorporated feedback from technical review.

Signed-off-by: carolxob <[email protected]>

* Updates from tech review feedback.

Signed-off-by: carolxob <[email protected]>

* Content updates.

Signed-off-by: carolxob <[email protected]>

* Minor update.

Signed-off-by: carolxob <[email protected]>

* Reconfigured the filter section

Signed-off-by: Fanit Kolchina <[email protected]>

* Minor rewording

Signed-off-by: Fanit Kolchina <[email protected]>

* Rewording

Signed-off-by: Fanit Kolchina <[email protected]>

* Fixes issue 3712 - adding labels to document layers

Signed-off-by: Fanit Kolchina <[email protected]>

* Reorders pages to accommodate the maps stats API

Signed-off-by: Fanit Kolchina <[email protected]>

* Implemented doc review comments

Signed-off-by: Fanit Kolchina <[email protected]>

* Update _dashboards/visualize/maps.md

Co-authored-by: Nathan Bower <[email protected]>

* Update _dashboards/visualize/maps.md

Co-authored-by: Nathan Bower <[email protected]>

* Update _dashboards/visualize/maps.md

Co-authored-by: Nathan Bower <[email protected]>

* Update _dashboards/visualize/maps.md

Co-authored-by: Nathan Bower <[email protected]>

---------

Signed-off-by: carolxob <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
@vagimeli vagimeli assigned vagimeli and unassigned carolxob Nov 8, 2023
@hdhalter hdhalter deleted the filter-maps branch March 28, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes PR: Include this PR in the automated release notes v2.7.0 visualizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add filter by drawing boundary on Maps
5 participants