-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maximum allowed monitor number. #3732
Conversation
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small formatting suggestion, otherwise LGTM.
Co-authored-by: Melissa Vagi <[email protected]>
Signed-off-by: carolxob <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carolxob Please see my comments and changes and tag me once addressed. Thanks!
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
@natebower This is ready for review. Thanks! |
Signed-off-by: carolxob <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add maximum allowed monitor number. Signed-off-by: carolxob <[email protected]> * Added note to comment on in GitHub. Signed-off-by: carolxob <[email protected]> * Update _observing-your-data/alerting/monitors.md Co-authored-by: Melissa Vagi <[email protected]> * Edits from doc review incorporated. Signed-off-by: carolxob <[email protected]> * Update _observing-your-data/alerting/monitors.md Co-authored-by: Nathan Bower <[email protected]> * Trying to commit. Signed-off-by: carolxob <[email protected]> * Minor adjustements to commit. Signed-off-by: carolxob <[email protected]> * Corrected per query monitor phrasing. Signed-off-by: carolxob <[email protected]> --------- Signed-off-by: carolxob <[email protected]> Co-authored-by: Melissa Vagi <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
* Add maximum allowed monitor number. Signed-off-by: carolxob <[email protected]> * Added note to comment on in GitHub. Signed-off-by: carolxob <[email protected]> * Update _observing-your-data/alerting/monitors.md Co-authored-by: Melissa Vagi <[email protected]> * Edits from doc review incorporated. Signed-off-by: carolxob <[email protected]> * Update _observing-your-data/alerting/monitors.md Co-authored-by: Nathan Bower <[email protected]> * Trying to commit. Signed-off-by: carolxob <[email protected]> * Minor adjustements to commit. Signed-off-by: carolxob <[email protected]> * Corrected per query monitor phrasing. Signed-off-by: carolxob <[email protected]> --------- Signed-off-by: carolxob <[email protected]> Co-authored-by: Melissa Vagi <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
* Add maximum allowed monitor number. Signed-off-by: carolxob <[email protected]> * Added note to comment on in GitHub. Signed-off-by: carolxob <[email protected]> * Update _observing-your-data/alerting/monitors.md Co-authored-by: Melissa Vagi <[email protected]> * Edits from doc review incorporated. Signed-off-by: carolxob <[email protected]> * Update _observing-your-data/alerting/monitors.md Co-authored-by: Nathan Bower <[email protected]> * Trying to commit. Signed-off-by: carolxob <[email protected]> * Minor adjustements to commit. Signed-off-by: carolxob <[email protected]> * Corrected per query monitor phrasing. Signed-off-by: carolxob <[email protected]> --------- Signed-off-by: carolxob <[email protected]> Co-authored-by: Melissa Vagi <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
Description
Adds the maximum allowed number of monitors to the existing Monitors doc.
Issues Resolved
Closes #1798
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.