Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maximum allowed monitor number. #3732

Merged
merged 8 commits into from
Apr 17, 2023
Merged

Add maximum allowed monitor number. #3732

merged 8 commits into from
Apr 17, 2023

Conversation

carolxob
Copy link
Contributor

Description

Adds the maximum allowed number of monitors to the existing Monitors doc.

Issues Resolved

Closes #1798

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@carolxob carolxob self-assigned this Apr 10, 2023
_observing-your-data/alerting/monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/monitors.md Show resolved Hide resolved
Copy link
Collaborator

@Naarcha-AWS Naarcha-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting suggestion, otherwise LGTM.

_observing-your-data/alerting/monitors.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carolxob Please see my comments and changes and tag me once addressed. Thanks!

_observing-your-data/alerting/monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/monitors.md Outdated Show resolved Hide resolved
@carolxob
Copy link
Contributor Author

@natebower This is ready for review. Thanks!

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carolxob carolxob merged commit efc59b3 into main Apr 17, 2023
vagimeli added a commit that referenced this pull request Apr 25, 2023
* Add maximum allowed monitor number.

Signed-off-by: carolxob <[email protected]>

* Added note to comment on in GitHub.

Signed-off-by: carolxob <[email protected]>

* Update _observing-your-data/alerting/monitors.md

Co-authored-by: Melissa Vagi <[email protected]>

* Edits from doc review incorporated.

Signed-off-by: carolxob <[email protected]>

* Update _observing-your-data/alerting/monitors.md

Co-authored-by: Nathan Bower <[email protected]>

* Trying to commit.

Signed-off-by: carolxob <[email protected]>

* Minor adjustements to commit.

Signed-off-by: carolxob <[email protected]>

* Corrected per query monitor phrasing.

Signed-off-by: carolxob <[email protected]>

---------

Signed-off-by: carolxob <[email protected]>
Co-authored-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
vagimeli added a commit that referenced this pull request Apr 25, 2023
vagimeli added a commit that referenced this pull request May 4, 2023
* Add maximum allowed monitor number.

Signed-off-by: carolxob <[email protected]>

* Added note to comment on in GitHub.

Signed-off-by: carolxob <[email protected]>

* Update _observing-your-data/alerting/monitors.md

Co-authored-by: Melissa Vagi <[email protected]>

* Edits from doc review incorporated.

Signed-off-by: carolxob <[email protected]>

* Update _observing-your-data/alerting/monitors.md

Co-authored-by: Nathan Bower <[email protected]>

* Trying to commit.

Signed-off-by: carolxob <[email protected]>

* Minor adjustements to commit.

Signed-off-by: carolxob <[email protected]>

* Corrected per query monitor phrasing.

Signed-off-by: carolxob <[email protected]>

---------

Signed-off-by: carolxob <[email protected]>
Co-authored-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
vagimeli added a commit that referenced this pull request May 5, 2023
@vagimeli vagimeli deleted the max-monitors branch August 22, 2023 21:05
@vagimeli vagimeli added the 3 - Done Issue is done/complete label Aug 22, 2023
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
* Add maximum allowed monitor number.

Signed-off-by: carolxob <[email protected]>

* Added note to comment on in GitHub.

Signed-off-by: carolxob <[email protected]>

* Update _observing-your-data/alerting/monitors.md

Co-authored-by: Melissa Vagi <[email protected]>

* Edits from doc review incorporated.

Signed-off-by: carolxob <[email protected]>

* Update _observing-your-data/alerting/monitors.md

Co-authored-by: Nathan Bower <[email protected]>

* Trying to commit.

Signed-off-by: carolxob <[email protected]>

* Minor adjustements to commit.

Signed-off-by: carolxob <[email protected]>

* Corrected per query monitor phrasing.

Signed-off-by: carolxob <[email protected]>

---------

Signed-off-by: carolxob <[email protected]>
Co-authored-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete observability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Maximum allowed monitors
5 participants