Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in historical analysis and custom result index #888

Closed
wants to merge 133 commits into from

Conversation

jackiehanyang
Copy link
Collaborator

Description

Fix the following issues:

  1. wrong route path in running historical analysis
  2. When disabling customer result index after enabling it, the field is not getting reset to undefined which leads an error on create detector review page says empty custom result index name

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

amitgalitz and others added 30 commits April 20, 2022 09:30
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 74b644c)
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit b25860d)
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 96a0ab2)
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 13c0962)
…t#278) (opensearch-project#280)

* Fix missing data call out if window delay is large

The missing feature callout only shows when fetching feature data points based on the interval and time range, and if there are any empty points Previously, when I configured the window delay to 20 minutes, the missing data call out will show. The reason is that the window delay offset isn't being considered in the time range used in the feature fetching query, or in the displayed chart, such that it shows as empty, when it's actually expected to be empty based on the window delay.This PR fixed the bug by considering window delay in missing feature calculations.

Testing done:
1. done e2e testing and verified the problem is fixed.
2. added unit tests.

Signed-off-by: Kaituo Li <[email protected]>
(cherry picked from commit 9d34ba2)

Co-authored-by: Kaituo Li <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 0d74e1a)
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 3b80bda)
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 6f736d7)
Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit d973b8e)
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 45a56ee)
Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit 77c0931)

Co-authored-by: Jackie Han <[email protected]>
…#306)

* fix failed unit tests

Signed-off-by: Jackie Han <[email protected]>

* Fix parse result bug for feature attribution

Signed-off-by: Jackie Han <[email protected]>

Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit 7ace8b4)
…#310) (opensearch-project#311)

Signed-off-by: Jackie Han <[email protected]>

Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit 25431a0)

Co-authored-by: Jackie Han <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>

Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 5dd0162)
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 6417553)
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 7ec2eab)
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 6958004)
…rch-project#334)

* Add windows platform in CI workflow

Signed-off-by: Jackie Han <[email protected]>

* Adjust text content for buidling on Windows

Signed-off-by: Jackie Han <[email protected]>

* Update long text message format in FormattedFormRow

Signed-off-by: Jackie Han <[email protected]>

* Update long text message format in FormattedFormRow

Signed-off-by: Jackie Han <[email protected]>

* Update long text message format in FormattedFormRow

Signed-off-by: Jackie Han <[email protected]>

* Update long text message format in FormattedFormRow

Signed-off-by: Jackie Han <[email protected]>

* Update long text message format in FormattedFormRow

Signed-off-by: Jackie Han <[email protected]>

* Update long text message format in FormattedFormRow

Signed-off-by: Jackie Han <[email protected]>

Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit d8af147)

Co-authored-by: Jackie Han <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit a2474d6)
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 0ee7503)
opensearch-project#384) (opensearch-project#386)

Signed-off-by: Jackie Han <[email protected]>

Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit ecd0814)

Co-authored-by: Jackie Han <[email protected]>
opensearch-trigger-bot bot and others added 18 commits August 8, 2024 16:13
Signed-off-by: Eric <[email protected]>
(cherry picked from commit 4c49c8c)

Co-authored-by: Eric Wei <[email protected]>
* header redesign

Signed-off-by: Jackie Han <[email protected]>

* update snapshot

Signed-off-by: Jackie Han <[email protected]>

---------

Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit 399025a)

Co-authored-by: Jackie Han <[email protected]>
Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>
) (opensearch-project#847)

* Changed context menus to be small

Signed-off-by: Dan Dong <[email protected]>

* Updated tabs to be small

Signed-off-by: Dan Dong <[email protected]>

* Updated paragraph text to be EuiText size="s"

Signed-off-by: Dan Dong <[email protected]>

* Updated semantic headers

Signed-off-by: Dan Dong <[email protected]>

* Updated primary buttons

Signed-off-by: Dan Dong <[email protected]>

* Reverted unintended changes

Signed-off-by: Dan Dong <[email protected]>

* Updated snapshot testing

Signed-off-by: Dan Dong <[email protected]>

* Fixed merge conflict

Signed-off-by: Dan Dong <[email protected]>

* Updated snapshot tests

---------

Signed-off-by: Dan Dong <[email protected]>
(cherry picked from commit 07908a0)

Co-authored-by: Dan Dong <[email protected]>
…pensearch-project#851) (opensearch-project#853)

* Add Missing Value Imputation Options and Update Shingle Size Limit

This PR introduces a new missing value imputation feature with three options: zero, fixed values, and previous values. When the fixed values option is selected, users can input custom values for each feature. Validation logic has been added to ensure that the feature names and the number of custom values match the number of enabled features.

Additionally, the review page and model configuration page have been updated to properly display these new parameters.

This PR also increases the maximum shingle size to 128, aligning with the backend implementation.

Testing:
* Updated existing unit tests to reflect these changes.
* Conducted manual end-to-end testing.

Signed-off-by: Kaituo Li <[email protected]>

* remove console log

Signed-off-by: Kaituo Li <[email protected]>

---------

Signed-off-by: Kaituo Li <[email protected]>
(cherry picked from commit 3ed0058)

Co-authored-by: Kaituo Li <[email protected]>
…t#859) (opensearch-project#860)

This PR introduces suppression anomaly rules under the Advanced Settings section, enabling users to suppress anomalies based on the difference between expected and actual values, either as an absolute value or a relative percentage.

Testing:
* Added unit tests to verify the suppression rules functionality.
* Conducted manual end-to-end (e2e) tests to validate the implementation.

Signed-off-by: Kaituo Li <[email protected]>
(cherry picked from commit 9874c48)

Co-authored-by: Kaituo Li <[email protected]>
…-project#830) (opensearch-project#833)" (opensearch-project#862)

* Revert "Add Enable Flattened custom result index checkbox (opensearch-project#830) (opensearch-project#833)"

This reverts commit f53450c.

* update snapshot

Signed-off-by: Jackie Han <[email protected]>

---------

Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit b06f1f7)

Co-authored-by: Jackie Han <[email protected]>
Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit 12fd1b2)

Co-authored-by: Jackie Han <[email protected]>
…ect#849) (opensearch-project#873)

* Add generate anomaly detector action to discover page

Signed-off-by: gaobinlong <[email protected]>

* Add more test code and rename the file

Signed-off-by: gaobinlong <[email protected]>

* Modify flyout header

Signed-off-by: gaobinlong <[email protected]>

* Make the detectorName follow the convention

Signed-off-by: gaobinlong <[email protected]>

* Truncate the index pattern name if it's too long

Signed-off-by: gaobinlong <[email protected]>

* Move entry point to query editor

Signed-off-by: gaobinlong <[email protected]>

* Call the node API in dashboard-assistant plugin to generate parameters

Refactor unit test code

Signed-off-by: gaobinlong <[email protected]>

* Fix test failure

Signed-off-by: gaobinlong <[email protected]>

* Revert the code format

Signed-off-by: gaobinlong <[email protected]>

* Remove some empty lines

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
(cherry picked from commit ec02b63)

Co-authored-by: gaobinlong <[email protected]>
Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>
@opensearch-trigger-bot opensearch-trigger-bot bot added documentation Improvements or additions to documentation github actions Updating or adding GitHub actions dependencies Pull requests that update a dependency file backport 2.x labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation github actions Updating or adding GitHub actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants