Wait for detector to load before checking indices exist #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <[email protected]>
ohltyler
approved these changes
May 17, 2022
|
@amitgalitz we want to backport to 2.0 as well right? |
yes and 1.x, 1.3, forgot to add labels, just added them |
ylwu-amzn
approved these changes
May 17, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 17, 2022
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 3b1b845)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 17, 2022
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 3b1b845)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 17, 2022
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 3b1b845)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 17, 2022
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 3b1b845)
amitgalitz
added a commit
that referenced
this pull request
May 17, 2022
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 3b1b845)
amitgalitz
added a commit
that referenced
this pull request
May 17, 2022
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 3b1b845)
amitgalitz
added a commit
that referenced
this pull request
May 17, 2022
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 3b1b845)
amitgalitz
added a commit
that referenced
this pull request
May 17, 2022
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 3b1b845)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amit Galitzky [email protected]
Description
Added two new conditions to two different
useEffectcalls onDetectorDetailpage.First change is to wait for getDetector request to finish loading before checking if the indices themselves exist. Currently we are checking if the indices exist on every change to the detector and while the detector is still loading it continuously loops this API call to check for indices. This then triggers a change in AppState which triggers the change in
detectorvariable hence the loop.The second change is under the same idea where we don't need to call the
useEffectthat calls onhideStopDetectorModalif the detector itself is empty.Further improvements will be made in later PR to optimize
useFetchDetectorInfofurther which is the call updating thedetectorvariable.Issues Resolved
resolves #251
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.