Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove additional loading spinners and removing master from docker compose #243

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

amitgalitz
Copy link
Member

@amitgalitz amitgalitz commented Apr 18, 2022

Signed-off-by: Amit Galitzky [email protected]

Description

Remove additional loading spinners that were accidentally added and changing master in docker compose setting to cluster_manager

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amitgalitz amitgalitz added the bug Something isn't working label Apr 18, 2022
@amitgalitz amitgalitz requested a review from a team April 18, 2022 18:28
ohltyler
ohltyler previously approved these changes Apr 18, 2022
@ohltyler ohltyler requested a review from ylwu-amzn April 19, 2022 15:28
ylwu-amzn
ylwu-amzn previously approved these changes Apr 19, 2022
@amitgalitz amitgalitz requested a review from ohltyler April 19, 2022 17:55
@amitgalitz amitgalitz dismissed stale reviews from ylwu-amzn and ohltyler via c47a1bb April 19, 2022 17:59
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

Codecov Report

Merging #243 (c47a1bb) into main (535b8ef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #243   +/-   ##
=======================================
  Coverage   45.92%   45.92%           
=======================================
  Files         150      150           
  Lines        4956     4956           
  Branches      955      955           
=======================================
  Hits         2276     2276           
  Misses       2463     2463           
  Partials      217      217           
Impacted Files Coverage Δ
...pages/DetectorDetail/containers/DetectorDetail.tsx 16.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 535b8ef...c47a1bb. Read the comment docs.

@amitgalitz amitgalitz changed the title remove additional loading spinners remove additional loading spinners and removing master from docker compose Apr 19, 2022
@amitgalitz amitgalitz merged commit 2964522 into opensearch-project:main Apr 19, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 19, 2022
…mpose (#243)

Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 2964522)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 19, 2022
…mpose (#243)

Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 2964522)
amitgalitz added a commit that referenced this pull request Apr 20, 2022
…mpose (#243)

Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 2964522)
amitgalitz added a commit that referenced this pull request Apr 20, 2022
…mpose (#243)

Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 2964522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.0 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants