-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove additional loading spinners and removing master from docker compose #243
Merged
amitgalitz
merged 2 commits into
opensearch-project:main
from
amitgalitz:remove_spinners
Apr 19, 2022
Merged
remove additional loading spinners and removing master from docker compose #243
amitgalitz
merged 2 commits into
opensearch-project:main
from
amitgalitz:remove_spinners
Apr 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <[email protected]>
ohltyler
previously approved these changes
Apr 18, 2022
ylwu-amzn
previously approved these changes
Apr 19, 2022
Signed-off-by: Amit Galitzky <[email protected]>
ohltyler
approved these changes
Apr 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #243 +/- ##
=======================================
Coverage 45.92% 45.92%
=======================================
Files 150 150
Lines 4956 4956
Branches 955 955
=======================================
Hits 2276 2276
Misses 2463 2463
Partials 217 217
Continue to review full report at Codecov.
|
amitgalitz
changed the title
remove additional loading spinners
remove additional loading spinners and removing master from docker compose
Apr 19, 2022
jackiehanyang
approved these changes
Apr 19, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
…mpose (#243) Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 2964522)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
…mpose (#243) Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 2964522)
amitgalitz
added a commit
that referenced
this pull request
Apr 20, 2022
…mpose (#243) Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 2964522)
amitgalitz
added a commit
that referenced
this pull request
Apr 20, 2022
…mpose (#243) Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 2964522)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amit Galitzky [email protected]
Description
Remove additional loading spinners that were accidentally added and changing
master
in docker compose setting tocluster_manager
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.